16:56:44 <m-relay> <s​needlewoods_xmr:matrix.org> Not sure if I can make it to the meeting, so here is my report in advance:
16:56:45 <m-relay> <s​needlewoods_xmr:matrix.org> Worked on `set_variable()` and replaced `i_wallet2_callback` with `WalletListener`, but need to test and make sure there is no regression.
16:56:47 <m-relay> <s​needlewoods_xmr:matrix.org> Currently `grep "\<m_wallet\>" src/simplewallet/simplewallet.cpp -c` gives 445 results
16:57:59 <m-relay> <r​brunner7:monero.social> Thanks for the report.
16:58:03 <m-relay> <r​brunner7:monero.social> Meeting in about 1 hour
18:00:02 <m-relay> <r​brunner7:monero.social> Meeting time. Hello! https://github.com/monero-project/meta/issues/1214
18:00:24 <m-relay> <j​berman:monero.social> *waves*
18:02:08 <m-relay> <r​brunner7:monero.social> Alright, maybe fewer participants than usual. What is there to report from last week?
18:02:44 <m-relay> <r​brunner7:monero.social> For the record: SNeedlewoods reported earlier that they are still making their way through simplewallet, converting to the Wallet API
18:03:15 <m-relay> <r​brunner7:monero.social> I myself made my first PR since quite a long time: https://github.com/monero-project/monero/pull/9939
18:03:32 <m-relay> <j​berman:monero.social> Opened this PR to fix tests and am working through some bugs for some failing tests atm: https://github.com/seraphis-migration/monero/pull/50
18:04:21 <m-relay> <r​brunner7:monero.social> Do you have good coverage with the existing tests?
18:04:34 <m-relay> <r​brunner7:monero.social> I mean, not too many things really particular to FCMP++ and Carrot
18:05:25 <moneromooo> What is (are? ) the benefit of changing simplewallet to use the wallet API ?
18:05:31 <m-relay> <j​berman:monero.social> I'd say yes, I'm working through functional tests at the moment
18:05:44 <moneromooo> nvm, I'll ask later
18:06:14 <m-relay> <r​brunner7:monero.social> moneromooo: The "endgame" that we plan is moving everything away from wallet2.h to the Wallet API to get the freedom to re-implement the wallet
18:06:37 <m-relay> <j​berman:monero.social> Some more context https://github.com/seraphis-migration/wallet3/issues/64
18:06:43 <moneromooo> So the wallet api will no longer be a layer above wallet2 then ?
18:06:54 <m-relay> <r​brunner7:monero.social> Thanks, I knew I wrote something deep in the past about that :)
18:07:07 <m-relay> <r​brunner7:monero.social> Ideally, yes.
18:07:29 <moneromooo> Ah, yes, wallet3. Forgot aout this. Makes sense now.
18:07:34 <m-relay> <r​brunner7:monero.social> Maybe the wallet implementation itself, or a layer above ... something else, hopefully better structured
18:08:15 <m-relay> <r​brunner7:monero.social> So nice that the existing functional tests for transactions are still useful and have results, i.e. help you find bugs
18:08:37 <m-relay> <r​brunner7:monero.social> But I guess at some point some more specific tests for the new tech will be added?
18:10:24 <m-relay> <j​berman:monero.social> The integration brings a lot of major changes internally that these tests are hitting because they are wider in scope
18:10:25 <m-relay> <j​berman:monero.social> We've also been testing specific functionality as it's been added along the way (e.g. my tree code has extensive unit testing), with more planned too
18:11:11 <m-relay> <j​berman:monero.social> jeffro256: also has added hefty amount of Carrot specific unit tests too
18:11:49 <m-relay> <j​berman:monero.social> 8 new "carrot_" unit test files
18:11:58 <m-relay> <r​brunner7:monero.social> Sounds solid.
18:12:07 <m-relay> <r​brunner7:monero.social> I guess that's the way with really complex code.
18:12:33 <m-relay> <r​brunner7:monero.social> Alright, if you don't have something special to bring up, maybe we can already wrap up the meeting.
18:13:56 <m-relay> <r​brunner7:monero.social> Thanks for attending, read you again next week!
18:15:45 <m-relay> <j​berman:monero.social> @moneromooo do you recall off the top of your head any benefit outside of tests to supporting a way to create alt block templates via `create_block_template`?
18:16:18 <m-relay> <j​berman:monero.social> as in, block templates on top of an alternative chain
18:17:02 <moneromooo> I... do not.
18:17:16 <m-relay> <j​berman:monero.social> (I ask because as the FMCP++ integration is currently implemented, the daemon would no longer be able to do that, and it's a huge lift to be able to do that)
18:17:29 <moneromooo> I do not even remember why I added this.
18:17:43 <m-relay> <j​berman:monero.social> I don't think it was you, think it was there for tests from day 1
18:17:48 <moneromooo> Oh, OK.
18:18:28 <moneromooo> I do remember monkeying around with that though a few years back...
18:18:57 <m-relay> <r​brunner7:monero.social> Somehow sounds like a way to make 51% attacks a bit easier :)
18:19:54 <m-relay> <j​berman:monero.social> there was a new functional test for it that you added that I had to get rid of after implementing including FCMP++ merkle tree root in the block PoW hash
21:21:33 <m-relay> <d​angerousfreedom:matrix.org> Wow! A lot of things have been done in the past year! Thank you very much for the efforts rbrunner7 , jberman , jeffro256  and everyone! I will slowly try to update myself and the moneroinflation.com. jeffro256 , where should I start reading about CARROT?
21:24:25 <m-relay> <j​effro256:monero.social> Hi dangerousfreedom , it's great to see you again!
21:24:38 <m-relay> <j​effro256:monero.social> https://github.com/jeffro256/carrot/blob/master/carrot.md is a good starting point for Carrot
21:31:57 <m-relay> <j​berman:monero.social> welcome back!
21:44:16 <plowsof> welcome back dangerousfreedom