16:55:27 Meeting in a bit more than 1 hour 16:57:28 In case I can't make today's meeting (looking unlikely), my update in advance: all expected tests now pass in fcmp++-stage (we have green CI), shared a TODO list for launch issue tracker (https://github.com/seraphis-migration/monero/issues/53), made serious headway on destroying FFI types correctly thanks to @jeffro256 (https://github.com/seraphis-migration/monero/pull/39). 16:57:30 Working on finishing that last task, and allowing txs with >8 inputs next 18:00:02 Meeting time. Hello! https://github.com/monero-project/meta/issues/1218 18:01:30 hey 18:02:24 Probably no wave today from jberman , he left his report already about an hour ago 18:02:53 His TODO list for launch looks interesting: https://github.com/seraphis-migration/monero/issues/53 18:03:14 Do you have something to report? 18:04:39 I think I have found an overlap from that TODO list with my work on wallet-cli, there are two settings `default-ring-size` and `print-ring-members` that I would not add to the Wallet API 18:05:41 hi 18:06:02 unfortunately GUI and CLI settings differ, CLI settings are stored in the wallet file handled by wallet2 so I think they have to be part of the Wallet API 18:07:03 The GUI differs? You mean it offers a different set of settings, or stores them in a different way? The latter would be surprising 18:08:24 Maybe it does not offer all of them 18:09:30 `default-ring-size` is of course obsolete already for a long time and probably only presereved to avoid all risk something goes astray if a wallet has that set 18:09:38 sorry not well prepared, here is the set of settings for GUI https://github.com/monero-project/monero-gui/blob/4e9b0ae000b702a7fbdc4770869a48480aee2cc3/main.qml#L1378-L1480 18:09:40 *preserved 18:11:54 I think what you see there is a mix of GUI specific settings, app global i.e. not per wallet, and wallet specific settings that go into the wallet file like they do if you use the CLI wallet 18:13:17 but for example `allow_background_mining` or `restore_height` are also CLI settings 18:14:17 though IIRC that `restore_height` in GUI is only used for restore, else it relies on the `m_restore_height` or however it's called in wallet2 18:15:26 it's a bit tricky, but I think I'm on the right track 18:16:31 Anyway, I think both the CLI and the GUI code should be quite simple. It's also quite easy to see in the `wallet2` code itself what settings exactly are stored in the wallet files themselves. Will just take work and patience :) 18:17:13 That code is anyway the "ultimate source of truth" for per-wallet options 18:18:09 I have added an option or two myself there, in the good old times 18:19:36 Looks like the FCMP++ coding competition's end as set so far is less than 1 month away: https://github.com/j-berman/fcmp-plus-plus-optimization-competition 18:19:57 I wonder whether somebody got confirmation already that at least *somebody* is working on something 18:21:25 jberman or jeffro256 , if you know something, please drop it later, just for curiosity's sake 18:22:02 sagewilder are you still participating to the tournament ? 18:23:36 Alright, anything else for today? With things running so smoothly at the moment, meetings are a piece of cake :) 18:25:45 Did you see selsta say next release will be tagged in two weeks? I wonder if subnet deduplication might be reviewed and approved before then. 18:26:38 Everything ready to merge to release branch in a mere two weeks looks unlikely IMHO 18:26:53 nothing from me 18:26:54 just thanks to jeffro and jberman for their hard work, got a ton of mails from the seraphis-migration repo recently lol 18:27:16 Right, the amount of PRs they do at the moment is amazing 18:28:02 It's a bit of a pity that it might miss the next release 18:29:08 Critical things often get some time of running them on master, just to be sure. And peer selection better works, right 18:29:11 I don't feel qualified for a review for the subnet PR 18:30:09 Yeah, it's a different corner of the codebase than on what you worked so far 18:31:17 Ok, I think we can close for today. Thanks everbody for attending, read you again next week, the week just before - hurray! - MoneroKon 18:31:50 thanks and cu 18:46:02 No 18:49:24 Awww ... 18:51:53 I underestimated the challenge of this competition and was sidetracked by another commitment. 18:52:46 https://matrix.monero.social/_matrix/media/v1/download/monero.social/IJhOpblsSgytlJLRhkBjHYZI