07:45:07 SNeedlewoods: I finally found time to look at that priority enum question. 07:47:57 To me it looks as if the Wallet API definition predates the introduction of the *Priority* / *Very High* fee level, i.e. was defined at a time where really only 3 levels existed. Thus `Priority_Last` does indeed look to me as a way to go the highest fee level, without having to know which one that is; it doesn't mean *Priority* IMO. 07:48:50 Thus I would opt for b). 07:49:05 I think there was a comment on a pr that the last priority isnt necessarily 4, but is the highest 07:49:32 disclaimer: My memory may be unreliable 07:51:00 Yes, any sensible use that I can come up with for `Priority_Last` has to do with getting at the highest existing fee level, whatever it is, whatever it's called. Approach b) would preserve that logic. 07:52:00 https://github.com/monero-project/monero/pull/9838#discussion_r2109637110 07:52:01 Maybe here 07:53:19 https://github.com/monero-project/monero/pull/9838#discussion_r2085345796 08:11:36 As far as I can see, that PR does not deal with anything Wallet API, except adding a type transfer from enum to int that became necessary because of a change in wallet2. But it makes perfectly clear that the supported fee levels go from 1 to 4, so it's really time to reflect that at long last in the Wallet API. 08:26:35 yeah, just the comment/review there 10:46:56 thank you 🙏