17:05:07 Meeting in a bit less than 1 hour 18:00:01 Meeting time. Hello! https://github.com/monero-project/meta/issues/1279 18:00:22 *waves* 18:00:23 Hey 18:01:07 Howdy 18:01:30 hi 18:02:17 Alright, I think we can already start with the reports from last week 18:02:20 I can soon make a film out of the FCMP++ GitHub repo mails that I receive, starting with 24 pieces per second :) 18:02:28 made a [PR](https://github.com/monero-project/monero/pull/10165) for the issue where estimated block height is above actual block height 18:02:32 also made a little progress on the CLI, `sweep_single` should be done, `m_wallet` count is down to 15 18:02:33 ~30 TODO comments left, an incomplete list of some of the things: 18:02:35 - `cold_sign_tx()` 18:02:37 - `--restore-multisig-wallet`, `--generate-from-json` 18:02:39 - handling of some exceptions and error messages (e.g. [handle_transfer_exception](https://github.com/monero-project/monero/blob/8d4c625713e3419573dfcc7119c8848f47cabbaa/src/simplewallet/simplewallet.cpp#L617)) 18:02:53 And I want to mention that I received an offer from binarybaron to spend some hours reviewing their wallet code. That could be a good incentive to learn rust. Of course my CCS would have priority, I'd aim to spend 20h/week (12h/week were advertised and the total is already exceeded, though I really want to finish it) on that and only work on eigenwallet if I have time beyond that, but I think I'm relatively close to getting into review phase for the CLI (hopefully not more than a month until a PR is made) and if I don't have enough CCS work by then, I'd spend more time on the eigenwallet review. 18:02:56 Any thoughts/opinions? 18:03:47 I got carrot subaddresses working lws, but I had to modify make_carrot_subaddress_v1 (used in unit test), and tweak the relevant carrot spec. Eagerly waiting to get feedback on whether my tweak was valid 18:04:51 me: almost exclusively worked on stressnet issues, made a number of PR's fixing some connectivity issues and wallet slowness, continuing investigating different issues 18:05:39 btw it was jbermans suggestion to use recent hard fork height from `hardforks.cpp`, which I think was a great idea 18:06:27 Where is the tweak at? 18:07:07 I just PR’ed something to your carrot repo 18:07:15 ~15 mins ago 18:07:54 it was pretty minor as all of the unit tests still pass, but it affected the make_carrot_subaddress_v1 function which I was using in a lws unit test 18:08:17 Okay responding to that now 18:09:12 SNeedlewoods: IMHO such a course of action regarding your work hours, as you described it here, would be ok. How do other people here see this? 18:10:31 I think there were times also where jberman distributed time to his Monero CCS and some Rust / Serai work. As long as it's done in good faith, and in the open, I don't see a problem. 18:11:11 IIUC, binarybaron is offering to pay you separately from your CCS to review their wallet code? 18:11:43 yes 18:12:13 me: reworked large portions of the Carrot Rust library and opened a PR to hopefully speed input verification in many large-load cases: https://github.com/monero-project/monero/pull/10157 18:12:20 no issue at all with that! pretty cool of binarybaron 18:13:05 vtnerd: https://github.com/jeffro256/carrot/pull/5#issuecomment-3398566553 18:13:24 thanks for the feedback, appreciate it :) 18:13:49 1 other related task that I think would be very nice re: that wallet restore stuff SNeedlewoods is finding a way for wallets with an expected daemon connection to set the restore height using the daemon's reported height, rather than the offline estimate 18:14:04 jeffro256: Just curious, was that Carrot Rust library rework a result of insights and experience gained in the meantime, since writing the original library version? 18:14:14 offline estimate is a welcome improvement for sure tho 18:15:08 we discussed that connection stuff a bit last week, those logs may be helpful 18:15:13 kayabanerve: gave a lot of good feedback on how to make it Rustier 18:16:02 Rustier, lol 18:16:27 (and this PR sort of mentions it: https://github.com/seraphis-migration/monero/pull/162 , we probably shouldn't need to override the restore height in that step 2, it's only there because the wallet's initial creation isn't using a functional daemon connection) 18:16:54 isn't that already happening here https://github.com/monero-project/monero/blob/d32b5bfe18e2f5b979fa8dc3a8966c76159ca722/src/wallet/wallet2.cpp#L5703-L5729 18:16:55 or am I misunderstanding? 18:17:50 problem is when that's called with the GUI e.g., the wallet doesn't have the connection to the daemon established yet 18:19:49 I also looked in the GUI side, but didn't have enough time to figure out how that works exactly, but it seems it uses `restore_height` from `persistentSettings`, and that is the restore height of the wallet that was opened before 18:20:09 will try to figure that out this week 18:20:40 the context described in that linked PR description may help 18:21:11 Regarding that potential Carrot sub-address generation problem: One would really hope that if there was a problem in there, audit(s) should have unearthed it already? 18:22:14 A problem of that magnitude that gets through until implementation and only gets stopped by some unit tests failing would worry me ... 18:23:37 We will certainly soon see how this plays out :) 18:24:30 Alright, seems we are through with reports and coordination. Anything else to discuss today? 18:24:41 It shouldn't be an issue AFAIK, it looks like a notation mixup 18:25:07 rbrunner7: you might be interested in this PR: https://github.com/seraphis-migration/monero/pull/162 18:25:20 it touches the incremental pool stuff 18:25:37 to make refresh/show_transfers fast on every call 18:25:52 ... that my old brain probably already forgot almost completely 18:26:08 No, seriously, will try to have a look 18:27:58 I'm happy to test it when new release is out 18:29:43 nothing else to discuss for me 18:30:38 So we won't prevent busy people working on stressnet any longer! Thanks for attending everybody, read you again next week 18:35:49 thanks everyone