16:48:54 <br-m> <jberman> this seems ok, considering polyseed_decode returns an error if something decodes as multiple langs: https://github.com/tevador/polyseed/pull/12 > <@rbrunner7> That can be done with a few lines of code: Generate a new Polyseed at random, see whether the language can be decided automatically, if not generate a new Polyseed at random, until success.
16:48:54 <br-m> <jberman> I think worth checking if you need to trim the seed phrase when trying to decode (I think you do, don't have the exact code in front of me)
16:49:36 <br-m> <jberman> the seed phrase words*
17:03:39 <br-m> <rbrunner7> Yes, there is support for detecting ambigous seeds, it was one of the most recent changes of Tevador. Not sure what you mean with "trim the seed phrase", but it probably does not matter :)
17:03:50 <br-m> <rbrunner7> Meeting in a bit less than 1 hour
17:23:55 <br-m> <jberman> @rbrunner7: this should clarify https://github.com/tevador/polyseed/issues/11
18:00:01 <br-m> <rbrunner7> Meeting time. Hello! https://github.com/monero-project/meta/issues/1412
18:00:08 <br-m> <sneedlewoods_xmr:matrix.org> Hi
18:00:19 <br-m> <jberman> waves
18:00:20 <br-m> <jpk68:matrix.org> Hello
18:01:16 <selsta> hi
18:01:45 <br-m> <rbrunner7> So, what are the reports from last week?
18:02:17 <br-m> <rbrunner7> I could make an update for my Polyseed PR. Most things are now either addressed, or waiting for some clarifications and/or opinions from reviewers.
18:02:34 <br-m> <sneedlewoods_xmr:matrix.org> Made a PR for the wallet-rpc https://github.com/monero-project/monero/pull/10819
18:02:34 <br-m> <sneedlewoods_xmr:matrix.org> Started reviewing the Polyseed PR by rbrunner7
18:02:38 <br-m> <sneedlewoods_xmr:matrix.org> Preparing a new CCS proposal and planning to include potentially work on restore height issues, would like to hear if anyone has any thoughts on this?
18:02:38 <br-m> <sneedlewoods_xmr:matrix.org> (besides: a) work on Wallet API, walllet-cli and wallet-rpc review comments and b) do reviews / help out where I can)
18:02:38 <br-m> <sneedlewoods_xmr:matrix.org> so the proposed tasks currently look like this:
18:02:38 <br-m> <sneedlewoods_xmr:matrix.org> https://mrelay.p2pool.observer/p/9u-t8JELTkhrQ2wt/1.txt (code snippet, 10 lines)
18:02:45 <br-m> <sneedlewoods_xmr:matrix.org> Last meeting jeffro256 said that ideally all the Wallet API changes could make it into v0.19, for that I would need to rebase the API/CLI/RPC changes onto the polyseed PR AFAICT, do you think that is also a task worth to add to the CCS proposal?
18:03:23 <br-m> <jpk68:matrix.org> Finished the first milestone of my CCS for I2P work, having to do with the core daemon implementation
18:03:24 <br-m> <rbrunner7> Nice milestone again, @sneedlewoods_xmr:matrix.org !
18:04:35 <selsta> One thing that I just remembered, wallet_api apparently has some bugs with refresh thread https://github.com/oxen-io/oxen-core/pull/1466
18:04:55 <selsta> this should be investigated and fixed on our side before we switch all wallets to it.
18:05:54 <br-m> <jberman> me: finished reviewing @jeffro256:monero.social 's mega hot-cold PR for FCMP++/Carrot, believe we now solved @rucknium:monero.social  sporadic double spend issue and will finalize an upstream PR for that today ( https://github.com/seraphis-migration/monero/issues/365#issuecomment-4811722029 ), and I'm going to have all upstr [... too long, see https://mrelay.p2pool.observer/e/-fS58JELbW03SnU4 ]
18:05:59 <br-m> <rbrunner7> Good find. Maybe we corrected already on our side some time in the 5 years since then
18:06:22 <br-m> <rbrunner7> (to selsta)
18:06:29 <selsta> I don't think this ever got fixed on our side.
18:07:06 <br-m> <jberman> selsta: fwiw the new FCMP++ changes introduce a new refresh lock internally to wallet2
18:07:22 <br-m> <jpk68:matrix.org> jberman: Out of curiosity, does the 6x faster zero commit speed up anything besides FCMP++ crypto? As in, would it provide any speed improvement currently
18:07:42 <br-m> <jberman> @jberman: though it shouldn't hurt to fix the API's lock handling also
18:08:25 <br-m> <rbrunner7> Making sure @sneedlewoods_xmr:matrix.org is not running out of work anytime soon :)
18:09:58 <br-m> <jberman> @jpk68:matrix.org: yes, that function is currently used at consensus for coinbase outputs and for pre-RCT outputs. It's not a major bottleneck in current syncing, but it would marginally help syncing
18:10:25 <br-m> <rbrunner7> What is a "zero commit"?
18:10:46 <br-m> <jpk68:matrix.org> I have the same question :D
18:11:26 <DataHoarder> a commitment to the amount of 0, using Mask as `
18:11:29 <DataHoarder> as 1*
18:11:58 <br-m> <rbrunner7> Some "no money out of thin air" thing then?
18:12:03 <DataHoarder> mask scalar = 1, amount = 0 which as jberman is used in special cases like coinbase
18:12:06 <br-m> <jberman> when an output has a transparent amount, you calculate its commitment as amount * H (H is a generator specific to Monero)
18:12:07 <DataHoarder> which has public amounts
18:13:32 <br-m> <jberman> it's necessary so that transparent amount outputs can be used as inputs in future txs enabling you to construct a tx where sum of inputs == sum of outputs while still blinding amounts
18:15:28 <br-m> <jberman> it becomes more relevant in FCMP++ because all outputs' commitments are stored in the curve tree, which both the daemon and wallet build
18:15:59 <br-m> <jberman> so speeding this up has a more tangible impact on both wallet and daemon sync speed with FCMP++
18:16:09 <br-m> <rbrunner7> Next step up will be curve forest .. you read it here first ...
18:16:56 <br-m> <rbrunner7> Ok, ok, interesting reports. Do we have to discuss something beyond those today?
18:17:46 <selsta> I can only advertise again that we need reviews for v0.18.5.1 https://github.com/monero-project/monero/issues/10545
18:18:09 <selsta> all have at least one review but need a second before merge
18:18:32 <br-m> <rbrunner7> Will try to have a look, now with my PR update out of the door
18:19:05 <br-m> <jberman> can review those 2 by tomorrow as well
18:19:36 <br-m> <jberman> those 3*
18:19:46 <br-m> <rbrunner7> You will probably overtake me then :)
18:20:11 <br-m> <rbrunner7> Alright, looks like we are through. Thanks everybody for attending, read you again in 1 week!
18:21:54 <br-m> <sneedlewoods_xmr:matrix.org> thanks everyone