04:37:52 <br-m> <rbrunner7> Thanks, will have a look, probably this coming weekend
17:16:11 <br-m> <rbrunner7> Meeting in about 45 minutes
18:00:01 <br-m> <rbrunner7> Meeting time. Hello! https://github.com/monero-project/meta/issues/1452
18:00:05 <br-m> <sneedlewoods_xmr:matrix.org> hey
18:00:16 <br-m> <jpk68:matrix.org> Hello
18:00:20 <br-m> <jberman> waves
18:02:03 <br-m> <rbrunner7> Alright, on to the reports from last week. Me: The seemingly never-ending Polyseed PR review :)
18:02:10 <br-m> <jpk68:matrix.org> Me: played around with multisig support in the GUI, made some fixes, reviewed PRs, general testing
18:02:12 <selsta> hi
18:02:22 <br-m> <sneedlewoods_xmr:matrix.org> I think I finally addressed most AI review comments.
18:02:22 <br-m> <sneedlewoods_xmr:matrix.org> There were many legit and helpful comments, thanks to selsta, thomasbuilds and xmrack for providing those. Let me know if anyone wants to do another run.
18:02:24 <br-m> <sneedlewoods_xmr:matrix.org> Else there are currently three other things left for me to work on:
18:02:24 <br-m> <sneedlewoods_xmr:matrix.org> * during testing I stumbled upon issues with multisig, will need to double check they're solved
18:02:24 <br-m> <sneedlewoods_xmr:matrix.org> * jpk68 reported issues with hw devices
18:02:24 <br-m> <sneedlewoods_xmr:matrix.org> * rbrunner7 suggested a change to the wallet-rpc PR, to go the full way for using extendedStatus (src (https://github.com/monero-project/monero/pull/10819#discussion_r3728598122)), for which I have a WIP branch
18:03:08 <br-m> <rbrunner7> Fully going "extended status" would be really nice IMHO. A lot of work, but a win.
18:04:34 <br-m> <sneedlewoods_xmr:matrix.org> Have it on another branch currently, to not mess up the original PR if it turns out to not work as nicely, but at this moment I'm quite confident it's a good change
18:04:58 <selsta> I mostly worked on v0.18.5.3, which also seems like it keeps getting delayed due to new issues / reports / things to improve, I guess at some point we have to make a hard cut and just include the remaining things in the next release.
18:05:46 <br-m> <rbrunner7> "Next release" would still be 0.18, or the all-new shiny 0.19 already, branched from master?
18:06:07 <selsta> v0.19 already, that's why I wanted to include as much as possible now
18:06:23 <br-m> <jberman> mostly worked on hot/cold wallet review + upstream review
18:07:29 <br-m> <syntheticbird> selsta: if you drop v0.19 people are going to be more reactive to upcoming minor releases. So imho you should go with making a cut.
18:07:53 <br-m> <rbrunner7> It seems we currently have a lot of small PRs as well, improving little things left and right, which is nice, but means work
18:08:52 <selsta> j-berman: could you go through the ones you opened again for this release and that are not merged to check if there is anything to do? I'd like the serialization changes in from you and vtnerd
18:11:18 <br-m> <rbrunner7> So, seems we are through with the reviews. Do we have anything to discuss today beyond those?
18:13:01 <br-m> <jberman> selsta: serialization thing is the only thing, your suggestion there is good
18:13:59 <br-m> <rbrunner7> No special subject then. Short meeting :) Thanks everybody for attending, read you again next week!
18:14:25 <br-m> <jeffro256> Personally, I'm just deep in reviews (for my PRs and others)
18:14:32 <selsta> https://github.com/monero-project/monero/pull/11168 jeffro suggested a live test here
18:14:41 <selsta> meaning a sync from scratch or can it be done quicker with existing blockchain?
18:15:45 <br-m> <jeffro256> Ideally from scracth because it affects v1 txs in slightly different ways (mixed/pre-RingCT amount indices lookup)
18:16:01 <br-m> <jberman> I can do a sync from scratch. I had started one but seems we need 11204 in on master
18:16:20 <selsta> ideally it would be mainnet / testnet / stagenet from scratch
18:16:24 <br-m> <jberman> I can see if sync with 11204 + that PR are good
18:16:52 <br-m> <jberman> ultimately we're going to want to test sync from scratch with all of these PR's in together too
18:17:11 <selsta> yes maybe better to just wait until we have everything merged
18:18:43 <br-m> <sneedlewoods_xmr:matrix.org> Which exactly are the three PRs? I could try a full testnet for all of them
18:18:52 <br-m> <sneedlewoods_xmr:matrix.org> sync*
18:19:27 <selsta> 11168, 11204, 11206
18:19:34 <br-m> <sneedlewoods_xmr:matrix.org> ty
18:19:58 <br-m> <rbrunner7> By the way, this came up today in the MRL lounge, interesting stuff IMHO, copy this here in case some people did not yet see it: https://gist.github.com/1440000bytes/211ac92dd4433bb1a2e674bf0ff7db2e
18:20:06 <selsta> sneedlewoods_xmr: and also 11235
18:26:53 <selsta> this Liquid hack looks avoidable and they are lucky the hacker only kept 10%
18:37:34 <br-m> <rbrunner7> From the discussion in the MRL lounge I got that it seems half the network was running a basically not-yet-released version of the daemon, and that one was vulnerable. Pretty wild.