15:47:35 @sneedlewoods_xmr:matrix.org: Regarding your invitations to comment F3 and F4 from here: https://github.com/monero-project/monero/pull/9464#issuecomment-6000228481 15:49:14 I would do a separate PR just for F3, and do it now. Seems like an issue with potentially nasty consequences, so maybe make a fix now, we don't know yet when your big PRs will be ready. 15:49:57 I can't quite wrap my head around F4. I would say if there is an issue, same like for F3: Separate PR, and now. 15:51:40 Maybe I am totally wrong, but I can't get rid of some suspicion that if we add such a password check to wallet2::encrypt_keys the snake will somehow eat its own tail if you execute code that shall establish a changed password. 20:29:16 @rbrunner7: I share the suspicion, though I could not confirm it. Will try to look more into this tomorrow, thanks for your feedback