17:01:56 Meeting in 1 hour 17:04:17 hurray \o/ 18:00:02 Meeting time. Hello! https://github.com/monero-project/meta/issues/1471 18:00:12 Hey 18:00:29 Howdy 18:00:57 Hi 18:01:02 hi 18:01:36 Let's start already with the reports from last week. 18:02:07 I reviewed the PR for Polyseed in the GUI from selsta yesterday. Nice. 18:02:30 More fixes for #9464, also rebased and fixed conflicts for: #10232, #10233 and #10819, but I plan to push one after the other and see what issues come up through AI reviews, to prevent getting duplicates. 18:02:50 That's this one, in case anybody wants to have an early look: https://github.com/monero-project/monero-gui/pull/4729 18:02:53 v0.18.5.3 got released, no bug reports so far 18:03:17 I PR'ed this to defeat the Nyx eclipse attack: https://github.com/monero-project/monero/pull/11527 18:03:30 According to plan that's the last 18.x release, right? 18:03:41 yes 18:03:47 Splendid 18:04:36 That might be the longest and most detailed Monero PR description ever, @rucknium:monero.social :) 18:05:26 IMO the description is very helpful 18:05:46 It keeps going if you follow the link at the bottom :D 18:06:50 Might well be this will stop some similar attacks right in their tracks, without us knowing. 18:07:07 @rbrunner7:monero.social: I have a small question for you about a line of code you wrote for the subnet deduplication PR. Whenever you have time. 18:07:39 A lot of attacks use the small white_list limit as a starting point. 18:07:55 You can drop it here, or in a DM, and will look at it in a quiet moment in the next few days. 18:08:12 Ok. I will ask at the end of the meeting. 18:08:48 Hello, sorry for being late ;) 18:09:13 I forgot what I did this week 18:09:20 Stressnet is still pretty smooth sailing? 18:10:01 Maybe 10 different things. Happens to me sometimes in the day work, and then I don't know how to report hours done :) 18:11:47 Alright, looks like we are already through with the reports. Anything else to discuss beyond those? 18:12:30 nothing from my end 18:13:05 Doesn't look like it. So, short meeting, thanks everybody for attending nevertheless, the Monero adventure continues, and read you again next week! 18:13:19 thanks everyone 18:17:53 @rbrunner7:monero.social: My question is about this line: https://github.com/monero-project/monero/blob/24272e4a3b2e812cc2a569d95b177ecef4b91e46/src/p2p/net_node.inl#L1843 18:19:07 The bot review (https://github.com/xmrack/monero-review/issues/1088) says that filtered.insert(filtered.begin(), peer); is less efficient than filtered.push_back(peer);. The efficiency would matter more after the total size of the white_list would increase. 18:20:53 Is there an unsaid reason why you used filtered.insert() instead of filtered.push_back()? I noticed that mooo's pruning PR used filtered.push_front() in that spot, before you cleaned up that area of code. 18:21:49 mooo's commit: https://github.com/monero-project/monero/commit/b750fb27b0f20e9443827732b69a504a76036430#diff-85f0577b849d28c11a899cb863aec3df1d946e0bb214a623deef05928271fef6 18:22:46 And I don't know why push_front() was used in that spot (which is used only when we have pruning enabled) instead of push_back(). 18:24:44 Whatever it was trying to do, the order opf placing peers into the container doesn't matter with my PR since I always take a uniform random draw instead of the get_random_index_with_fixed_probability() probability mass function that drew more heavily from recently-seen peers. 18:26:02 I think I am safe to replace filtered.insert(filtered.begin(), peer); with filtered.push_back(peer); there, but I wanted to check. 18:28:20 Hmm. I don't really remember, but pretty sure I just stayed with the logic, assumed that there must be reason to insert in front without getting to the bottom of it, and did likewise. Wondering a bit however why I did not also use push_front ... 18:29:05 You explained something with a fence recently if this happens, right? 18:30:45 I think Chesteron's Fence logic encouraged you to copy the code logic as before. Now that I am changing the logic upstream, the effect of the fence is different. Or it is better to say that the fence has no effect since it's a uniform random draw. 18:31:07 Your explanation that after your changes it doesn't matter anymore anyway sounds logical, so now we will probably never know :) 18:32:09 Fun fact: épée is a term in fencing (get it, epee?) 18:32:09 Ok. Sounds good to me. Keep in mind that I am not very good at reading C++, and even worse at writing it :) 18:32:35 Just since we were talking about fences :P 18:33:11 Actually it is the fact that I am so bad at writing C++ that this PR is so simple. The simplest solution is implemented because I can only implement simple solutions :) 18:34:08 Well, if it does the job, which is sure as well as it gets after all your simulations, nothing to worry about 18:34:40 Definitely an exemplar of Grug Brained development https://grugbrain.dev/ 18:35:30 Uff, that the hell is that? :) 18:36:16 I am afraid that this dev retired recently, swept away by coding LLMs ... 18:36:45 Which pretty much trample on all those nice "leasons learned" 19:46:38 @rucknium: Omg