16:57:38 Meeting in a bit more than 1 hour 18:00:04 Meeting time. Hello! https://github.com/monero-project/meta/issues/1475 18:00:38 Hola 18:00:49 Hey 18:01:28 Hi 18:02:02 hi 18:02:15 gm 18:02:21 Alright, let us start with the reports from last week 18:03:24 mostly worked on wallet api fixes, also some smaller reviews 18:04:04 That's still somewhat in flux, i.e. not yet time for something like a final review? 18:04:28 (hi) 18:05:00 testing p2p ssl, a few things to iron out. also going to update my other prs/branches (including fcmp++ stuff) soon 18:07:40 @rbrunner7: it was, but through the amount of new PRs were getting every week, every rebase brings up another round of AI reviews 18:07:58 Oh ... 18:08:21 Sisyphus comes to mind 18:12:12 Yeah, kinda lol ... a lot of small changes came to simplewallet or wallet-rpc, when I'm done updating 9464, 10232, 10233 and 10819 accordingly, there are already so many new changes that it starts again. Though I feel the findings in general are getting more and more niche (or unrelated to my PRs and already pre-existing). 18:12:14 sorry I'm late waves 18:13:00 my update: upstream FCMP++ integration PR's are ready for review (all AI comments have been addressed), RFQ for integration audits as gone out 18:13:54 I worked on v0.18.5.4 to fix DNSSEC issue, trying to improve OpenBSD support and a couple other things 18:14:18 Me: payment scanner for fcmp++ tested on stressnet, working well 🤣 18:14:18 Will get the repo ready this week 18:15:02 @tevador: You made a PR that implements relative locks: https://github.com/seraphis-migration/monero/pull/507 18:15:05 Do I understand correctly? With this we get a full consensus implementation of a relative lock with 1 single possible duration, namely of 3 days? 18:15:20 So if people are comfortable with that, we will get relative locks with the next hardfork? 18:15:27 Yes. Can I request CI approval and review? 18:15:37 Nice. 18:16:01 The concept has been approved by MRL. 18:16:15 Hello, sorry for being late 18:16:22 Ah, ok, already a while back then? 18:16:25 The PR is only for the consensus changes, wallet code won't support it yet, but that's OK. 18:16:43 me: havent worked on the nyx changes (bucketing, eviction etc) since mrl meeting. The 101s peer drop;rotation is an issue and the change for that is "hairy". Once fixed i'll probably ask ruck to run the sim using the series 18:16:50 Yes, understood, that's quite some other kind of work of course. 18:17:05 Me: worked on fixes for the docs and GUI, updated several PRs, did a few dozen reviews, worked on the generic signing device spec 18:17:27 Quite some number of balls up in the air at the same time :) 18:18:35 What did we do back then when we did not yet have emojis? Dark times indeed. 18:18:53 :P and :) 18:18:56 🏓🎱 18:19:10 @rbrunner7: We said the quiet parts in our heads, or got in trouble for speaking them out loud 18:19:46 Ok :) Looks like that might be it as far as reports are concerned. Quite some things happening in parallel. 18:19:55 Do we have to discuss something else today? 18:20:12 Saw this question from ofrnxmr, in case jberman and/or jeffro didn't see it and may want to consider it: https://github.com/monero-project/monero/pull/11408#discussion_r4312329153 18:20:42 Sorry, I somehow didn't see that comment from ofrn. My response is that I have no idea :) 18:21:39 I remember checking and pruning seed is not called that often, I'd say merge as is 18:22:09 ya I wouldn't say that's worth fixing in FCMP code either 18:22:18 You mean it does not matter much whether it is optimized, or unaligned? 18:22:29 With 2 reads, I suppose? 18:22:32 selsta: I mean, the specific suggestion by hyc to be added to the hard fork db migration 18:22:51 yes, it's not worth to add to the migration (the extra code required) 18:22:54 IIRC, this issue was reported by selsta (from H1 or something), and I verified it and opened the fix 18:23:09 this is a relatively inconsequential section of code, not worth overloading migration code with this 18:25:28 I don't remember how those migrations work - do they work "in place" i.e. within the single blockchain file? Not needing huge amounts of free disk space? 18:26:05 (basically double the size of the blockchain file) 18:26:38 (Er, no, just about the size of the blockchain file again of course, if it's not in place) 18:28:18 the FCMP++ migration currently has 2 components: 1) read 1 table of all the outputs in the db, and construct a new table of locked outputs (so it increases db size by something like 73 bytes per output in the chain), 2) construct the FCMP++ tree tables 18:28:54 needs as much disk space as the chain is expected to take up, and not more 18:29:35 Ah, ok, the single blockchain file grows, but reasonably so. That is not too drastic then. 18:31:20 Alright, looks like we are through, and I can close the meeting. Thanks everybody for attending, read you again next week! 18:31:35 Thanks everybody, cu