-
br-m
<kiersten5821:matrix.org> @remsee99:matrix.org: if the user never redeems the synth then the lp never gets to pull funds out of the vault
-
br-m
<sgp_> Skylight Wallet is Now Available in the Official F-Droid Repository with Reproducible Builds
-
br-m
-
br-m
<cryptostephan:matrix.org> Did you need support? > <@remsee99:matrix.org> I’m working on this:
-
br-m
<remsee99:matrix.org> Well the LP has possession of the XMR. Also the LP funds are in a lending protocol that pays off debt over time
-
br-m
<syntheticbird> say the quiet part loud, I love that you pushed for reproducible build from the very beginning because otherwise some would have never tried to use it because of your professional network. > <@sgp_> Skylight Wallet is Now Available in the Official F-Droid Repository with Reproducible Builds
-
br-m
<syntheticbird> saying*
-
br-m
<remsee99:matrix.org> @cryptostephan:matrix.org: There’s nothing that comes to mind as far as specific ways I’m looking for help, but it’s an open source project and I’m open to contributors
-
br-m
<kiersten5821:matrix.org> @remsee99:matrix.org: if the user decides to LP his wrapped sytnh for 5 years, you as LP have > 50% of locked funds for 5 years because of 150% cr, this is a huge risk
-
br-m
<kiersten5821:matrix.org> putting funds into lending protocol is adding bigger risk to the system, remember aave?
-
br-m
<remsee99:matrix.org> @kiersten5821:matrix.org: Aave exists today as one of the largest and most successful lending protocols, some tokens supported by Aave have gone south but that’s unrelated
-
br-m
<remsee99:matrix.org> @kiersten5821:matrix.org: There is risk in using the system just like any protocol. Results of using the protocol are highly dependent on how it’s used and what the price of Monero does over time
-
br-m
<kiersten5821:matrix.org> @remsee99:matrix.org: did you forget just months ago there was a giant liquidity crisis on aave and withdrawals were impossible for days because of no liquidity left
-
br-m
<remsee99:matrix.org> There is a cold start problem as well, the system functions better if more people use it
-
br-m
<kiersten5821:matrix.org> you gotta mint some hyourself
-
br-m
<kiersten5821:matrix.org> and add some liquidity on uniswap
-
br-m
<kiersten5821:matrix.org> no one is using it if it says 0
-
br-m
<remsee99:matrix.org> That’s right I am still testing with small amounts
-
br-m
<kiersten5821:matrix.org> why did you launch this on gnosis no one uses that
-
br-m
<kiersten5821:matrix.org> should be on eth mainnet
-
br-m
<remsee99:matrix.org> Gas savings for early testing stage
-
br-m
<remsee99:matrix.org> Dollar native stablecoin is nice too
-
br-m
<kiersten5821:matrix.org> why is your code manually preventing reentrancy instead of using a modifier
-
br-m
<remsee99:matrix.org> Because it uses diamond pattern
-
br-m
<kiersten5821:matrix.org> why do you have a griefing deposit for mints
-
br-m
<kiersten5821:matrix.org> this doesnt seem necessary, it doesnt look like the lp loses anything on a failed mint
-
br-m
<kiersten5821:matrix.org> oh it's because of the lp bond
-
br-m
<remsee99:matrix.org> The LP if griefed would have locked some funds for hours for no reason
-
br-m
<kiersten5821:matrix.org> but why do you need lp bond if you already check the cr, why not just lock the existing collateral
-
br-m
<kiersten5821:matrix.org> you need better docs/explanation
-
br-m
<kiersten5821:matrix.org> there is not even a description of the failure modes for the burn path
-
br-m
<kiersten5821:matrix.org> i do not understand what the bond is for because it is always returned to the vault in every path? why not just lock the collateral?
-
br-m
<kiersten5821:matrix.org> mintfacet.sol
-
br-m
<kiersten5821:matrix.org>
mrelay.p2pool.observer/p/oLaQ95gLdlFQWFU1/1.txt (code snippet, 4 lines)
-
br-m
<kiersten5821:matrix.org> vaitfacet.sol[... more lines follow, see
mrelay.p2pool.observer/e/oLaQ95gLdlFQWFU1 ]
-
br-m
<kiersten5821:matrix.org> @remsee99:matrix.org: you need better docs to explain everything including the design decisions because i cant understand what the bond is for, more importantly after you get everything working is you should put in like 30 xmr yourself to begin the liquidity otherwise no one will use it if it has nothing inside
-
br-m
<remsee99:matrix.org> Yeah I’m still working on it, it’s still in alpha stage
-
br-m
<remsee99:matrix.org> More like public beta
-
br-m
<kiersten5821:matrix.org> @remsee99:matrix.org: does this path lead to the user getting fucked? user starts mint -> lp sets mintready which passes because he has enough collateral -> lp burns his own funds increasing lockedcollateral and making the next collateral check fail (lp can burn cuz pendingDebt is not checked in the burn path at all) -> user c [... too long, see
mrelay.p2pool.observer/e/3I2q95gLaFA1YWNx ]
-
br-m
<kiersten5821:matrix.org> this needs a much more thorough review imo
-
br-m
<remsee99:matrix.org> I’m not sure I understand, LP burning their own wsXMR increases locked collateral?
-
br-m
<kiersten5821:matrix.org> yes
-
br-m
-
br-m
<kiersten5821:matrix.org> because of
-
br-m
<kiersten5821:matrix.org> uint256 availableCollateral = vault.collateralShares > vault.lockedCollateral
-
br-m
<kiersten5821:matrix.org> ? vault.collateralShares - vault.lockedCollateral[... more lines follow, see
mrelay.p2pool.observer/e/grLK95gLOGFnTDZf ]
-
br-m
<kiersten5821:matrix.org> the locked collateral increases on requested burn
github.com/madschristensen99/wrapsy…/contracts/facets/BurnFacet.sol#L87
-
br-m
<remsee99:matrix.org> It’s possible, I’ll look into it further thanks for the feedback
-
br-m
<remsee99:matrix.org> @cryptostephan:matrix.org: would you be interested in writing documentation?
-
br-m
<kiersten5821:matrix.org> @remsee99:matrix.org: why do you even have locked collateral just dont reduce the debt until finalizeBurn?
-
br-m
<remsee99:matrix.org> Yeah I need to check on that, but I believe its to secure the burn handshake
-
br-m
<kiersten5821:matrix.org> secure? you are locking 110% collateral, but if you didnt reduce the debt, it would be 150%, which is more secure
-
br-m
<kiersten5821:matrix.org> locked collateral introduces more complexity which is bad
-
br-m
<kiersten5821:matrix.org> i havent even looked at how any of these will interact with liquidation
-
br-m
<kiersten5821:matrix.org> i think you really need to pay security people to review the system, cuz i bet there are 10x more like the one i just found
-
br-m
<remsee99:matrix.org> There’s probably a few more but less than ten
-
br-m
<kiersten5821:matrix.org> only one way to find out
-
br-m
<remsee99:matrix.org> There are a lot of ways to find out
-
br-m
<kiersten5821:matrix.org> i don't think there's any other way to lower bound the number of issues other than actually finding them
-
br-m
<remsee99:matrix.org> Right so there’s many ways to go about finding issues in the code
-
br-m
<kiersten5821:matrix.org> i didn't mean to sound overly dismissive, but i very strongly think you need to have paid professionals review the entire code and system, it is far from prod ready based on how easily i found problems after an hour of looking
-
br-m
<remsee99:matrix.org> Of course, as the creator of the protocol I have only ever entrusted it with $2 max. My goal is to get up to 1 XMR by the end of the year
-
br-m
<remsee99:matrix.org> Just checked, the reason was to handle XMR price difference between burn imitation and finalization time > <@kiersten5821:matrix.org> @remsee99:matrix.org: why do you even have locked collateral just dont reduce the debt until finalizeBurn?
-
br-m
<kiersten5821:matrix.org> if it were debt then it would automatically be tracking the price difference?
-
br-m
<kiersten5821:matrix.org> i don't think the price will change 30% that quickly either
-
br-m
<remsee99:matrix.org> Doesn’t really make sense I’m fixing it
-
br-m
<rottenwheel:unredacted.org> You might need a zipper for that mouth. ;) > <@pw:xmr.mx> revuo might need staff for consistent weekly updates
-
br-m
<321bob321> Hook,line and sinker
-
br-m
<dark.macau:matrix.org> @rottenwheel:unredacted.org: I am too like BDSM
-
br-m
<dark.macau:matrix.org> We can play together rotten monero girl
-
br-m
<dark.macau:matrix.org> I hope you are pretty girl
-
br-m
<dark.macau:matrix.org> I am dom
-
br-m
<dark.macau:matrix.org> You are under
-
br-m
<wvrld:matrix.org> whoa whoa what
-
br-m
<dark.macau:matrix.org> How to add emoji?
-
plowsof
where are we
-
br-m
<cryptostephan:matrix.org> way above my paygrade > <@remsee99:matrix.org> @cryptostephan:matrix.org: would you be interested in writing documentation?
-
binaryFate
GUI binaries v0.18.5.2 are now available at getmonero.org
-
nioc
GUI only as there was an issue with the recent 0.18.5.1 release
-
br-m
-
br-m
<ravfx:xmr.mx> Linux maintainers, do you job
-
br-m
<ravfx:xmr.mx> 0.18.5.1 must be purged asap
-
br-m
<ravfx:xmr.mx> Imajin the goid publicity for new users
-
br-m
<ravfx:xmr.mx> Install wallet software
-
br-m
<ravfx:xmr.mx> Cant create wallet
-
selsta
at least we have a test case for it now
-
br-m
<ravfx:xmr.mx> I am probably going to take over Gentoo GURU for monero-gui