-
atomfried[m]
is there anything i need to do with my PR or is everything ok?
-
atomfried[m]
-
netrik182
are there any rough estimations of when CLI and especially GUI are being tagged for release? I'm asking because I want to make a call-for-translators shortly after tagging so they can work on it. Plenty of languages require few strings to be fully translated
-
ErCiccione
netrik182: The call for translators need to be done before tagging. After a release is tagged nothing is going in
-
selsta
Hmm, I don't think 17.3 is large enough to require new translations
-
selsta
.merge+ 8031 8032
-
xmr-pr
Added
-
netrik182
alright, will do before. thanks erciccione
-
netrik182
my question is still somewhat relevant though
-
ErCiccione
You can decide if you want to update the strings now and then call for translators or wait until most of the changes are in and then call for translators. With the former translators have more time but can be that the language files will need to be refreshed more than once. With the latter you have translators working on mostly ready language files, but have less time and can be that there will be changes in the strings that will result in that
-
ErCiccione
string showing in english in all languages.
-
ErCiccione
my suggestion is too coordinate with the GUI people to make an estimate of how many string changes are planned. If it's not many, i would go for the second option.
-
ErCiccione
so i would put pressure on the GUI devs for having all string changes in as soon as possible and right after those are merged call for translators
-
ErCiccione
^ this is assuming we are close to a GUI release
-
ErCiccione
i also used to implore the GUI devs to not merge any string change after the language files have been refreshed and you called for translators, unless strictly necessary. That helps :)
-
selsta
atomfried[m]: please squash, then it should be ready to merge
-
selsta
these 3 PRs need a review before we can put out a release: 8023 8021 7997
-
selsta
they are all simple so hopefully someone can take a look
-
moneromooo
[...] 7997 [...] simple... :D
-
moneromooo
Or was that a typo in the PR number ?
-
selsta
these are all PRs that were already merged, so simple in that sense :P
-
selsta
but it might be a bit of work to compare them
-
selsta
were already merged, or about to be merged
-
moneromooo
The list seems to have a numbr of non bug fix commits. Intended for the release branch ?
-
selsta
afaik the only one is the --proxy command, where we decide to include as the "major" feature for v0.17.3.0
-
selsta
otherwise it should be bug fixes
-
berked[m]
I keep getting std::runtime_error's from monerod, backtracing to librandomx, and I think it even crashed my kernel twice (!?) - any ideas?
-
moneromooo
Well, I see the C++14 ones, some logging stuff, more seed nodes (those will be small though).
-
moneromooo
Get a kernel that doesn't crash when userland misbehaves :)
-
moneromooo
Anyway, be more precise. Is anything not working beyond your kernel ?
-
moneromooo
If this is just about log spam, you can start with: --log-level 0,*stack*:FATAL
-
berked[m]
Well it's a virtual server, EPYC 7something, 16 cores out of 48, everything works fine
-
berked[m]
It crashed yesterday, totally unresponsive, I reboot it.... crashed again a few hours later. Monerod log is full of those exceptions, everything else is fine. Had a three month uptime before I started running monerod - the debian testing version
-
berked[m]
I've compiled a fresh version but I wanted to get advice before switching to it
-
moneromooo
Well, my advice would be check whether it's not going into some swapstorm. I assume you don't have some panic output etc in the kernel logs ?
-
berked[m]
Nothing in the logs... the server has 64 GB ram, I don't know if swap is enabled I'll check
-
berked[m]
I was wondering if it could be some kind of betwork attack
-
moneromooo
64 ought to be just fine.
-
berked[m]
s/betwork/network/
-
moneromooo
Could be. You never know. The world is full of assholes.
-
moneromooo
It's happened before :)
-
berked[m]
Through monerod?
-
moneromooo
Well I wouldn't know. It's *possible*, but I dunno whether that's what happened.
-
moneromooo
Kernels will usually kill any memory hungry process though when they need space.
-
berked[m]
Sure but the whole thing went poof.
-
berked[m]
Are there any hardening options I can enable while compiling monerod?
-
moneromooo
No. Though you should ensure you firewall everything but 18080 (P2P port).
-
berked[m]
Ok I'll check. Maybe I should tcpdump the traffic to another machine until it crashes
-
selsta
I added the C++14 patch because I thought it would be annoying when writing something for master and then having to change it for release branch just because a different CPP version is used.
-
moneromooo
OK
-
selsta
but others might have different opinions but yes it's not a bug fix
-
moneromooo
Oh. Not really hardening, but --limit-up and --limit-down I guess. And maybe --out-peers and --in-peers.
-
moneromooo
They limit network traffic amount/time and nubmer of p2p peers, resp.
-
moneromooo
max of these.
-
vtnerd
selsta : its been audited too, right? so its most likely ready, but I will finish looking over it today
-
monerobull[m]
Test
-
bridgerton[m]
<monerobull> test
-
monerobull[m]
Test2
-
bridgerton[m]
<monerobull> discord matrix bridge works for this channel now
-
sethsimmons
monerobull: please make the bridge read-only for this channel and #monero-research-lab:matrix.org.
-
monerobull[m]
Sure
-
sethsimmons
Thanks.
-
Save_G[m]
F
-
selsta
.merge+ 8021 8037 8023
-
xmr-pr
Added
-
hyc
sech1: you around? have you run core_tests on a recent arm64 build?
-
hyc
getting a SEGV on master
paste.debian.net/1217977
-
hyc
it's a piece of RandomX code calling into unmapped memory
-
hyc
you can see that the calling address on line #22 of the paste resides in executable anonymous memory shown at line #68
-
hyc
that and line #70 are the only executable anonymous memory. everything else is from executable files/sharedlibs
-
hyc
I've added the info to PR#8031, following up mj-xmr[m]'s comment. but this crash occurs independently of this PR, prob should be its own issue.
-
isukarim[m]
-
wfaressuissia
hyc, does it fail with disabled jit for randomx ?