-
UkoeHBselsta was that numeric_limits compile bug in wipeable_string fixed?
-
UkoeHB
-
UkoeHBoh it must be ci on my branch failing...
-
xmr-prreemuru opened pull request #8177: simplewallet: remove duplicate amount attribute from export_transfers ...
-
xmr-pr
-
jeffro256[m]Hey is there a specific version of boost that yall want to stick to?
-
jeffro256[m]I found this line in the root CMakeLists file:
-
jeffro256[m]find_package(Boost 1.58 QUIET REQUIRED COMPONENTS system filesystem thread date_time chrono regex serialization program_options locale)
-
jeffro256[m]How opposed are we to upgrading Boost?
-
jeffro256[m]It's probably too much work to upgrade it, but an interesting note: if we were to raise the minimum Boost requirement to 1.60 instead of 1.58, we could annihilate epee/include/file_io_utils.h and replace each of its functions 1-to-1 with a boost::filesystem function.
-
jeffro256[m]is_file_exists -> boost::filesystem::exists, save_string_to_file -> boost::filesystem::save_string_file, load_file_to_string -> boost::filesystem::load_string_file, get_file_size -> boost::filesystem::file_size
-
h4sh3dUpdate on me: worked on the re-review 7877 last week and mostly done, covid hits me and stopped me for finishing
-
jberman[m]ah snap, feel better :)
-
moneromoooLater boosts work fine too. Replacing stuff in code just for the hell of it doesn't get my vote.
-
moneromoooFixes to make it work with recent boost are welcome.
-
selstaUkoeHB: I don't remember
-
selstaUkoeHB: try to rebase your branch
-
UkoeHBvtnerd: I pushed a cleanup commit for your review on 7877
-
jeffro256[m]Is it safe to say that I can rely on the c++11 standard for this project?
-
moneromoooDo you mean, can I use C++ features ? If so, yes. If not, rephrase.
-
moneromooos/C++/C++11/
-
UkoeHBjeffro256[m]: pretty sure the project uses c++14 now
-
jeffro256[m]okay even better! Thanks!
-
sgp_[m]1The monero.social Matrix server will have downtime as well today, starting in approximately 1-2 hours. It is being moved to a dedicated AMD EPYC server. Apologies for the short notice. It should take less than 4 hours for the transition to occur. The Monero group chats will remain accessible from other Matrix servers during the downtime, including matrix.org. Thank you.