-
spirobel[m]can someone give an intuitive explanation of what the difference between a transfer and a transaction is? I am thinking about what I need to save per wallet: is it the transfers, outputs or transactions? As I am syncing I am notified via the moneroecosystem.org/monero-javascript/MoneroWalletListener.html WalletListener about incoming outputs. From the Outputs I could retrieve the txHash. I could also query the wallet for
-
spirobel[m]transfers at this point? Ultimately I want to group outputs by transaction and give me the total amount received. I assume that is what a transfer is. I wish the listener would notify me about those. I am unsure how to go from outputs received over getting the txhash to transfers. Is this even necessary? or should I just sum up all the amounts received in a transaction and save the amount in association with the txhash? Are my
-
spirobel[m]assumptions about this right? Or is the concept of transfers something different?
-
spirobel[m]if I fire getIncomingTransfers() with a Txquery object containing the txhash of the output in the onOutputReceived function of the monero wallet listener, will the transfer object be there? can I expect it to be ready?
-
chesterfield[m]yeah
-
chesterfield[m]i actually have no idea but i'd assume it would be there
-
monerobull[m]When do we expect the next GUI release? Have someone who wants to get a ledger and not sure whether to get nano s or s plus
-
selstaI want to do a small CLI + GUI release to add Ledger Nano S+ support, but it's going to take at least 2 weeks.
-
selsta.merges
-
xmr-pr8207 8211
-
selsta.merge+ 8232 8239 8240 8241
-
xmr-prAdded
-
monerobull[m]Sounds good 👍
-
jeffro256[m]luigi1111 Could 8211 be merged on its own / at the beginning of the next batch of merges? It touches 104 files and usually needs to be rebased after every merge. mj and selsta have appoved it since the last force push
-
luigi1112sure
-
jeffro256[m]Thanks! I really appreciate it
-
moneromooojesus...
-
jeffro256[m]what?
-
moneromoooI just looked a bit. No wonder you have to rebase it all the time. KIt looks like another "rewite to my liking" patch :/
-
jeffro256[m]The vast, vast majority of the PR is just removing code. I only rewrote 99 of those lines, and a lot of that is moving a chunk of code + changing includes
-
jeffro256[m]There's two files that overlapped between my PR and MJ's big copyright update PR which is why I had to rebase
-
jeffro256[m]net_fwd.h and stafx.h in src/p2p because they were included, just not used
-
jeffro256[m]I really don't touch any critical code, I don't feel comfortable enough to do that yet
-
Dalek[m]hello?