Reminder: meeting today at 17:00 UTC

This should be ready now: monero-project/monero #8270

Hey folks, it's meeting time! The agenda is here: monero-project/meta #700

This is another meeting dedicated to the upcoming network upgrade. The logs of the last meeting are here: monero-project/meta #684#issuecomment-1100806784

but before we start, quick round of greetings to see who is here

Hi everyone!

hi

Hello

hi

hello

not crowded today. Let's wait a couple minutes more

should still be fine for a small status update

or not fine

alright, let's go on. Hopefully people will join along the way

so

The detailed plan for the network upgrade is here: monero-project/meta #630

As far as i can tell, almost all the PRs we wanted in are already merged, except for multisig: monero-project/monero #8149

There are other PRs related to multisig. An overview is here: monero-project/monero #8237

8149 needs to be squashed and then a final review, am i correct?

.merges

just so that we can see what is already in the merge queue

UkoeHB: kayabaNerve approved 8149, is there anything else to do for it?

hopefully vtnerd can take a look

since there were additions

hello

ok, so we need a last review for vtnerd and then squash and merge.

and exploit

exploit?

UkoeHB: please ignore, probably a troll

hi, sorry wasn't watching the clock

so, is multisig the only thing left? We need to have everything ready by may 16th

why may 16th?

there is also 8220, I think that is waiting for merge

I should have gitian arm macosx ready to merge before then

oh it's in queue

Branch/feature complete ok

May 16th was decided on the previus meeting

or the one before that

selsta: yep, eature/branch complete by may 16th we said

I hope to have my "nice to have" ready by then, I am in the home stretch with jberman reviewing: monero-project/monero #8076

doin my best on reviewing 8076 so we can get that in too, and hopefully 7760 but I doubt it on that one

was about to ask you, that would be a good pr to have for the hard fork rbrunner

I am hopeful :)

What about the multisig good to have UkoeHB? monero-project/monero #8237

some of those look mostly ready

8220 is in merge queue, the other ones need more work and review (won't be ready by the 16th)

the other ones aren't security-related

we can still merge things after may 16th, it's just when we try to branch

this "feature complete" date was never really strict

i thought the point was to have everything ready as soon as possible, so there was one month of testing between may 16th and release date (june 16th)

the testnet hard fork is also set for may 16th

ErCiccione: question about your suggestion for the readme and multisig fixes: are the multi sig fixes a consensus breaking change?

they are not

Well then I don’t think they should be in the network upgrade history

nope, just a major fix

i thought we listed major changes in the readme, if that's not the case, sure better not add it

Well, as far as multisig is concerned, it's something like a break, with "before" and "after" ...

Just not strictly consensu

*consensus

The list is already pretty long. But if people want non-consensus breaking upgrades listed in the network upgrade history that’s fine with me

Let's continue that conversation in the issue garth

It’s already ringsize 16, bulletproofs+, view tags, and fee adjustment

Ok cool

now, anybody with updates or questions, before we decide the date of the stagenet fork, as requested?

stagenet fork is usually 1 week before mainnet

so July 9th

Then the definitive plan is:

Branch/feature complete: May 16th, 2022... (full message at libera.ems.host/_matrix/media/r0/do…29116df660a7b9a81710152f0f139879cce)

should we set a block height for the testnet fork?

the date is getting close, seems like we should

yeah

We could leave that to the kind person doing the PR for that, calculating something for May 16

we should really come up with something today IMO, or it gets too late

who will do the PR?

that's why i wouldn't wait 😛

I'll do it

Cool. Thanks. do you already have a height in mind jberman?

15: 1982800

16: 1983520 (1 day later)

In any case, if we don't set a date today we should do it as soon as possible 🙂

oh, perfect

So, to update the plan:

Branch/feature complete: May 16th, 2022... (full message at libera.ems.host/_matrix/media/r0/do…0ce9ba32f53f5a8f455ac0a7133e7869dbe)

Any comments or something related to the network upgrade that you would like to discuss? Otherwise we can conclude the meeting

thanks ErCiccione

Alright then, thank you all for coming 🙂

meeting adjourned!

we can set another one for next week if we want? Maybe another for quick updates?

we can also decide later on, but important dates are approaching

next saturday again?

works for me

would be ok for me

.merge+ 8280 8281 8300 8301

Added

UkoeHB: monero-project/monero #8293 is this simple enough or would you prefer a second review?

selsta: it’s pretty simple, maybe could kayabaNerve take a look as well?

So long as an inversion is slower than a mul, which I'm assuming... ACK

.merge+ 8293

Added

ty

Hey y'all... According to this guy: monero-project/monero #8309, the 17.3.2 source code doesn't compile on OpenBSD 7.1. I figured out that it was b/c their OpenSSL removed API elements that the in-tree unbound depended on. For security purposes, and so that OpenBSD can compile from source from the v17 branch, can we get that patched out ?

selsta I saw that you made this commit to the master branch: monero-project/monero #7773

Will replaying that commit onto release-v0.17 work correctly ?

I intentionally didn't apply it to release-v0.17 because it might break build for some people that depend on the in tree one

e.g. the GUI had to do changes to address this, that's why I would prefer to change this in master only

jeffro256[m]: they closed the issue

Is there an official plan to stop supporting it in release builds in the future?

we will branch to release-v0.18 soon from master and that will include everything from master

Oh right because of the upcoming fork, sounds good thanks