-
arnuschk1
Hello. Today's merge day for 0.17, right? Any chance of #8149 getting in?
-
ooo123ooo1234[m]
<jeffro256[m]> "I probably won't be able to..." <- There is no such thing as "make it easier to grok". You're just doing this
en.wikipedia.org/wiki/Spaghetti_code#Ravioli_code. If you don't want to spend time on code reading then submit github issues - this is a way to contribute for people that know only English
-
ooo123ooo1234[m]
hyc, look what could be achieved if someone wouldn't do gratuitous changes:
paste.debian.net/hidden/74158896
-
sech1
Testnet has forked, but
testnet.xmrchain.net seems to be not updated
-
sech1
Or it's running some older version of master which is not compatible
-
ooo123ooo1234[m]
<jeffro256[m]> "I probably won't be able to..." <- Which one is easier to grok according to your subjective opinion:
monero-project/monero #8322 vs
paste.debian.net/hidden/74158896 ?; Which is easier to verify ?
-
ooo123ooo1234[m]
Which one is wasting less time of reader/verifier ?
-
ooo123ooo1234[m]
And are there any other reason to do this kind of useful changes in for-profit company other than salary ?
-
ooo123ooo1234[m]
"useful"
-
selsta
10:27 <sech1> Testnet has forked, but
testnet.xmrchain.net seems to be not updated <-- ping gingeropolous
-
hyc
ooo123ooo1234[m]: yes, that's the kind of patch we should be seeing
-
ooo123ooo1234[m]
sech1, "No, it won't leak. ctx is an std::unique_ptr instance which will call evp_md_ctx_freer in destructor." this comment was for another context without std::unique_ptr and it wasn't removed by github
-
ooo123ooo1234[m]
* sech1, "No, it won't leak. ctx is an std::unique\_ptr instance which will call evp\_md\_ctx\_freer in destructor." this comment was for another context without std::unique\_ptr and it wasn't marked as outdated by github
-
sech1
the comment was from only 16 hours ago and not marked outdated, so...
-
ooo123ooo1234[m]
sech1: so github ui is lying
-
ooo123ooo1234[m]
or it isn't competent enough to detect outdated comments
-
sech1
it probably outdates comments only if 1-2 lines of code above them changed
-
ooo123ooo1234[m]
sech1: priority list for constructive way of criticism: ignore it if it isn't critical < do it yourself < suggest improvement easily understandble by original author < talk with original author
-
ooo123ooo1234[m]
sorted from the easiest to hardest
-
ooo123ooo1234[m]
what is the reason to talk about under PR instead of submitting superior patch ?
-
ooo123ooo1234[m]
ooo123ooo1234[m]: not sure about naming for this order, but talking would be the last thing that I would try to do since it's the least ineficcient way to achieve the goal
-
selsta
sech1: which height is your testnet node?
-
sech1
currently at 1982829
-
selsta
ok, same
-
ooo123ooo1234[m]
<UkoeHB> "ooo123ooo1234: the purpose of..." <- If there would be competition for code that fixes everything related to multisignature. How much % of reward would you dedicated to overlay with comments ?
-
ooo123ooo1234[m]
s/dedicated/dedicate/
-
ooo123ooo1234[m]
In current environment it doesn't really matter what the code is, what the comments are since everything will be merged
-
ooo123ooo1234[m]
it's probably even possible to replace prove() verify() with static stubs {return true} and no one will complain
-
ooo123ooo1234[m]
since everyone is reading comments / docs / social media posts, but not code or math
-
ooo123ooo1234[m]
hyc, do you know how deeply linux kernel maintainer tries to verify merged commits ?
-
ooo123ooo1234[m]
or it's mostly blind merges too
-
sethforprivacy
<selsta> "sech1: which height is your..." <- Are y'all just running on master ATM?
-
selsta
yes
-
sethforprivacy
OK will get mine over onto master today unless a branch is imminent
-
sethforprivacy
Height: 1982872/1982872 (100.0%) on testnet
-
sethforprivacy
Nodes up on master at node.sethforprivacy.com:28080 and node2.sethforprivacy.com:28080, ready for fork 🙂
-
hyc
ooo123ooo1234[m]: from what I've seen, many people test proposed patches
-
hyc
for device drivers, it can be tough to find people with the device in question
-
hyc
though it often works the other way too - many people have a device and want support for it
-
sethforprivacy
Anyone who wants to run it can use my Docker image to simplify things:... (full message at
libera.ems.host/_matrix/media/r0/do…d04ffbb2e4ef80e149c2ab0cd35f0a000a9)
-
sethforprivacy
* Anyone who wants to run it can use my Docker image to simplify things:... (full message at
libera.ems.host/_matrix/media/r0/do…dd89fb2054c69bfed002a1c59d945461776)
-
sethforprivacy
-
moneromooo
I assume those three links point to the same content :P
-
sethforprivacy
Sorry, it's the weird Matrix > IRC translation for long messages.
-
moneromooo
I know, I found it amusing, is all.
-
sethforprivacy
If anyone needs any testnet funds let me know, I'm testnet rich 😄
-
sethforprivacy
Have never seen this before, trying to self-spend testnet funds: `Error: output key's originating block height shouldn't be higher than the blockchain height`
-
sethforprivacy
Nevermind, retrying worked properly. Not sure why that happened.
-
sech1
you probably connected to some v14 node that is stuck at lower height now
-
moneromooo
You probably tried to send a tx while your wallet isn't synced yet.
-
moneromooo
So a fake out was sent which is created later than what your wallet thinks the height is, and the wallet smells a rat.
-
sethforprivacy
sech1: I'm using my own synced node as trusted daemon, remotely.
-
sethforprivacy
moneromooo: Wallet was synced but possible a block came in while I was trying the transfer (lots of inputs so took a few seconds to build the TX)
-
sech1
I mean, your node connected to v14 node and got confused about blockchain height
-
moneromooo
Should not be that, since the wallet won't ask for anything within 10 blocks of the tip.
-
sethforprivacy
1982879/1982879 is correct, right?
-
sethforprivacy
sech1: Ah, that could be it.
-
sethforprivacy
Tested a large self-spend and confirmed properly (after that weirdness)
testnet.xmrchain.net/search?value=d…c93c46165e26f15f0e09d4f3e7b569dc2c8
-
sethforprivacy
Oh, nvm, failed because I'm using an old cli wallet...
-
sethforprivacy
Have to build that still
-
gingeropolous
thanks for the ping . currently getting the onion explore compiled.
-
sethforprivacy
That TX did actually go through, surprisingly. Was accidentally using v0.17.3.0 binaries
-
moneromooo
If testnet is done the same as mainnet, you have a day's worth of blocks to go through "old" txes.
-
gingeropolous
huh, the tag isn't showing up.
-
moneromooo
If pulling, try: pull --tags
-
gingeropolous
sorry. i meant on the testnet explorer on xmrchain. i wonder if theres a flag i need
-
sech1
do you mean view tag on the transaction page?
-
gingeropolous
-
sethforprivacy
gingeropolous: I created that on old binaries so it won't have a view tag
-
gingeropolous
ah
-
sethforprivacy
It's type 5
-
sethforprivacy
-
sethforprivacy
Still don't see a tag but I may be missing it
-
gingeropolous
now where are my testnet wallets....
-
sethforprivacy
-
sethforprivacy
-
sethforprivacy
Fees should be roughly analogous to mainnet post-fork, correct?
-
sethforprivacy
* Fees per kb should be
-
sech1
No, fee per kb depends on block reward and testnet has much higher block reward
-
sech1
~2.42 times higher
-
jeffro256[m]
ooo123ooo1234 That patch doesn't do the same thing as my PR though?
-
jeffro256[m]
Also I removed that wrapper class hours before you sent that message
-
sethforprivacy
<sech1> "No, fee per kb depends on..." <- OK, any easy way to estimate the fee per kb of a transaction on main-net post-fork?
-
sethforprivacy
Just trying to get an idea of the fee changes impact on common transaction fees in total XMR.
-
sech1
Do a transaction on testnet and divide the fee by 2.42
-
sethforprivacy
Oh didn't realize it was that simple 😛 Thanks
-
sethforprivacy
-
sethforprivacy
Thought fees were going up a lot more than they are!
-
UkoeHB
ooo123ooo1234[m]: I’ll gladly do it for free
-
UkoeHB
If it means someone other than me is doing the main work (like I have said before, I’d rather be working on Seraphis).
-
selsta
sethforprivacy: I think you calculated it wrong
-
sethforprivacy
I did what sech1 said
-
sethforprivacy
But seems too low
-
selsta
-
selsta
-
selsta
5x difference, that's with two random 1in 2 out tx I found
-
selsta
(but i did not check priority level)
-
sech1
fee per byte will be 20000 piconero after the fork with block reward = 0.6 XMR
-
sethforprivacy
A "regular" prio level mainnet TX is 1/5 the fee per kb of my calculated fee per kb
-
sech1
you can calculate using this number and transaction size
-
sethforprivacy
Which matches what it should AFAICT
-
sethforprivacy
sech1: Yes, mine is 20733 piconero to be precise
-
sethforprivacy
But using 20000 will certainly simplify things 🙂
-
sech1
although, transactions with more than 1 input will have weight bigger than size in bytes, and the fee is calculated from transaction weight
-
sethforprivacy
Yeah, fee per kB is slightly larger in my 2-in/2-out TX
-
sethforprivacy
20735 pico
-
ooo123ooo1234[m]
<jeffro256[m]> "ooo123ooo1234 That patch doesn't..." <- yeah, everything unneeded was removed
-
sethforprivacy
Revised numbers assuming 20000 pico as the mainnet fork will be post-tail-emission:
paste.sethforprivacy.com/?3d536c40b…rLp7WKURUvT3KCTQjThFb1G7BAYhA5YnmDx
-
ooo123ooo1234[m]
jeffro256: "2. Doesn't throw on file error, and can be used in noexcept contexts" noexcept is useless thing
en.cppreference.com/w/cpp/language/noexcept_spec#Notes
-
ooo123ooo1234[m]
"1. Logs what causes the errors at each step to help debug" or doesn't help due to additional noise
-
jeffro256[m]
It's not "useless" because it describes to the reader how to use the function. That's the whole point
-
ooo123ooo1234[m]
"3. Interface is documented" additional noise
-
ooo123ooo1234[m]
"4. Logic is moved to aptly named file" also noise
-
jeffro256[m]
And the logs would help in this particular case because the function can fail due to the openssl API or file I/O
-
selsta
now we are back again to yesterday's discussion
-
selsta
:D
-
ooo123ooo1234[m]
"5. Changes how the file is buffered" preliminary performance optimization, noise too
-
ooo123ooo1234[m]
"6. And added unit tests to test the file variant of sha256sum, as it didn't have a unit test previously" implementation is the same as previous one, so it's noise
-
jeffro256[m]
@ooo123ooo1234 I guess we have exhaused both of our points here but feel free to DM me if you want to still talk
-
ooo123ooo1234[m]
It's like those octoberfest patches but on regular basis
-
selsta
it's subjective what some find useful and others don't, obviously everyone will have their own opinion
-
ooo123ooo1234[m]
jeffro256[m]: who is the target reader that is gonig to read it ?
-
ooo123ooo1234[m]
jeffro256[m]: No. If you think that your changes are useful than I can prepare 100 such patches tomorrow
-
ooo123ooo1234[m]
and 10 other people can prepare other noisy patches
-
ooo123ooo1234[m]
is it really needed ?
-
ooo123ooo1234[m]
jeffro256[m]: any other student even less knowledgeable than you can do the same
-
ooo123ooo1234[m]
what's the purpose of this spam ?
-
ooo123ooo1234[m]
c++ training on public repo ?
-
UkoeHB
ooo123ooo1234[m]: Also, I don’t see how competition is a viable strategy for development. It sounds like wasting resources writing code that’s known in advance to be unusable (ie everyone except first place). Better to try to find the right person for the job, and then they go do it. If a re-do is necessary, at least it will only be done when actually necessary (much more efficient).
-
ooo123ooo1234[m]
UkoeHB: Any further submission should iterate of previous ones: verify whether available submissions reach the goal - if yes then work is done, if not then submit patch with further changes
-
ooo123ooo1234[m]
and reward must be split between all participants according to added value
-
ooo123ooo1234[m]
But the goal of competition should be defined before the beginning
-
UkoeHB
How is that a competition? Lol that’s more-or-less the normal review process.
-
ooo123ooo1234[m]
UkoeHB: Competition has rules, concrete goal, reward and rules can't be abused by participants
-
ooo123ooo1234[m]
I don't know how would someone define competition for the cleanest code, but It's possible to define competition for the most correct code
-
ooo123ooo1234[m]
within available time limits, reward and other constraints
-
UkoeHB
Competitions do contain rules and rewards, but the main component is some kind of parallel goal-seeking (not serial).
-
ooo123ooo1234[m]
UkoeHB: private part can be parallel, but public one must will be serial
-
UkoeHB
However, I at least comprehend why this approach would be valuable to you.
-
ooo123ooo1234[m]
UkoeHB: hahaha
-
UkoeHB
ooo123ooo1234[m]: do you have an example of a rules/rewards structure that makes sense?
-
ooo123ooo1234[m]
<UkoeHB> "ooo123ooo1234: do you have an..." <- There are few goals / important problems that are not solved now and there are few competitions that can be used a reference.
-
ooo123ooo1234[m]
The dumbest reference example known to me is to detect vulnerability and exploit it
-
ooo123ooo1234[m]
if people on the other side are competent then I will lose, if not then I will win
-
ooo123ooo1234[m]
But it isn't zero sum game for me in any case since I always approach complex problems. If I'm not competent then I learn something. If I'm then I get full reward
-
ooo123ooo1234[m]
hahaha
-
ooo123ooo1234[m]
and I don't cheat when I'm trying to solve problem
-
ooo123ooo1234[m]
<UkoeHB> "ooo123ooo1234: do you have an..." <- It starts from goal, not from rules or reward. It's better to start from something that is easy to verify: like math statement and it's prove
-
ooo123ooo1234[m]
in case of multisig it's implementation + idealized math model of it + prove within idealized model that it isn't exploitable
-
ooo123ooo1234[m]
s/prove/proof/
-
ooo123ooo1234[m]
reward structure must be dynamic since it isn't unclear how final solution will be decomposed into work of participants
-
ooo123ooo1234[m]
and rules must be strict to avoid any abuse
-
ooo123ooo1234[m]
I'm sure that even first approximation of this setup will be much better than current environment
-
ooo123ooo1234[m]
In current environment there is no incentive for proper review, goal of work can be changed during review by reviewer at will
-
ooo123ooo1234[m]
or by submitter at will
-
UkoeHB
ooo123ooo1234[m]: The reason I ask for an example is I don’t know how to write such a goal/rule/reward structure, and idk anyone who does. It’s not an area I have skill or enthusiasm in. I just want to get work done and think about new technical ideas... (pretty much ran out of those at this point for Monero - after years of thinking about the same stuff).
-
ooo123ooo1234[m]
UkoeHB: It's impossible to get work done without understanding how to check result.
-
ooo123ooo1234[m]
UkoeHB: decentralized protocol development is all about defining rules for untrusted parties that can't abused in arbitrary way
-
ooo123ooo1234[m]
> <@UkoeHB:libera.chat> ooo123ooo1234: The reason I ask for an example is I don’t know how to write such a goal/rule/reward structure, and idk anyone who does. It’s not an area I have skill or enthusiasm in. I just want to get work done and think about new technical ideas... (pretty much ran out of those at this point for Monero - after years of thinking about the same stuff).
-
ooo123ooo1234[m]
* decentralized protocol development is all about defining rules for untrusted parties that are hard to abuse in arbitrary way
-
ooo123ooo1234[m]
It's also the main reason why people from regular jobs can't bring any value to monero development since they are used to centralized architecture where every failure is easy to fix and there would be no penalty
-
ooo123ooo1234[m]
But centralized architecture is the path of least resistance forced by status quo and it's completely incompatible with monero goals
-
ooo123ooo1234[m]
status quo = govt / ...
-
UkoeHB
ooo123ooo1234[m]: I agree with you, however attaining that goal isn't necessarily straightforward. New perspectives and 'what ifs' can crop up regardless of what formal model has been designed (which mean updating the formal model). For example, the idea of a post-kex verification round for multisig that I recently had is, as far as I know, addressing a new problem that no one considered before. Similarly with kayabaNerve 's
-
UkoeHB
point about the danger of burning funds in multisig. That isn't to say formal models aren't useful or important, just that there is a dimension to protocol analysis that can't be formalized (the realm of 'imagination' I guess, which precedes and informs formalization). Another way of saying it is - formal models encapsulate all the problems that have already been imagined (the process of formalization can also identify new
-
UkoeHB
problems). This implies two issues. 1) knowing the existing best formal model isn't required to imagine new problems (anyone can do protocol analysis and potentially contribute something). 2) learning the existing best formal model requires collecting ideas that may be hidden or difficult to locate (finding any single person who knows the entire existing best formal model is non-trivial, especially for new/complex systems;
-
UkoeHB
hence, collecting a venn-diagram of analysts can be useful or even essential).
-
ooo123ooo1234[m]
UkoeHB: No. The thing found by kaybaNerve is detectable within idealized model too.
-
ooo123ooo1234[m]
<UkoeHB> "problems). This implies two..." <- There are very few approaches for modelling. Most of the work is to describe concrete protocol within it and then analyse it.
-
ooo123ooo1234[m]
I don't like academic papers written by many people with a lot of noise, when the key points are very minimal
-
UkoeHB
Can't disagree with that
-
UkoeHB
^ noise
-
ooo123ooo1234[m]
So people intentionally chose the path to be incorporated into academic hierarchy and then write nonsense, since it's just status quo
-
ooo123ooo1234[m]
For the purpose of monero development there is no need to waste time on that front door polishing or simulation of hard work for a grant
-
UkoeHB
ooo123ooo1234[m]: > Most of the work is to describe concrete protocol within it and then analyse it.
-
UkoeHB
Yes, it is a lot of work that requires a lot of expertise. Unfortunately, people who are able and interesting in doing that work are few and far between (and won't materialize out of thin air). I have done the best I can, and use my energy to be as productive as possible within my skillset, but there's no question what I have done/do is sufficient for a final answer on anything.
-
UkoeHB
able and interested*
-
ooo123ooo1234[m]
UkoeHB: hehe, somehow it was possible to achieve
-
rbrunner
The testnet part of my web wallet is running already on v15, maybe it's useful for somebody for tests:
monerotech.info/Wallet
-
rbrunner
-
sech1
just did a sweep_all on one of my p2pool test wallets:
testnet.xmrchain.net/block/1983000
-
rbrunner
Although that one does not show view tags, which I find a little strange. I thought I was compiling the latest source yesterday
-
ooo123ooo1234[m]
<UkoeHB> "Yes, it is a lot of work that..." <- "are few and far" and who are these people ?
-
ooo123ooo1234[m]
if there is at least two such candidates then it's possible to do competition between them
-
ooo123ooo1234[m]
s/is/are/
-
ooo123ooo1234[m]
s/is/are/, s/at/atleast/, s/least//
-
ooo123ooo1234[m]
<UkoeHB> "Yes, it is a lot of work that..." <- "
en.wikipedia.org/wiki/Influence_peddling" current environment creates incentive for this and it's obviously doesn't lead to more people interested to compete in solving hard problems
-
ooo123ooo1234[m]
quite the opposite: easiest problem are the most profitable
-
ooo123ooo1234[m]
hahahahaha
-
ooo123ooo1234[m]
s/problem/problems/
-
ooo123ooo1234[m]
s/Influence_peddling/Influence\_peddling/, s/'s//
-
ooo123ooo1234[m]
game design is broken a bit
-
ooo123ooo1234[m]
it deends: if this project is for status quo then everything is ok, if this project is going to change something then not ok
-
ooo123ooo1234[m]
s/deends/depends/
-
UkoeHB
ooo123ooo1234[m]: at the moment, in this project, among those who are vocal, it might be just you (there may be some guys with a less advanced level of skill). AFAIK the guys at Firo and possible ZCash also have at least one person with that capability (or at least inclination). However, you are VERY unlikely to find someone who has the qualifications you want and is also interested in a competition. The probability seems
-
UkoeHB
infinitesimal.
-
ooo123ooo1234[m]
UkoeHB: This competition is compatible with anonymity of participants, so that means anyone who can find something can participate
-
ooo123ooo1234[m]
if there is some critical thing which cracks everything then this is a chance to get full reward
-
ooo123ooo1234[m]
very strong incentive to participate for anyone competent
-
ooo123ooo1234[m]
and incompetent people after few iterations can learn how to do it and participate too
-
ooo123ooo1234[m]
all submissions must be public
-
ooo123ooo1234[m]
I doubt that no one will try to compete with me for proper reward
-
ooo123ooo1234[m]
People participates in programming contests just for the respect
-
UkoeHB
The first step would be finding someone else who is enthusiastic about a competition. To set up a competition, you need enthusiasts. I am not that person - all the stuff I do is voluntary and public and self-motivated.
-
sethforprivacy
-
luigi1111w
.merges
-
xmr-pr
8046 8266 8307 8308 8312 8315
-
ooo123ooo1234[m]
<UkoeHB> "The first step would be finding..." <- That's about obstacle to setup competition, but do you mean that you're not interested to participate even if the problem to solve is directly related to what you're doing right now ?
-
UkoeHB
ooo123ooo1234[m]: what new thing would I be doing in this competition? If there is something I can do right now, then I'll do it (unless the task is becoming an expert at security proofs/modeling - I have tried to get into that stuff and could not muster enough enthusiasm).
-
UkoeHB
Or if there is something more for me to do, I'll put it on my todo list.
-
ooo123ooo1234[m]
UkoeHB: In the worst case learning something new from reading submissions. In the best do something like this:
github.com/UkoeHB/break-dual-target-dl or anything else
-
UkoeHB
Sure, both of those things I'm happy to help with. Just let me know where and how I can help.
-
ooo123ooo1234[m]
As you said it's close to review process, but with better focus and incentive for participants
-
ooo123ooo1234[m]
The question is whether it's possible to incorporate it into current game design, otherwise it would like creating mining pool for few MH/s of hashrate, when others are mining at minexmr
-
ooo123ooo1234[m]
* it would be like creating
-
ooo123ooo1234[m]
It's certainly possible to add into new project, but it means that current one should die
-
ooo123ooo1234[m]
* to add it into new
-
ooo123ooo1234[m]
p2pool can't compete with minexmr even with full support / money burning from xmrvsbeast owner
-
ooo123ooo1234[m]
In general the way to fix or destroy something is the same, both need required good knowledge about weaknesses.
-
ooo123ooo1234[m]
* In general the way to fix or destroy something is the same, both just need extreme knowledge about weaknesses.
-
UkoeHB
From what I can tell, any kind of centralization in the core concept of a project will make it hard to succeed. These include tech-centric projects ('our tech is the best, use us'), company-centric and team-centric projects (monero is in the odd position of having a very custodial core team). Starting a new project to tweak something about a previous project doesn't work (often, new projects just create new centralizations). You
-
UkoeHB
need a new fundamental concept that people can get attached to. Tech, management, roles, strategies, and 'memes' are only reflections and embodiments of the project's core concepts (the tech/etc. is what we do, because that's who we are). From this human perspective (which may be annoying, but is critical), what can you do? Encourage people to be better people, to have better ideas, to do things in more effective ways. Hard to
-
UkoeHB
do, but there aren't a lot of real alternatives.
-
UkoeHB
It just so happens that monero is rather haphazard (due to lack of centrally mandated direction), so what we need to improve is less haphazard protocol and code work (or at least tighten merge requirements).
-
UkoeHB
A lot of this is off-topic though, better suited for #monero-research-lounge or something.
-
ooo123ooo1234[m]
UkoeHB: it's about relax, so lounge isn't suitable
-
ooo123ooo1234[m]
hahaha
-
ooo123ooo1234[m]
* it's not about relax,
-
Guest47
Need help opening up