> monero-project/monero #8360 can someone check if this makes sense? should if there is an rpc error, should there also be an error with the HTTP status code instead of 200?

I agree with that stack exchange answer. HTTP 200 should be used if the API was accessed and the backend returns a response (whether the user likes it or not) which runs as intended without any kind of backend errors or transport errors or access errors, etc

It it's only an error on the application layer, code should be 200. That's pretty typically I think

The error message "failed to open wallet" sucks ass though

I suppose this is the difference between RPC and REST - it is after wall the wallet rpc - which typically does not use HTTP error code semantics, so I would say that it's best to leave as-is

i derived private view key from private spend key

it is correct butt

my derivation: 85F0891ADF3AACE53525D3227B33417CA74787BDD8C3151DA6AC7B6831E7E5

xmr.llcoins.net/addresstests.html's derivation: 85f0891adf3aace53525d3227b33417ca74787bdd8c3151da6ac7b6831e7e500

what is that "00" at the end???

ohhh

waittt

it is

85F0891ADF3AACE53525D3227B33417CA74787BDD8C3151DA6AC7B6831E7E5000000000000000000000000000000000000000000000000000000000000000000

this is derived from 64 bit reducer

half of that is 85F0891ADF3AACE53525D3227B33417CA74787BDD8C3151DA6AC7B6831E7E500

it is ok

or maybe i can remove half things of 64 byte reducer

64 byte reducer is mostly artifact from eddsa reference afaik

is this reducer thing doing something like moving the point onto curve function?

i think scalar value for reducer is x or y of the point

reducer only acts on private keys which is just a simple integer

i have to make words portable somehow

i have words for ETH and BTC

it will be for Monero too

#7760 needs serious and thorough review, the code quality is low from my point of view

see my comments there

I haven't looked at 7999 yet, but I'll probably find similar problems

sech1: is the rng seed issue already in existing code? not jusr 7760?

hmm, actually yes :D

yes like i thought

either way, the "perfect" daemon should've fixed this too

I'll make a PR to fix this in the meantime

because this is unacceptable

selsta monero-project/monero #8365

ty

I just noticed the wallet caches get bigger with age. for example, an old, lightly used wallet >40 mbs. anyone know why?

It stores block hashes. Though, IIRC, it prunes...

Probably to double check reorgs. I forget exactly why.

Hmm. It's used to build the shortchain when refreshing. Odd. I thought I added that, but this implies it was here from the beginning.

Ah, right. I added it indeed. To trim the block hashes to avoid that constant size increase. So maybe it broke.

Though it uses the last known hard checkpoint to know where to trim so maybe it'll slim back down once you update to a new version.

it should only be ~70mb for all block hashes in the chain

woodser[m] are you using 4yr old wallet software?

this is with the latest v0.17.3.2 gui. I'm loading the wallets in the gui to see if the size reduces

the size stays at >40 mbs after loading in the gui

> Though it uses the last known hard checkpoint to know where to trim so maybe it'll slim back down once you update to a new version.

the new version is the next checkpoint, or hard fork? the wallet software is the latest version

IIRC it's the last hard checkpoint.

It is. See trim_hashchain in wallet2.cpp.

issue about cache size

sounds like normal operation, the cache has to keep track of the last N block hashes it has seen

to know where to pick up from on the next sync with a daemon, and to detect reorgs

Hello there. I've been working as a C++ software engineer on embedded Linux for a couple years now and I'm interested in contributing to Monero. I've looked through some of the Issues on GitHub but it's a bit overwhelming getting into a new project like this. How do you all recommend that I get started?... (full message at libera.ems.host/_matrix/media/r0/do…fdf7d172d6cae5c3765788ffb37a75f787a)

philip_foss[m]: hi philip, nice to have you. The general advice is usually 'find something you want to improve and then do it'. Is there a bug you hate? Fix it. Is there a feature you want? Implement it. Not sure? Find someone else's bug or feature that gets you energized.

Ok, I will see what I can find.

I have a simple enough bug open in the RPC code, which should let you look through that code and learn how to check if a TX is a miner TX or not. monero-project/monero #8311 Posting it to be self-serving, though it does seem like "good first issue" type of content

But koe's statement on finding something that makes you excited is best. Don't work on a project you don't want to work on ;) Work on something you do :)