FYI, I created a room for non-core related dev discussions. Newbs welcome: #monero-community-dev:monero.social

i have a very important question

how do you build Monero?

i built it with MSYS2/Mingw64

Refer the steps in the README.

nooooo i mean

how do you build it for different targets

do you do cross-compiling

or do you build it on target platforms individually

Refer the steps in contrib/gitian/README.md

loooooking

i wanna ask:

is it possible to cross-compile Monero?

and did you ever do that?

Refer the steps in contrib/gitian/README.md first.

to the steps

you mean it is pretty possible?

This is what the file above is about. That's what I said refer to it.

niceeeeeee

which static object can/should i use from Monero build?

<moneromooo> "Refer the steps in contrib/..." <- ^

i already built for Windows

i need to use Monero functions

<moneromooo> "Refer the steps in contrib/..." <- ^

MeowingCat: Such as

i should statically link the required objects to my GDNative library

or if it is possible to get some dynamic libraries

i can use that too

ofrnxmr[m]: Did you ^

<moneromooo> "Refer the steps in contrib/..." <- Did you ^ **

:((((((((( i willlll look but i already have Windows build

i have libwallet.a, libwallet_merged.a, libmonero-wallet-rpc.dll.a

what are libwallt.a and libwallet_merged.a??

<moneromooo> "Refer the steps in contrib/..." <- So thats a no? Come back after you ^ please

are you joking????????????

i tried to link libwalet.a before

butttt headers and non-relative include paths are crazy

and must be tons of compiler parameters that are requried to compile Monero successfully

normally i had to be able to statically link libwallet.a and include Monero headers

and use it easily

Of course not.

What is your goal? What are you trying to do? Cross compile ? Thats all?

If you havent read the documentation youve been pointed to.. no, im nit joking

i will cross-compile tooo because i need Windows, Android, iOS builds

but first i will use Monero functions i already built Monero for Windows

Monerod builds/works for ios?

the only thing that i need libwallet.a and headers i have libwallet.a and i have headers tooo

but headers are crazy

"monerod" sounds like a daemon

i don't need a daemon

i just need to build and sign transactions

you all said it is impossibly difficult

and the only way is using Monero's itself

i don't even need address derivation functions from Monero

i made it in C#

do you have dynamic libraries that contain transaction building/signing functionalities for Windows, Android, iOS

moneromooo: looks like I fixed their keyboard

i mean built dynamic libraries

if someone has that please send me :((

Ive never attempted to build for ios. I use gitian for androin, Linux, mac etc

okii but now i need to link libwallet.a to my thing

what is the difference between libwallet.a and libwallet_merged.a???

does "merged" mean something like portable version????

and includes everything required?

"merged" means all the libs at once, the wallet and it dependencies.

wallet2 is what has the tx building/signing code.

If you can call that from C#.

moneromooo, do i need libwallet.a or libwallet_merged.a for only transaction building and signing?

alo

anyone to help me with monero OTC? :)

<chirp042> "anyone to help me with monero..." <- #monero:monero.social

Either would do.

Mooooooooooooneroooo

#monero:monero.social is quiet af too

lmaooo

<chirp042> "#monero:monero.social is quiet..." <- People too busy reverse engineering wallet2.cpp spaghetti code no time for chatting.

based

Stnby[m], wallet2.cppppp

the besttttttttt

we need a wallet3.cpp

<MeowingCat> "the besttttttttt" <- Just beautiful

damnnnn i should ask this

Stnby[m], are you using Discord???

Hell no

No Pedochat

is this place bridged to Discord?

I have no idea, if it was why would you use Monero

If thats how much you value your privacy

i don't use Moneroooooo

just adding Monero support to our wallet apppp

Also this is dev we should talk this elsewhere

why i can't write here on Discord?

* this elsewhere #monero

<CrimsonKing> Just a quick test, can you guys read this ?

Yes.

<CrimsonKing> thanks, moo.

im trying to use Monero::WalletManager

im including wallet2_api.h and linking libwallet_merged.a

buttt linker is saying undefined reference to `Monero::WalletManagerFactory::getWalletManager()'

isn't this thing placed in libwallet_merged.a???

g++ -o monero_api.exe libwallet_merged.a monero_api.cpp

im doing thiss

Place libwallet_merged.a after monero_api.cpp.

ohh tried already

damnnnn it works i tried it with Linux build and i figured out that im trying to link wrong build

it is linking

moneromooo, tyyyyyy

linking is taking huuuuuuuuuuuge time

is there a solution for that???

A faster CPU.

BTW, what you are using here (Monero::WalletManagerFactory::getWalletManager) is part of an API layer above wallet2. Using it is fine, but it's a bit of a useless layer.

It's here for historical reasons, and likely won't go since other people use it now, but just so you know. You have a choice between this and wallet2 itself.

you mean there is another interface for same purpose?

Actually, maybe not useless, I think it might have some async stuff, which could be useful...

my CPU is i7 10750h

i can't do anything to make linking faster?

Well, check top to see what's the bottleneck, but I doubt it'll be I/O here.

ummmm my SSD is very fast :(

maybe about MSYS2?

still linking

You mean... the same linking process ? For 40 minutes ?

yesssss

WTF. OK, something *is* wrong.

just libwallet_merged.a

:((((((((

Check top, is ld taking 100% CPU ?

C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/12.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libwallet_merged.a(wallet2.cpp.obj):wallet2.cpp:(.text$_ZN5boost13serialization9singletonINS_7archive6detail11iserializerINS2_24portable_binary_iarchiveESt13unordered_mapINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESC_St4hashISC_ESt8equal_toISC_ESaISt4pairIKSC_SC_EEEEEE18get_const_instanceEv[_ZN5boost13serialization9singletonINS_7archive6

detail11iserializerINS2_24portable_binary_iarchiveESt13unordered_mapINSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESC_St4hashISC_ESt8equal_toISC_ESaISt4pairIKSC_SC_EEEEEE18get_const_instanceEv]+0xc0): undefined reference to `boost::serialization::typeid_system::extended_type_info_typeid_0::extended_type_info_typeid_0(char const*)'

i used --verbose and i see these

Ah, use g++, not gcc, to compile/link.

ld.exe using %16 CPU

Does top have a large value in the wa% column, near the top of the screen ?

i used g++ already :((

Ah you did, sorry. Misremembered.

You need to link agianst all the boost libs then. I guess they're not merged in libwallet_merged.a...

See the list in one of the CMakeLists.txt files.

i built monero repo

program_optoins, thread, chrono, etc. All the lot of them. In the same order.

and got libwallet_merged.a

what should i look for in CMakeLists.txt??

you mean ld is linking boost things because they are not in libwallet_merged.a?

program_optoins, thread, chrono, etc. All the lot of them. In the same order.

okii loooking

You could do a lot worse than running the monero-wallet-rpc link with VERBOSE=1, then copying as much as possible which libs are in.

i feel like it may be because of tooo much different files

SSDs are working slow for too much files

find_package(Boost 1.58 QUIET REQUIRED COMPONENTS system filesystem thread date_time chrono regex serialization program_options locale)

this line in CMakeLists.txt

ohhh linker is saying "undefined reference to ..."s

where are damn boost static libraries

i should find them

there is something wrong

x86_64-w64-mingw32/bin/ld.exe: ../../monero/build/MINGW64_NT-10.0-22000/_dal_yok_/release/lib/libwallet_merged.a(wallet_manager.cpp.obj):wallet_manager:(.text+0x12691): undefined reference to `el::base::Storage::getELPP()',

errors like this

is libwallet_merged.a supposed to contain everything??

MeowingCat: no

libwallet_api.a does contain everything

i built Monero

that's why we switched to _api for the gui as it makes things easier

and im passing libwallet_merged.a to link to GCC

what should i pass else?

to link

ld can't find tons of things

i just found there is a wallet2_api.h and it is independent

selsta, tyyy loooking

what is "wallet_api"??

what does that mean in CMakeLists.txt?

:((((((

oh these static libraries i should link?

where are these static objects?

does a libwallet_api file exist?

loooking at find . -regex ".+\.a"

noooo there is no anything like "libwallet_api"

remove line 85 and 86

but i'm just guessing here, if you use CMake you could just copy the CMake code from the GUI

i made g++ -o monero_api.exe monero_api.cpp ../../monero/build/MINGW64_NT-10.0-22000/_dal_yok_/release/lib/libwallet_merged.a $(find ../../monero -regex ".+\.a" -printf "%p ") --verbose

but still saying "undefined reference to"s

loookingg

set_property(TARGET wallet_api PROPERTY EXCLUDE_FROM_ALL TRUE)

oh this thing is removing that thing????

whyyyyyyy

encapsulation concept should not exist in universe

:((((

Because it's rebuilt every time wallet2.h changes, very slowly, and it's unused by monero itself, just by the GUI and so you have no idea if any changes there work or not anyway.

It really doesn't belong in this repo.

So I took if out by default, it was wasting my time so much.

im crying

gonna rebuild now

without that lines

I think libwallet_merged.a does include it fwiw.

oh noooooooooooo

then it doesn't mean anything

buttt why there are undefined reference errors :(((((

this thing made me crazy really

hi

it seems google have merged libgtest-dev into google test?

ok found it

i have libwallet_api.a nowwwww

MeowingCat: did removing 85 86 work?

yesss

buttt still undefined reference errors when i link libwallet_api.a

what undefined references?

ld.exe: ../../monero/build/MINGW64_NT-10.0-22000/_dal_yok_/release/lib/libwallet_api.a(wallet_manager.cpp.obj):wallet_manager:(.text+0x12769): undefined reference to `el::base::Writer::construct(char const*)'

like this

That's easylogging++. Use git grep.

you have to link against easylogging

yes

there are too many errors for different things

ld.exe: ../../monero/build/MINGW64_NT-10.0-22000/_dal_yok_/release/lib/libwallet_api.a(wallet_manager.cpp.obj):wallet_manager:(.text+0x17fcc): undefined reference to `__stack_chk_fail

im linking all *.a in monero/

g++ -o monero_api.exe monero_api.cpp ../../monero/build/MINGW64_NT-10.0-22000/_dal_yok_/release/lib/libwallet_api.a $(find ../../monero -regex ".+\.a" -printf "%p ") --verbose

i think i need a GCC command that is created by CMake for Monero

to link everything

That's why it would be easier to use CMake. You can do the same as monero-gui repo and everything should work.

ld is a single pass linker, you want the order right.

then im gonna use CMake

__stack_chk_fail suggests you compiled some of the source with different code gen options than others. Not 100% sure.

I'm sure you've been looking up those symbols in a search engine anyway.

there is a mistake in official monero cli tutorial

sudo should never be used when compling libraries Xd

[1] On Debian/Ubuntu libgtest-dev only includes sources and headers. You must build the library binary manually. This can be done with the following command sudo apt-get install libgtest-dev && cd /usr/src/gtest && sudo cmake . && sudo make then:

wrong

Violent. Please PR a patch.

I found it. I can do it if you like, or you can have a patch in monero :)

moneromooo, just did "make release-static-win64" for Monero source

dudes who here complied google test lib from scratch?

I did it got libs, however do I need stuff in /include?

jeffro256: can you stop writing those subjective comments and focus on checking whether problems from tests are solved and no others introduced ?

* no others were introduced ?

this is sufficient requirement to merge patch ^

add_subdirectory(../monero)

is this enough?

for my CMakeLists.txt??

MeowingCat: easier to test than to ask

jeffro256 for once I agree with ooo123, deprecated methods are not relevant for this PR review. As selsta commented there somewhere, boost 1.59 is still supported in Monero code, so we can use these methods.

"monero-project/monero #7760#discussion_r889421565", "potentially infinite while loop" potentially shallow comment

sech1, hello

jeffro256: also my next approximation was supposed to touch connection + boost server + node_server + cryptonote_protocol, but I stopped since no one even able to check small connection patch

ooo123ooo1234567 I will do a proper review (correctness of code logic) soon, right now I'm fighting with adding curl to p2pool, so I don't have time for review

<sech1> "ooo123ooo1234567 I will do a..." <- why do you need curl in p2pool ?

It's basically working on Windows and Ubuntu already, I just need to figure out how to link libcurl statically for all the various p2pool builds (not an easy task)

Ugh. This stuff in the README is building stuff in /usr/src :S

That's why it needs sudo. It'd need to create a build dir somewhere in /tmp or so, and build there.

I'm not even sure why that'd work, unless building also installs stuff, or something includes from /usr/src. This is very icky/

<sech1> "It's basically working on..." <- "everything.curl.dev/build/autotools#static-linking", "... you need to prepare yourself for an uphill battle." indeed, not an easy task

that's why it doesn't make sense to support pseudo static build in cmake since it doesn't make sense without knowledge of particular environment which will be used for compilation

I don't need ssl and many other features of curl, so I can just turn them off when compiling libcurl.a

Already built fully static binary on Alpine Linux

* that's why it doesn't make sense to support pseudo static build in cmake since fully static build requires knowledge of particular environment which will be used for compilation; and without such knowledge it isn't complete

and "static" binary on Windows (dependent only on system DLLs)

and "kind of static" on Ubuntu (libcurl, libuv, libzmq linked statically, only system .so dependencies)

mingw64 is pita though

can't build there at all so far

sech1: In theory, someone could wrap such fully static builds in docker to make life easier for others

sech1: you have to learn all dependencies of this lib in each environment in order to include all of them statically; pure pain without any benefits except env knowledge

libcurl has ./configure script which can turn off everything

only basic http requests will be left which is what I actually need

so I can build libcurl.a which doesn't need other dependencies

I hope http digest authetication will not require some obscure dependency :D

sech1: so you're training in finding all dependencies before proper PR review, kind of warm up

<sech1> "I hope http digest authetication..." <- the same task in cryptography would be: checking that all security dependencies are covered with some known hard problems

in all cases you're learning graph of dependencies and then checking something, but cryptography is at least useful work

though some auditors are doing shallow checks even in cryptography, while others are doing deep check in build dependencies; facepalm

hmm, auditors are limiting scope of work since it directly affects amount work, isn't it a proof that shallow comments have 0 value ?

sech1: should the rng patch be closed?

jeffro256: "monero-project/monero #7760/files#r889445157", deep pain introduced by boost developers with the best readability and code style

selsta I'm more in favor of removing the rng completely from there, so yeah it's better to close it

sech1, did you see this github.com/ithewei/libhv, another async i/o lib ?

No

Switching away from libuv means rewriting everything, not an option. Plus libuv is much more widely used and battle tested

that's solo project

sech1: yes, async i/o is everywhere the same, no matter what lib you're using

details are different, apis have different names, parameters etc. Every libuv call needs to be translated

sech1: pain with curl dependencies vs pain of deep reintegration, 1st one less hurts probably

sech1: In theory, It could be possible just to borrow http protocol part, but probably not this case, due to big difference

s/,//

libhv even doesn't have what I need (http authentication)

<sech1> "details are different, apis have..." <- Did you try to write the same network app with different frameworks ?