-
theresreallyawol
Hi everyone, starting my CS degree this month. About to dive into c++, can anyone point me in the right direction in regards to what math skills I will need to accomplish in order to effectively contribute to the project?
-
UkoeHB
theresreallyawol: browse zero to Monero 2
-
UkoeHB
If you are interested in crypto
-
theresreallyawol
<UkoeHB> "theresreallyawolf: browse zero..." <- Awesome, thank you
-
Guest9045
I want to know how monero handle xmr in float like 1.5 in wallet api by default it is using double but proverangeSimpleRct() uses uint64_t why this
-
Guest9027
I mean it should use double and it is using it till wallet api but in rangeproof() where range and commitment are produced why it is using uint64_t
-
Guest9027
And wht type is xmr_amount
-
rbrunner
If you don't use yet any tool that lets you look up the definition of `xmr_amount` with basically one keypress or one click you are not yet equipped well, and IMHO you should go search such a tool for you
-
Guest9053
I used git grep "xmr_amount" i only got it used as type for other but not got how it got it's defination
-
sech1
Using floating point for money amounts is a cardinal sin in any software
-
Guest9053
sech1: ya floats are way more complicated to be used and operated with but what about the amount that are not perfect integers, until wallet api it is used but when it reaches proverange() it is getting uint64_t than wht is done with that
-
sech1
All XMR amounts are perfect integers
-
Guest9053
Than wht about the amount that are not in integers but rational like 0.5 monero
-
rbrunner
I think you will see that everywhere where it matters it's always 'xmr_amount', and only for UI purposes, to display to users, floats or doubles are used.
-
sech1
0.092945340688 XMR = 92945340688 in actual code
-
sech1
as an example
-
Guest9013
Tell me the code
-
sech1
-
rbrunner
By the way, git grep "xmr_amount" is not one of the possible tools that I was talking about ...
-
rbrunner
You are probably trying to cut down a big tree with something like a kitchen knife. Won't work.
-
Guest9013
sech1: oh gosh I know that repo, i told to tell me exact function or file doing but no way i will see it
-
sech1
find it yourself, I'm not going to spoonfeed you
-
Guest9013
But git grep gives best answer it will give everywhere where that xmr_amount is used and i can see it whts happening with it
-
rbrunner
What will you do with 1,000 places where that is used?
-
rbrunner
If you want the definition
-
rbrunner
What is so terrible with searching for a good tool and install it?
-
Guest9013
Atleast it will give something and i could search in those 1000 places.
-
Guest9013
So which tool should i use
-
rbrunner
I can recommend something from the "dark side", VSCode
-
Guest73
So in one word monero is not using double instead using uint64 for amount.
-
rbrunner
Yes, in every place where it really matters. Of course you don't show something like 92945340688 to a user in a wallet though, for 0.092945340688 XMR
-
Guest73
Thanks a lot you both
-
Guest73
So for just showing user it is in float otherwise for the calculations it is uint64
-
rbrunner
As far as I know, yes.
-
corom[m]
Hello,
-
corom[m]
Do you thinks a decentralization of moneroPulse is possible? Cause it's centralized a lot the monero network.
-
jozsef[m]
vscode is nice, but for (grumpy) oldtimers, grep does the job just as good:... (full message at
libera.ems.host/_matrix/media/r0/do…dbbe536fb1e8dcf34be653d42cc06288697)
-
ofrnxmr[m]
> <@corom:matrix.org> Hello,
-
ofrnxmr[m]
> Do you thinks a decentralization of moneroPulse is possible? Cause it's centralized a lot the monero network.
-
ofrnxmr[m]
Its optional
-
moneromooo
There are no floats. What you see as 0.749032 is in fact 749032000000.
-
moneromooo
A decimal point is added to make the amounts easier to read for humans.
-
moneromooo
It's the same as $0.06 is 6 cents. You just count in smaller units.
-
moneromooo
But you'll diusplay 6 cents as 0.06 for humans.
-
moneromooo
xmr_amount is barely used, it should really be removed. Amounts are mostly uint64_t.
-
moneromooo
A few are boost bigint where needed, which is seldom.
-
Guest58100
Why function donate() and mms() in simplewallet.cpp are not called by any other functions but they are actually main function in wallet.
-
rbrunner
" xmr_amount is barely used": Right now looking at brand-new Seraphis code which is full of this :)
-
selsta
maybe just a similarly named variable?
-
selsta
typedef uint64_t xmr_amount;
-
rbrunner
We were indeed talking about the type, pretty sure
-
rbrunner
Exactly that typedef
-
selsta
I thought you were talking about some double var, but I didn't fully follow.
-
Guest50
Why h2d() is multiplying recieved amount with 256 in every iteration
-
moneromooo
Because it's reading 8 bit chunks.
-
corom[m]
<ofrnxmr[m]> "> <@corom:matrix.org> Hello,..." <- Yes it's optional but a majority of nodes follow it. So I thinks decentralized it must be done.
-
ofrnxmr[m]
Its manual.
-
ofrnxmr[m]
You have to add `enforce-dns-checkpoints`
-
ofrnxmr[m]
If majority of nodes do this.. that's their prerogative.
-
corom[m]
Okay thanks
-
Guest34
I wanted to run a private network of monero on my system to check it functioning as i couldn't know whts going on in online deamon so i ran two deamon in background with offline option and a restored wallet as given in monero testing document but now I am confused how to see mining and wallet creating and recieving stuff
-
hyc
you don't run them in offline mode. you run them with --add-exclusive-node pointing at each other
-
hyc
offline mode is useless for testing receiving & mining
-
moneromooo
You can check what parameters tests/functional_tests/functional_tests.py is using, it sets up a netowrk of a few daemons and wallets.
-
Guest34
And wht about transaction i could create and recive in those fake wallets
-
Guest34
And wht about starting mining
-
Guest34
As i have set up both deamon and wallet so
-
selsta
woodser[m]: do you have time to test this today or tomorrow?
monero-project/monero #8484#issuecomment-1207431654
-
selsta
would like to include these fixed in v0.18.1.0 and the HF is approaching
-
woodser[m]
sure I can test it now
-
moneromooo
This seems to be if you do things wrong though, so pretty much noone will hit this.
-
tevador
I'm getting a lot of these errors when syncing: sent wrong NOTIFY_RESPONSE_GET_OBJECTS: block with id=4d51510...eb2b4e6 wasn't requested, dropping connection
-
tevador
malicious nodes?
-
selsta
as long as sync works i wouldn't worry about it
-
selsta
from what i remember the ban algo is a bit too strict during initial sync so some peers get dropped