-
hardenedsteel[m]
Here we go again, how many times will this happen?
-
hardenedsteel[m]
-
sech1
Consider it as a free stress test
-
one-horse-wagon[
People constantly attack many things on the internet. Monero is no exception.
-
duggavo[m]
What's the last string starting with 0x in the checkpoints
-
duggavo[m]
e.g. ADD_CHECKPOINT2(10, "block_hash", "0x2a974");
-
duggavo[m]
is it the block's cum diff?
-
moneromooo
Yes.
-
duggavo[m]
Another question
-
duggavo[m]
Shouldn't CUM_DIFF in monerod be renamed to CUMULATIVE_DIFFICULTY? It might sound a little bit . . . dirty
-
hyc
cosmetic changes with no functional difference are not allowed
-
duggavo[m]
* Shouldn't CUM_DIFF in monerod be renamed to CUMULATIVE_DIFFICULTY or CUMULATIVE_DIFF? It might sound a little bit . . . dirty
-
moneromooo
I was going to say that, but it's a single hit, in a user message. User messages are different for this guideline. But I think this one is really "if you think it's dirty, it says more about you than the code".
-
hyc
indeed. the context of this code is pretty clear
-
duggavo[m]
hyc: It's not in the code, it's printed in monerod too
-
duggavo[m]
when there is a reorg for example
-
hyc
the context of this *software* is pretty clear too
-
jeffro256[m]
Hey does anyone have the "AddressFromURL.failure" unit test fail randomly ?
-
selsta
jeffro256[m]: do you have an example? I never saw this fail
-
jeffro256[m]
> I was going to say that, but it's a single hit, in a user message. User messages are different for this guideline. But I think this one is really "if you think it's dirty, it says more about you than the code".
-
jeffro256[m]
Writing out "cumulative difficulty" for a user message could *maybe* make the connection click for an very, very new user because you don't have already know what the term shortens to to understand the message
-
jeffro256[m]
But also cum_diff is just funnier
-
jeffro256[m]
@selsta it fails on line 115 of address_from_url.cpp
-
jeffro256[m]
ASSERT_TRUE(dnssec_result) fails
-
jeffro256[m]
I was just wondering if it failed for anyone else b/c it could be a problem with my OS idk. It just recently started failing consistently on my platform
-
selsta
does it also failed with `DNS_PUBLIC="tcp://9.9.9.9"` env var set?
-
jeffro256[m]
It passed!
-
jeffro256[m]
I guess my VPN's DNS is messing with it