libera #monero-dev

5 Apr 2023

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 00:29
  selsta
  .merge+ 8802 8798 8797 8796 8791 8789 8788 8780 8771 8766 8765 8764 8724 8750 8748 8730 8719 8716 8698 8735 8694
• 00:29
  xmr-pr
  Added
• 00:31
  selsta
  UkoeHB: can this be merged or would you prefer a second approval? monero-project/monero #8679
• 00:32
  UkoeHB
  it's a C++ refactor so probably fine to merge
• 00:44
  selsta
  jeffro256[m]: can you take a look? you reviewed it before
• 01:04
  r4v3r23[m]
  <selsta> ".merge+ 8802 8798 8797 8796 8791..." <- v0.18.2.3 soon?
• 01:04
  selsta
  no, most of these are only for master branch
• 01:05
  selsta
  (unless there's an issue with .2)
• 05:27
  jeffro256[m]
  @selsta the code looks correct to me and it passes the unit tests!
• 05:28
  jeffro256[m]
  I haven't performed performance tests, but I can't see any reasons off the top of my head why this change would be any wrose
• 11:11
  selsta
  .merge+ 8679 8760
• 11:11
  xmr-pr
  Added
• 16:53
  jeffro256[m]
  .merges
• 16:53
  xmr-pr
  8679 8694 8698 8716 8719 8724 8730 8735 8748 8750 8760 8764 8765 8766 8771 8780 8788 8789 8791 8796 8797 8798 8802
• 22:21
  gingeropolous
  oh my