libera #monero-dev

28 Oct 2023

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 02:06
  selsta
  jeffro: monero-project/monero #8987 is causing some issues for me
• 02:08
  selsta
  jeffro256 (not sure if it tags you over the bridge), for example running `make release-test` now adds all this test data to the main dir that git shows as untracked files
• 02:08
  selsta
  but the main issue is some tests are failing
• 02:09
  selsta
  for example paste.debian.net/hidden/847d6010 - simply executing ./unit_tests makes this test fail, but executing it with lldb works, I assume that's because of the argc[0] in your code
• 02:23
  selsta
  basically I have to run `unit_tests/unit_tests` instead of `./unit_tests`due to some path issue
• 02:24
  selsta
  otherwise it doesn't find the test data
• 08:19
  m-relay
  <j​effro256:monero.social> monero-project/monero #9045 should fix that
• 08:19
  m-relay
  <j​effro256:monero.social> Sorry about that, I should have tested running `./unit_tests` from the current directory and the ctest suite
• 08:20
  m-relay
  <j​effro256:monero.social> What's funny is that since I was running `./unit_tests` raw a lot from the source root, it actually had the exact opposite effect for me: it fixed adding untracked files to the source tree
• 08:20
  m-relay
  <j​effro256:monero.social> Anyways, both issues should be fixed with that PR
• 08:21
  m-relay
  <j​effro256:monero.social> Sorry about that
• 13:44
  selsta
  ty, will review
• 13:45
  selsta
  also did something in master change the result of the select_outputs.density test?
• 13:45
  selsta
  Expected: (fabsf(selected_ratio - chain_ratio)) < (0.025f), actual: 0.0295275 vs 0.025
• 13:45
  selsta
  I ran the test also locally yesterday and it was similarly out of range
• 13:46
  selsta
  could be coincdence but in the past if it would fail it would be closer to 0.025 instead of 0.030
• 13:51
  selsta
  appears to just have been coincidence, running the test locally 30 times made it fail once. ideally we would merge monero-project/monero #8024 and also add a deterministic test