libera #monero-dev

21 Mar 2024

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 10:47
  dsc_
  does anyone know the reason why rapidjson is a submodule
• 10:54
  sech1
  Because it's a 3rd-party repository. Submodules make it easy to get new updates and track commit history between repositories.
• 11:07
  dsc_
  shouldnt vendor it like that, use OS libs instead and have CMake's find_package enforce version requirements, maybe I am overlooking something
• 11:28
  dsc_
  anyway its not important, just wondering
• 11:28
  dsc_
  i took some time to rewrite all the CMake into modern style cmake
• 11:29
  dsc_
  will create a PR this weekend as a proof-of-concept
• 11:31
  dsc_
  i yanked out most stuff and started from scratch
• 11:32
  dsc_
  in favor of Monero installing
• 11:32
  dsc_
  "properly"
• 11:32
  dsc_
  as well as easing up integrating Monero into your own project
• 11:33
  dsc_
  (e.g anyone that uses wallet2)
• 11:38
  dsc_
  note the PR is just a POC, not for merging. upstreaming it in case its useful for someone
• 17:30
  xFFFC0000
  dsc_ quite the contrary. For reproducible builds (which is a security necessity), you want to pull everything yourself. And depends less and less on environment.
• 20:28
  m-relay
  <v​kg1tyfj:matrix.org> huh so I missed an "s".. that's interesting and unexpected lol
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> I just tried this but getBlocksByHeight throws "fetch failed" in MoneroDaemonRpc.js:1639:22. Same error with getBlocksByRange. The getBlockByHeight succeeds. Any ideas what I'm doing wrong?
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> Example code:
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> (async () => {
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> const daemon = await connectToDaemonRpc("nodes.hashvault.pro:18081");
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlockByHeight:")
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> const block = await daemon.getBlockByHeight(3074677); // works
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> console.log(block);
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlocksByHeight:")
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> const blocks = await daemon.getBlocksByHeight([3074677]); // fails with "fetch failed"
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> console.log(blocks);
• 20:34
  m-relay
  <v​kg1tyfj:matrix.org> })();
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> I just tried this but getBlocksByHeight throws "fetch failed" in MoneroDaemonRpc.js:1639:22. Same error with getBlocksByRange. The getBlockByHeight succeeds. Any ideas what I'm doing wrong?
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> Example code:
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> ```
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> (async () => {
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> const daemon = await connectToDaemonRpc("nodes.hashvault.pro:18081");
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlockByHeight:")
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> const block = await daemon.getBlockByHeight(3074677); // works
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log(block);
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlocksByHeight:")
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> const blocks = await daemon.getBlocksByHeight([3074677]); // fails with "fetch failed"
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log(blocks);
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> ```
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> I just tried this but getBlocksByHeight throws "fetch failed" in MoneroDaemonRpc.js:1639:22. Same error with getBlocksByRange. The getBlockByHeight succeeds. Any ideas what I'm doing wrong?
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> Example code:
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> ```
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> (async () => {
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> const daemon = await connectToDaemonRpc("nodes.hashvault.pro:18081");
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlockByHeight:")
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> const block = await daemon.getBlockByHeight(3074677); // works
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log(block);
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlocksByHeight:")
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> const blocks = await daemon.getBlocksByHeight([3074677]); // fails with "fetch failed"
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> console.log(blocks);
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> })();
• 20:35
  m-relay
  <v​kg1tyfj:matrix.org> ```
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> I just tried this but getBlocksByHeight throws "fetch failed" in MoneroDaemonRpc.js:1639:22. Same error with getBlocksByRange. The getBlockByHeight succeeds. Any ideas what I'm doing wrong?
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> Example code:
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> ```
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> (async () => {
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> const daemon = await connectToDaemonRpc("nodes.hashvault.pro:18081");
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlockByHeight:")
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> const block = await daemon.getBlockByHeight(3074677); // works
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> console.log(block);
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> console.log("getBlocksByHeight:")
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> const blocks = await daemon.getBlocksByHeight([3074677]); // fails with "fetch failed"
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> console.log(blocks);
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> })();
• 20:38
  m-relay
  <v​kg1tyfj:matrix.org> ```
• 20:45
  m-relay
  <p​lowsof:matrix.org> vkg1tyfj: use a paste bin for code and dont edit large comments as they cause spam IRC side
• 20:45
  m-relay
  <p​lowsof:matrix.org> best suited for #monero-community-dev:monero.social (if this is monero-js/ts)
• 20:48
  m-relay
  <v​kg1tyfj:matrix.org> sorry guys didn't know :/
• 20:50
  m-relay
  <v​kg1tyfj:matrix.org> yes, monero-ts.. i joined community dev
• 23:00
  dsc_
  xFFFC0000
• 23:04
  dsc_
  reproducible builds have nothing to do with vendoring libs or not, or having sane CMake. For reproducible you just prepare your system such it is able to compile that, similar to static building.
• 23:20
  dsc_
  xFFFC0000 sorry if I sound passive aggressive, I just woke up and spent too much time in CMake this week :P
• 23:29
  selsta
  some of the libs were vendored because anonimal maintained forks with security patches added, since he isn't around anymore it kinda became pointless
• 23:29
  selsta
  others are just vendored for historical reasons and no one bothered to change it
• 23:30
  dsc_
  right
• 23:35
  selsta
  at least rapidjson and miniupnpc can be removed
• 23:36
  dsc_
  vendoring libs is not a big issue, i am just being pedantic. In the case of rapidjson, its pinned to a commit from 6 years ago, and wondered if there was a specific reason
• 23:36
  dsc_
  Monero seems to compile fine against newer versions of rapidjson
• 23:37
  selsta
  we should probably update the submodule
• 23:42
  selsta
  .merges
• 23:42
  xmr-pr
  8396 8488 9252
• 23:48
  dsc_
  selsta: what im trying to do is make Monero headers/libs install in, for example, /usr/local/
• 23:49
  dsc_
  so that people who want to consume those libs (libwallet_merged.a for example) only have to do `find_package(Monero 0.18.3.2 REQUIRED)`
• 23:51
  dsc_
  if we look at any project that uses wallet2, they currently always need to include stuff like this github.com/woodser/monero-cpp/blob/master/CMakeLists.txt#L32
• 23:52
  dsc_
  while instead those include paths should be provided by a CMake config and not at all be managed by the consuming project