-
m-relay<jeffro256:monero.social> Fr. I also noticed that, in some instances, when you push a commit, and then squash them all together within a very short span (say a minute), the last commit disappears from the comments screen and the "compare changes" button shows the diff from the latest commit (which isn't shown)
-
m-relay<jeffro256:monero.social> So you could push a commit with malicious code then squash immediately after, and the comments screen won't show that code in a commit or rebase diff
-
m-relay<jeffro256:monero.social> It'll show up in the "files" screen, but if a reviewer has already reviewed 95% of the PR, and the author says that they're just gonna push a couple lines of trivial changes, the reviewer probably won't go through the entire thing again
-
m-relay<jeffro256:monero.social> Solution: 1) don't use github, 2) double-check all diffs and commits with the `git` CLI 3) every time there is a rebase, start reviews over again completely
-
TastyPoisonI want to know if I can aggregate signatures for multisig wallet. right now in a 3/4 threshold wallet for exmpl, alice should make a transfer transaction, send it to bob, bob signs it and sends it to carol, and then carol signs over what bob sent her to submit to the network. Could it be, that alice signs and send her transaction to bob and carol,
-
TastyPoisonthey each sign it and send it back to alice, and then alice aggregate them and submit to network??