-
UkoeHBselsta: 8920 and 7852 are mergeable. 9198 is an easy one that needs to be merged to unblock other PRs.
-
UkoeHBvtnerd: 8203 could use some more review. The seraphis_lib is kind of stuck on top of that commit.
-
UkoeHB9196 needs cryptography review. Maybe explore using the research funds to hire Aaron for open-ended crypto-review hours.
-
selsta.merge+ 8920 7852
-
xmr-prAdded
-
selstajeffro256: please approve 9198
-
Guest6854/msg NickServ IDENTIFY nssy Master2620
-
m-relay<rottenwheel:kernal.eu> Oh noes. Lol.
-
m-relay<pcre:monero.social> shit happens
-
m-relay<jeffro256:monero.social> @selsta: reviewing now
-
selstaUkoeHB: 8920 tests CI failed, do you remember if this was unrelated? the logs are gone now
-
UkoeHBselsta: IIRC it was unrelated (that spurious race condition test). I can force-push to trigger them again if you want
-
UkoeHBThat PR's code is independent of unit tests.
-
m-relay<jeffro256:monero.social> UkoeHB: is the reason that we're copying blake2b from randomx is changing the namespace ?
-
UkoeHBjeffro256: It adds the memwipe back in, and avoids excess coupling outside the lib.
-
m-relay<jeffro256:monero.social> wait im stupid i literally just looked at that
-
m-relay<jeffro256:monero.social> but yeah everything matches except for those uncommented clear_internal_memory() lines
-
selstaUkoeHB: rerunning CI is not necessary for this PR
-
selsta.merge+ 9198
-
xmr-prAdded
-
UkoeHBok, thanks :)
-
selstaif someone runs a node with Tor / I2P inbound connections and wants to get added as a seed node please add a comment here: monero-project/monero #9316