-
vthorAre there any plan to take it over, continue, substitute github.com/monero-ecosystem or something?
-
moneromoooThere's an interesting not-quite-a-bug in monerod, where the zmq notifiers for new blocks fire, but since that's done before the lmdb txn gets committed, if the callee runs a RPC to get data, it might still see the old state before that block got added.
-
sech1This can't be right, send_miner_notifications() is called in the very end of Blockchain::handle_block_to_main_chain(), after m_db->add_block(...)
-
moneromoooThat's still before the txn being committed. Which is in end_handle_incoming_block or similar IIRC.
-
moneromoooCome to think of it, it means that if there's a couple blocks being added due to a reorg, and it fails at the second block, the first block would trigger a notification, even though it will never get committed.
-
m-relay<jeffro256:monero.social> tbf that block in isolation would have been valid, just not the altchain after it
-
sech1zmq notifications are sent from the same place in the code as the good old "--block-notify" notifications, so I guess it's a feature at this point :D
-
sech1if two blocks fail, but first block triggers a notification, then the chain will be reverted anyway and one more notfication (for a new chain tip) will be sent