-
tobtoht_
merges this week would be phenomenal
-
tobtoht_
if time permits
-
tobtoht_
ping luigi1111
-
luigi1111
You have permissions now. I will try to merge Tuesday though
-
tobtoht_
am i allowed to merge queued prs if they are my own?
-
tobtoht_
that's all that's left
-
tobtoht_
i could be more productive if i didn't have to deal with the cognitive load of maintaining/rebasing 45 open prs
-
tobtoht_
approvals and selsta already gatekeep what can be merged
-
tobtoht_
i don't see why it matters who ultimately presses the merge button
-
tobtoht_
this rule precisely hinders the dependency-hell maintenance i do - for no apparent benefit
-
tobtoht_
it's entirely bottlenecked by the speed of merges
-
ofrnxmr
.merges
-
xmr-pr
9453 9491 9523 9544 9643 9645 9646 9648 9650 9653 9666 9680
-
ofrnxmr
👍 9453 9491 9523 9544 9643 9645 9646 9648 9650 9653 9680(vtnerd comment) - do any need release versions? tobtoht_
-
tobtoht_
9643 would be nice to have on release because of bug fixes, but doesn't backport cleanly. I'll skip that one for now until I decide what to do for release.
-
tobtoht_
thanks for going through the list
-
ofrnxmr
Thanks tob
-
m-relay
<everoddandeven:monero.social> Hey guys
-
m-relay
<everoddandeven:monero.social> I have a question, what are the conditions for creating multiple transactions to satisfy a particular request to send funds from wallet?
-
m-relay
<everoddandeven:monero.social> Only when outputs are too much and transaction would be too big?
-
m-relay
<monero.arbo:matrix.org> max outputs is 16, max inputs is limited by max transaction size... currently 140ish kB ?
-
m-relay
<monero.arbo:matrix.org> I think it's a little less than half of the current blocksize limit
-
m-relay
<everoddandeven:monero.social> is defined as `CRYPTONOTE_MAX_TX_SIZE` (`cryptonote_config.h`), right?
-
m-relay
<monero.arbo:matrix.org> I believe it's line 118 here: `get_min_block_weight(version) / 2 - CRYPTONOTE_COINBASE_BLOB_RESERVED_SIZE`
-
m-relay
-
m-relay
<monero.arbo:matrix.org> CRYPTONOTE_MAX_TX_SIZE you referenced seems to be a max TX size since it's set to 1 million bytes eg almost a megabyte
-
m-relay
<monero.arbo:matrix.org> CRYPTONOTE\_MAX\_TX\_SIZE you referenced seems to be an absolute limit on TX size since it's able to grow with block size
-
m-relay
<ofrnxmr:monero.social> 100kb (2/3 of a 150kb max tx size limit)
-
m-relay
<ofrnxmr:monero.social> {I dont know why its 2/3}
-
m-relay
<ofrnxmr:monero.social> It depends on if you use a sweep, transfer_split or transfer. The former 2 will create more transactions, keeping each tx under 100kb
-
moneromooo
IIRC it's 2/3 to avoid the case where only one tx might fit, instead of 2. "Engineering tolerance".
-
moneromooo
Better than have 2 instead of 3. The "loss" is smaller. I don't remember any other reason.
-
moneromooo
It just might be always certain two would fit given the constraints the wallet uses, I am just not 100% sure.
-
moneromooo
I also can't recall whether the wallet "predicts" what the max block size might be in a few blocks, in case it goes down.
-
moneromooo
Don't think it does.
-
m-relay
<monero.arbo:matrix.org> interesting. one effect is that doing 2/3 (100 kB) makes sure there's leftover room for small/normal transactions