-
m-relay
<tzadiko:matrix.org> 0xfffc: I addressed your comment here:
monero-project/monero #9838 , if it looks good can you approve, please?
-
m-relay
<0xfffc:monero.social> Thanks. Can you investigate what is this test failure:
-
m-relay
<0xfffc:monero.social> > 1/20 tests failed: transfer
-
m-relay
<tzadiko:matrix.org> Yeah, going to bed now, will investigate tomorrow.
-
m-relay
<tzadiko:matrix.org> How do people run the Python tests in isolation? I see they get compiled into C++ (e.g. functional_tests_rcp), but if I want to run and debug the tests, I think I need to setup a Python virtual environment and install the libraries. Is that right? Is there a requirements.txt file?
-
selsta
tzadiko: python3 ./functional_tests_rpc.py python3 ~/dev/monero/tests/functional_tests/ ~/dev/monero/build/release/ all
-
selsta
you also need the dependencies installed
-
selsta
(at least that command was in my shell history)
-
selsta
needs 'requests', 'psutil', 'monotonic', 'zmq', and 'deepdiff' python modules
-
m-relay
<tzadiko:matrix.org> Theres no requirements.txt file that specifies the versions of those packages?
-
m-relay
<tzadiko:matrix.org> Well I have it running, but I'd like to debug it, so I'm looking at that now.
-
m-relay
<tzadiko:matrix.org> I think I will make an PR that adds a requirements.txt as well as documentation for how to debug Python tests in isolation because, while I figured it out, it wasn't very clear. Could save the next guy /girl some time.
-
m-relay
<syntheticbird:monero.social> Kind reminder that this +32/-8 PR needs review + have been tested:
monero-project/monero #9844
-
m-relay
<ofrnxmr:xmr.mx> And needs a release version
-
m-relay
<syntheticbird:monero.social> yeah
-
m-relay
<syntheticbird:monero.social> current the only barrier until release
-
m-relay
<ofrnxmr:xmr.mx> Might as well do 9836 9837 as well
-
m-relay
<ofrnxmr:xmr.mx> (those are backports from master)
-
m-relay
<syntheticbird:monero.social> ok true these are free
-
m-relay
<ofrnxmr:xmr.mx> jeffro256 jefrooooo
-
m-relay
<tzadiko:matrix.org> 0xfffc: Fixed
-
m-relay
<ofrnxmr:xmr.mx> 0xfffc will be back in cpl days
-
m-relay
<ofrnxmr:xmr.mx> But focus rn (hopefully) is on cutting this next release
-
m-relay
-
m-relay
<jeffro256:monero.social> ofrnxmr:
monero-project/monero #9853
-
m-relay
<ofrnxmr:xmr.mx> Ty sir
-
m-relay
<jeffro256:monero.social> 🫡
-
m-relay
<0xfffc:monero.social> Yes sir 🫡