-
m-relay
<ashishb1052002:matrix.org> Hey is something wrong with the Monero GitLab? I am not able to access it.
-
m-relay
<321bob321:monero.social> its down
-
m-relay
<ofrnxmr:xmr.mx> Yes
-
m-relay
<ofrnxmr:xmr.mx> ^
-
m-relay
<plaiwanone:matrix.org> GM
-
m-relay
<plaiwanone:matrix.org> I have a question or two for every dev available on this planet
-
m-relay
<plaiwanone:matrix.org> Can a disabled or special person run a Monero public node?
-
m-relay
<plaiwanone:matrix.org> Thank you in advance everyone
-
m-relay
<ofrnxmr:xmr.mx> How is tour question in _any_ way related to development? And why is it directed at _every_ dev?
-
m-relay
<ofrnxmr:xmr.mx> Your*
-
m-relay
<ofrnxmr:xmr.mx> Or, to put it differently: this room is for development, not for general questions. Your question is not regarding development, and is very much a "general" question. It's also not something that only a dev can answer
-
m-relay
<ofrnxmr:xmr.mx> ask your question in [#monero:monero.social](https://matrix.to/#/%23monero:monero.social)
-
m-relay
<plaiwanone:matrix.org> Sorry my bad
-
selsta
.merge+ 10428 10457 10492 10494
-
xmr-pr
Added
-
selsta
.merge+ 10460
-
xmr-pr
Added
-
m-relay
-
m-relay
<jpk68:matrix.org> This line is giving me some issues, as it would be helpful to have other zones' endpoint not be SOCKS ones
-
m-relay
<jpk68:matrix.org> What would be the best thing to put here instead? `epee::net_utils::network_address`?
-
m-relay
<jpk68:matrix.org> Hopefully I don't have to change anything in epee
-
m-relay
<vtnerd:monero.social> is that only used for `get_proxies` ?
-
m-relay
<jpk68:matrix.org> I honestly cannot tell
-
m-relay
<vtnerd:monero.social> yeah its only used for configuration
-
m-relay
<vtnerd:monero.social> either make it a variant or just get a separate function for this
-
m-relay
<vtnerd:monero.social> you (probably) have to setup a custom m_connect function for SAM, so the caller needs to know what type anyway
-
m-relay
<jpk68:matrix.org> I could be wrong, but it seems that using a variant would require me to change all of the other code that uses `m_proxy_address` because it expects it to be SOCKS
-
m-relay
<jpk68:matrix.org> Would it be an option to add a separate field in `proxy` for the SAM address? Or would that not work
-
m-relay
<jpk68:matrix.org> *by SAM address, I mean the (local) IP of the router
-
m-relay
<vtnerd:monero.social> you can probably just rename the socks endpoint to something else, and then create a new enum for sam+socks (to replace ver in socks endpoint) and then write a custom connect function
-
m-relay
<vtnerd:monero.social> Even if you don't use the other fields is probably not a big deal
-
m-relay
<vtnerd:monero.social> Or no even easier
-
m-relay
<vtnerd:monero.social> The connect function handles it all, just create a new field in network_zone and then pass it in the connect handler
-
m-relay
<vtnerd:monero.social> Don't even touch get_proxies, just create a parallel function but error if socks and Sam are configured on i2p
-
m-relay
<vtnerd:monero.social> You could make m_proxy_address a variant if you wanted to save space, but theres few zones at runtime so it's not a big deal
-
m-relay
<vtnerd:monero.social> And to clarify, you'd be writing a separate `sam_connect_internal` function that gets set to `m_connect_func` whose implementation uses i2p Sam whatever from the network_zone instance
-
m-relay
<jpk68:matrix.org> So basically, there would be a separate `m_sam_address` (the IP/port of the router), and then `sam_connect` is used instead of `socks_connect`
-
m-relay
<jpk68:matrix.org> I already have those functions made, so that will probably work
-
m-relay
<jpk68:matrix.org> The thing I have in mind (what would make the most sense from a UX perspective) is to have the `--i2p-sam` flag override `--tx-proxy` and `--anonymous-inbound`; this is currently done using an if-else statement that only touches `get_proxies` if SAM isn't set
-
m-relay
<jpk68:matrix.org> So that might conflict with it
-
m-relay
<vtnerd:monero.social> Seems better to just error out, the person might be confused by the options
-
m-relay
<vtnerd:monero.social> Whoever sets the connect function last will take precedence basically
-
m-relay
<jpk68:matrix.org> Okay, thanks. I'll see if I can manage to wrap my head around this ;)
-
m-relay
<jpk68:matrix.org> No way, it actually kind of works now
-
m-relay
<jpk68:matrix.org> The session doesn't get established, but still :))