libera #monero-dev

5 May 2026

Official repo: github.com/monero-project/monero || Don’t ask to ask, just ask:) || Monero GUI dev is at #monero-gui || Monero website dev is at #monero-site || Non-dev questions -> #monero, please || No fork help, you’re on your own

• 16:05
  selsta
  .merge+ 10463 10496 10497 10498 10499 104500 10501 10502
• 16:19
  tobtoht
  need +1 on 10498 10499 10501 10502
• 16:42
  br-m
  <jpk68:matrix.org> Not sure if it counts as an "approval", but I2P devs have approved the changes in 10458
• 16:42
  br-m
  <jpk68:matrix.org> monero-project/monero #10458#issuecomment-4375861957
• 16:49
  br-m
  <ofrnxmr:xmr.mx> Check back in a year
• 16:51
  br-m
  <jpk68:matrix.org> Trying to be optimistic for now :))
• 16:52
  br-m
  <ofrnxmr:xmr.mx> Similar to socks5 (enhacing an existing feature), but less if a required update (nobody needs this)
• 16:52
  br-m
  <jpk68:matrix.org> I would disagree, but sure
• 16:53
  br-m
  <ofrnxmr:xmr.mx> youre free to disagree, but zero people have ever rewuested this
• 16:53
  br-m
  <ofrnxmr:xmr.mx> If you have a .i2p domain, you also have a b32. And the b32 works fine
• 16:54
  br-m
  <ofrnxmr:xmr.mx> Without socks5 pr you cant use certain networks and cant use auth
• 16:54
  br-m
  <jpk68:matrix.org> So if you're trying to add a peer/node with a readable hostname you can remember, you instead have to manually do the lookup and then paste the Base32 address in
• 16:54
  br-m
  <jpk68:matrix.org> Does not exactly seem super convenient
• 16:54
  br-m
  <ofrnxmr:xmr.mx> Socks5 was requested by numerous people and projects, and reviewed and tested by 3-4 people
• 16:55
  br-m
  <ofrnxmr:xmr.mx> @jpk68:matrix.org: You dont have to add peers. Thats what seed nodes are for
• 16:56
  br-m
  <jpk68:matrix.org> Sure, but you might want to
• 16:56
  br-m
  <jpk68:matrix.org> I just posted the link in case anyone didn't know who it was that commented
• 16:57
  br-m
  <ofrnxmr:xmr.mx> It doesnt count as an approval btw. To approve, theyvd have to actually review the pr and hit approve
• 16:57
  br-m
  <ofrnxmr:xmr.mx> its just a comment / concept ack
• 16:58
  br-m
  <jpk68:matrix.org> Which is why I stated that I wasn't sure whether it counted
• 16:58
  selsta
  this is smaller than socks5 so it might get reviewed faster, just a really niche feature
• 16:58
  br-m
  <ofrnxmr:xmr.mx> yeah, im juat clarifying that approvals (if done via the github interface) should use githubs actual review tool
• 17:00
  br-m
  <ofrnxmr:xmr.mx> selsta: I was half sarcastic about the 1yr thing. Just that theres no "rush" to add this, since its a nice-to-have (and afaik i2p-sam pr doesnt require it)
• 17:00
  br-m
  <jpk68:matrix.org> selsta: Yeah, 1600-line change vs 220 lines
• 17:00
  br-m
  <jpk68:matrix.org> About half of which are tests
• 17:01
  br-m
  <r4v3r23> socks5 is coming?
• 17:01
  br-m
  <jpk68:matrix.org> Already here, on master
• 17:01
  br-m
  <r4v3r23> oh nice
• 17:01
  br-m
  <ofrnxmr:xmr.mx> @jpk68:matrix.org: 1600line was also a lot of documentation
• 17:01
  br-m
  <ofrnxmr:xmr.mx> @r4v3r23: Its merged on master. Might also be on release, need to double check
• 17:02
  br-m
  <ofrnxmr:xmr.mx> Yeah, its in the next release too
• 17:02
  br-m
  <ofrnxmr:xmr.mx> monero-project/monero #10411
• 17:02
  selsta
  we backported it to have one proper new "feature" for this release beyond bug fixes
• 17:04
  br-m
  <jpk68:matrix.org> So basically a 60-line change, not including doc comments
• 19:16
  tobtoht
  .merges
• 19:16
  xmr-pr
  Merge queue empty
• 19:16
  tobtoht
  at last
• 19:21
  br-m
  <r4v3r23> 0.18.5 running smooth on mobile
• 19:49
  ryurt46
  how many needs to review a PR for it to be merged?
• 19:50
  tobtoht
  at least 2
• 19:50
  br-m
  <ofrnxmr> 2+
• 19:50
  ryurt46
  thanks'
• 19:51
  ryurt46
  is there any specific merge order or just FCFS?
• 19:53
  tobtoht
  pr needs to have existed for at least a week
• 19:54
  tobtoht
  there are exceptions for documentation and ci fixes
• 19:55
  ryurt46
  aha ok, so my maintenance PR(10520) will be merged in like a week?
• 19:55
  tobtoht
  yes, looks good
• 19:56
  ryurt46
  Thanks a lot, really fun to be involved :)
• 19:56
  tobtoht
  thanks for submitting a PR :)
• 19:57
  ryurt46
  @tobtoht is there any similar maintenance "issues" that you know of?
• 20:00
  tobtoht
  fixing compiler warnings is always useful (there are plenty more)
• 20:03
  ryurt46
  alright, will have a look at those
• 20:04
  br-m
  <jpk68:matrix.org> I know you didn't ask me, but IMO the systemd service file could use some improvement/hardening, and scripts for other init systems (like OpenRC) might be nice
• 20:04
  br-m
  <jpk68:matrix.org> Others might disagree though, I'm not sure
• 20:07
  ryurt46
  Sounds interesting, thanks for the suggestion! For now I'm mainly focusing on C++ related issues, but I might take a look at that later on
• 20:20
  br-m
  <ofrnxmr:xmr.mx> @jpk68:matrix.org: monero-project/monero-docs #294
• 20:20
  br-m
  <jpk68:matrix.org> My bad, didn't see that
• 20:22
  br-m
  <ofrnxmr:xmr.mx> Theres a comment there abt hardening, but out of scope for the pr. I think it could be added as optional, but not needed in (imo) unnecessarily complicate a simple unit
• 20:22
  br-m
  <jpk68:matrix.org> Shouldn't it have "Wants" instead of "Requires" at the top of the file
• 20:24
  br-m
  <ofrnxmr:xmr.mx> monero-project/monero-docs #294#discussion_r3015788146
• 20:25
  br-m
  <jpk68:matrix.org> I was under the impression that "Requires" makes a unit stop if the networking fails, for example. Maybe that's fine though
• 20:46
  br-m
  <ofrnxmr:xmr.mx> @jpk68:matrix.org: I think youre probably right (as was the author). if so, not sure why it was changed
• 21:19
  selsta
  small reminder regarding gitian sigs
• 21:20
  br-m
  <ofrnxmr:xmr.mx> on it
• 22:33
  scoobybejesus
  so _*that's*_ why I updated! and then I got distracted by copyfail...