-
hcsr03
Hey guys! Did not see any outright "Stay away" warning for guys like me in the repo docs. So..
-
hcsr03
Any plans on moving (partially) to Rust? Can we make contributions with parts in Rust (including updating the build system ofc)
-
tobtoht
There is a community supported daemon implementation written in Rust:
cuprate.org
-
tobtoht
As for core: a proposed network upgrade (FCMP++) will add Rust for new cryptography. It has not been decided yet which, if any, other parts of the codebase should oxidize.
-
hcsr03
Oh damn!! Missed that in the FCMP flood of changes. Thanks!
-
hcsr03
And can it be recommended to run the curate.org daemon for your own full node? I know Bitcoing core also has a Rust implementation but they have a strong warning to not use it beyond experimentation as they don't want even the tiniest deviations from the consensus rule.
-
br-m
<boog900> we haven't released wallet/RPC support yet
-
br-m
<boog900> also it is in alpha so no you should depend on it yet for anything of value
-
selsta
.merge+ 10786 10788 10772 10773 10775 10776 10768 10769
-
xmr-pr
Added
-
tobtoht
.merges
-
xmr-pr
10768 10769 10788
-
br-m
<jpk68:matrix.org> selsta: I agree with ofrn that the copyright date should just be 2025
-
selsta
if you touched the file in 2026 it can be 2025 - 2026
-
br-m
<jpk68:matrix.org> Alright, fixed
-
br-m
<tobtoht> I really wish we would just remove the copyright year from the headers. It is needless maintenance.
-
br-m
-
br-m
<tobtoht> (Not relevant for this PR)
-
br-m
<jpk68:matrix.org> Bitcoin Core just does, for example, Copyright (c) 2009-present The Bitcoin Core developers
-
br-m
-
br-m
<jpk68:matrix.org> Just to play devil's advocate, it could be possible to remove the full license text as well. Imagine we were licensed under GPLv3 and had to include the full thing in every file, lol
-
br-m
<ofrnxmr:xmr.mx> id be in favor of not adding the license text to your current pr
-
br-m
<jpk68:matrix.org> I guess that was suggested in the comment you linked to anyways
-
br-m
<jpk68:matrix.org> I can submit one changing all of the files /s
-
br-m
-
br-m
<tobtoht> "All rights reserved" is archaic.
-
br-m
<ofrnxmr:xmr.mx> alternative it to just have the year of file creation, like leveldb > <@tobtoht> I really wish we would just remove the copyright year from the headers. It is needless maintenance.
-
br-m
<tobtoht> I'm fine with that too.
-
br-m
<jpk68:matrix.org> In any case, such a shift from convention would be better suited for a different patch, IMO
-
br-m
<jpk68:matrix.org> I think 2025-2026 is good for now
-
br-m
<tobtoht> I used SPDX for Feather, like the Linux kernel:
-
br-m
<tobtoht> // SPDX-License-Identifier: BSD-3-Clause
-
br-m
<tobtoht> // SPDX-FileCopyrightText: The Monero Project
-
br-m
<jpk68:matrix.org> That would be a bit more difficult in files where attribution is given to CryptoNote, Boolberry, etc.
-
br-m
<jpk68:matrix.org> Sorry, I meant to phrase that as a question
-
br-m
<tobtoht> You could just another line or SPDX tag.
-
br-m
<tobtoht> Meh, SPDX is too verbose. I think I prefer a variation from
monero-project/monero #9666#issuecomment-2659650854 with or without creation year.
-
br-m
<tobtoht> Thing is, if you keep the creation year you'll get people trying to update it.
-
br-m
<jpk68:matrix.org> My two cents is that I agree with iamamyth in the first one being the best
-
br-m
<jpk68:matrix.org> Though it would be nice to have 2014-present or something as the year
-
br-m
<jpk68:matrix.org> Example with multiple people (tor_address.cpp):
paste.debian.net/hidden/def4e083
-
br-m
<tobtoht> Are we still fresh and juicy?
monero-project/monero 84ca73e
-
br-m
<tobtoht> Anyways
-
br-m
<tobtoht> @jpk68:matrix.org: That's fine with me tbh
-
br-m
<tobtoht> My preference is: no year > <creation>-present > <creation> (but I'm fine with whatever we can agree to)
-
br-m
<tobtoht> As long as it doesn't involve updating the headers on every edit or every year.
-
selsta
.merge+ 10781 10785
-
xmr-pr
Added
-
selsta
tobtoht regarding 10781 if you want to wait until jberman adds more info it's also fine since rbrunner also wanted to review it
-
tobtoht
I'll give jberman a chance to respond and rbrunner a chance to review ^^