-
br-m<thomasbuilds:matrix.org> v-0.19 milestone on this PR monero-project/monero #10694
-
br-m<thomasbuilds:matrix.org> means it won't get merged in a few months?
-
tobtohtit will get merged before we branch from master
-
tobtohtneeds more reviews tho
-
br-m<thomasbuilds:matrix.org> My goal with this PR is to remove all the dead code in the monero repo, what you think? monero-project/monero #10809 ?
-
br-m<thomasbuilds:matrix.org> The build succeeded on my computer, so it seems good so far.
-
br-m<thomasbuilds:matrix.org> I haven't looked yet if your PR overlaps mine
-
br-m<thomasbuilds:matrix.org> Probably yours will get merged before mine?
-
br-m<thomasbuilds:matrix.org> tobtoht: will review it
-
br-m<ofrnxmr:xmr.mx> bootstrap isnt dead code. if there are conflicts due to one being merged before the other, you simply rebase and resolve them
-
br-m<thomasbuilds:matrix.org> yeah it's fine
-
tobtohtI'm not a fan of unmotivated shotgun removals. I want to know when something was added and why it is no longer used (e.g. unused since PR x or never used).
-
br-m<thomasbuilds:matrix.org> I'll keep this draft PR open (and continue updating it - removing dead code keeps uncovering more dead code lol). That way we know where the dead code lives, allowing anybody to submit smaller, more focused PRs.
-
br-m<ofrnxmr:xmr.mx> should probably set it to draft if its not intended to be merged as-is
-
br-m<thomasbuilds:matrix.org> it was already as draft
-
br-m<ofrnxmr:xmr.mx> nvm, it is a draft
-
br-m<jpk68:matrix.org> Does anyone have an opinion on 10791
-
br-m<jpk68:matrix.org> This seems like a decent idea, but very intrusive to implement