-
br-m<thomasbuilds:matrix.org> Was going through monero github repos and noticed kovri is set as public archive yet kovri-docs and kovri-site aren't
-
br-m<thomasbuilds:matrix.org> kastelo should be archived too?
-
br-m<ofrnxmr:xmr.mx> @thomasbuilds:matrix.org: Kastelo lol
-
br-m<ofrnxmr:xmr.mx> id argue that kastelo should be migrated to msvb's personal repo and deleted from monero-project
-
br-m<thomasbuilds:matrix.org> Yeah wherever it's about deleting or archiving it's not up to me. But yeah I'd delete it.
-
br-m<thomasbuilds:matrix.org> mrelay.p2pool.observer/m/matrix.org/MmmNQTxPChqvIMbkNumnURRi.png (Screenshot from 2026-07-22 09-25-30.png)
-
br-m<thomasbuilds:matrix.org> should also pin gitan sigs repo
-
tobtoht.merges
-
xmr-pr10747 10823 10863 10876 10894 10921
-
selsta.merge+ 9828
-
xmr-prAdded
-
dasterMsg
-
selsta.merge+ 10896
-
xmr-prAdded
-
selsta.merge+ 10358
-
xmr-prAdded
-
tobtoht.merges
-
xmr-pr10747 10863 10876 10894 10921
-
tobtoht.merges
-
xmr-pr10747 10876 10894
-
selsta.merge+ 10694
-
xmr-prAdded
-
selstais it preferred to re-indent 100+ lines, or is it okay to add 3 lines without correct indentation for a patch?
-
br-m<ofrnxmr:xmr.mx> The 100 lines are incorrect and the 3 lines match it?
-
selstafound a different solution anyway
-
selstano my question was something else, current code is correct but my patch would add new { } which would change indentation
-
selstabut i found a solution now without adding { }
-
moneromoooIs that code for... goto ? :D
-
moneromoooI'm pretty sure I already made at least one patch doing just that (adding extra test and {} but leaving existing code as is without reindent). I typically add extra newlines at the { and } places to make things clear. 100+ lines reindent is way too large and will cause pain and conflicts. I sometimes do the reindent in TF but only because I'm the only one working on it. It's inconsiderate
-
moneromooootherwise. Though I'm sure some will say it's inconsiderate to go the other way.
-
br-m<jeffro256> It's a trade-off for pain now and pain later. No re-indent makes the code much harder to read and maintain. Re-indenting now means the git blame is messed up, and requires a reviewer to make sure that the lines are copy and pasted correctly.
-
br-m<jeffro256> As someone who is updating a decent amount of code, and keeps stumbling upon indentation inconsistencies, I'm really starting to prefer just doing the indentation correct now
-
selstano goto, it just has a bit longer lifetime now but should not matter
-
br-m<jeffro256> BTW I'd like to review beg for #9827, a pre-req for carrot_core
-
tobtohtI agree with jeffro, also git blame -w exists
-
br-m<jeffro256> And git diff -b