-
br-m
<shortwavesurfer2009> Was trying to build the gui for android with selsta's qr6 pr 4659 and got
-
br-m
<shortwavesurfer2009> Performing Streamed Install
-
br-m
<shortwavesurfer2009> adb: failed to install /home/user/build/monero-gui/build/Android/release/android-build/build/outputs/apk/release/android-build-release-unsigned.apk: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl356738690.tmp/base.apk: Attempt to get length of null array]
-
br-m
<shortwavesurfer2009> Just for testing purposes, I was able to sign it with this site and it worked.
-
br-m
<shortwavesurfer2009>
perchance.org/apk-edit
-
br-m
<shortwavesurfer2009>
mrelay.p2pool.observer/m/monero.social/ByHiferlvXuusQwwFONkWODE.png (Where would be the place to report UI issues?)
-
br-m
<jpk68:matrix.org> Hey, nice
-
br-m
<shortwavesurfer2009> @jpk68:matrix.org: It's been a process, that's for sure.
-
br-m
<slowbeardigger:matrix.org> yoooo trying to port the Monero GUI wallet? based
-
br-m
<jpk68:matrix.org> Someone on Reddit also did it a while back, I think
-
br-m
<jpk68:matrix.org> There's build support provided for Android, but it's horribly outdated
-
br-m
<jpk68:matrix.org> But maybe some day, we can get official GUI builds for Android (no guarantees) :)
-
br-m
<slowbeardigger:matrix.org> @jpk68:matrix.org: Thad be great
-
br-m
<slowbeardigger:matrix.org> Consider a ccs proposal
-
xmr-pr
Ap4sh opened pull request #11393: tests: wait for p2p reorg completion
-
xmr-pr
-
tobtoht
.merges
-
xmr-pr
10606 10724 10940 10964 11115 11244 11248 11262 11263 11264 11265 11274 11306 11311 11321 11342
-
br-m
<thomasbuilds:matrix.org> don't merge 11264/65 yet plz
-
br-m
<thomasbuilds:matrix.org> rip
-
tobtoht
sorry, please comment on a PR if it needs changes
-
tobtoht
didn't merge 64
-
br-m
<thomasbuilds:matrix.org> yeah jpk said he'd mark them as drafts in DMs, probably forgot
-
br-m
<thomasbuilds:matrix.org> basically 65 one was redundant in some way with the updated 64
-
tobtoht
ok, perhaps you can suggest jpk undo the changes in 64
-
br-m
<thomasbuilds:matrix.org> Both add a partial-key-image count check at the top of the same loop, with different sources for the expected count. whichever merges second breaks the other. One should drop its copy. The version in #11264 is better, because it doesn't depend on the local key list.
-
br-m
<thomasbuilds:matrix.org> that's what I sent him in DM
-
tobtoht
please comment this on the 64 so I get to read it when I check if it is mergeable
-
tobtoht
in general, try to keep feedback on PRs public unless someone made a silly mistake
-
tobtoht
.merges
-
xmr-pr
10964 11248 11263 11264 11306
-
br-m
<ofrnxmr:xmr.mx> if you see something with 2+approvals that should not be merged, comment on it > <@thomasbuilds:matrix.org> don't merge 11264/65 yet plz
-
br-m
<thomasbuilds:matrix.org> OK yeah my bad
-
br-m
<shortwavesurfer2009> I'm honestly not all that interested in seeing the Monero GUI wallet on Android as much as I'm interested in seeing the Monero GUI wallet on Post Market OS and Ubuntu Touch.
-
br-m
<shortwavesurfer2009> Google is killing Android, but if we can get the UI to work on Android, that means that it should also work on Ubuntu Touch and Post Market OS with just a port to the system and not having to change the UI.
-
br-m
<shortwavesurfer2009> Since it's based on Alpine Linux, it's basically the desktop build, but with the mobile UI.
-
br-m
<shortwavesurfer2009> Well, post-market OS is based on Alpine Linux anyway.
-
br-m
<ofrnxmr:xmr.mx> i assume the ui is the same for all platforms
-
br-m
<ofrnxmr:xmr.mx> just responsive, so android build is essentially just showing you how it scales on a mobile screen
-
selsta
let's continue GUI discussion in the GUI channel
-
br-m
<shortwavesurfer2009> @ofrnxmr:xmr.mx: Yep. So if the UI on Android can be fixed, that means that the UI will run properly on Post Market OS and Ubuntu Touch.
-
br-m
<ofrnxmr:xmr.mx> #monero-gui:monero.social