.merge+ 3684

Added

hello

i had a segfault yesterday paste.debian.net/1210153

any help?

That looks related to a recent race fix, though not quite the same stack I've seen.

IIRC you paste the link to the PR yesterday for something else.

this segfault is strange because happens on 4 of 6 nodes that i have

2 of nodes dont crash at all!

i had connection problems and desperated i "did the hacker" as u said

and gdb revealed this

can we fix this because my4nodes will be useless!

Same as any other patch: patch -p1 or git am

Actually that should be in the recent release I expect.

So maybe get that.

patch number?

I don't have it here. You posted it yesterday.

(I think it was you ?)

this one

or this monero-project/monero #7873

moneromooo 7873 ?

Yes, 7873

thnx

moneromooo what to do when 2 commits conflict

7873 and 7803

i add before 7803 and now the only way is to remove 7803 if i want to insert 7873

You look at the diffs and fix so it is what it should be.

im not c++ guru

I can have a quick look if you paste the conflict.

to paste.debian.net please

All the text between <<<< and >>>>

paste.debian.net/1210239 and when i add what is need i have paste.debian.net/1210240

when i add again waht is need i have paste.debian.net/1210241

No context. I'll try to do it for you. 7873 and 7803 on top of master ?

yes

u want all file?

after being patched

Just wait. I'll apply those both and send you a merged patch.

ok

Yes, bad luck, half a dozen conlicts :/

both this patches are very important

what to do

Wait. I'm trying to resolve the conflicts.

ok

ffs, I hate those double refs, I never know how to use them -_-

hmm

why 7803 is not inserted yet

is very important i think

OK, sorry, too much work to go through for code I don't know.

Ask either vtnerd or wfaressuissia in #monero-dev, they're the authors of each so they'll at least know one of the patches.

ok thank u anyway

Ask the author of th epatch that's not merged yet, if one is merged.

no one is merged until now

Odd, I'd have thought the race would be important to get in.

if u c here monero-project/monero #7873 vtnerd knows that patches has conflicts

is like this commit was not added monero-project/monero #7873#commits-pushed-3c81ad5

i dont c it here patch-diff.githubusercontent.com/ra…nero-project/monero/pull/7873.patch

moneromooo maybe patch-diff.githubusercontent.com/ra…nero-project/monero/pull/7873.patch need update

Maybe. Ask one of the patch creators.

yes im asking no one is answering

vtnerd will likely answer within a couple days, he's on and off.

hmm maybe i found that patch-diff.githubusercontent.com/ra…nero-project/monero/pull/7874.patch is the update!

15:54 <moneromooo> Odd, I'd have thought the race would be important to get in. <-- stuck in review

selsta yes i took the patch and run but nothing chnaged!

same error

0x00007ffff7ce54cf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

i think that is smth else

some libc wrong version etc

ignore that clone.S thing

node crashes

why?

it must be something on your local enviroment

environment*

i have all debian

no one else reports these crashes

in 4 of 6 nodes crashes

lack of memory?

.merge+ 3685

Added

.merge+ 3682

Added

.merges

w0w so many prs

lots of work for luigi1111w

wen next release

tomorrow

rating89us: can you check 3435 again? I updated it, should work now

ok, will check soon

.merge+ 3435

Added

.merge+ 3686

Added