-
jjakob
can anyone confirm my suspicion that building the gui also builds the daemon (but doesn't produce the daemon binary)?
-
jjakob
since the submodule monero is included in cmakelists.txt
-
dsc_
it builds a fair part of Monero which is included as a submodule yeah
-
dsc_
the GUI needs this, specifically something called 'libwallet'
-
dsc_
which the GUI links against
-
jjakob
ah, it would be nice if common code were external so that it'd only need to be built once for the daemon and library
-
dsc_
jjakob: I agree! :-)
-
xmr-pr
mj-xmr opened pull request #3851: Doc: Minimize boost deps in README.md
-
xmr-pr
-
jjakob
-
jjakob
would the CMP0077 warning for BUILD_GUI_DEPS be causing this to build too much?
-
jjakob
I'm confused what should be installed by monero-gui and what by monero (daemon)
-
jjakob
the gentoo package for monero builds daemon, wallet-cli, wallet-rpc, hw-wallet
-
jjakob
tools?
-
jjakob
-
selsta
.merge+ 3851
-
xmr-pr
Added
-
selsta
-
selsta
-
selsta
otherwise it doesn't need anything from monero
-
jjakob
I don't understand then why it also builds all the monerod, monero-blockchain-*, monero-wallet-{cli,rpc}
-
jjakob
my thought is just to rm those from the build dir, before the install phase, so they don't conflict with those already installed on the system
-
selsta
you can do just `make -C build monero-wallet-gui`
-
selsta
then it shouldn't build the other binaries
-
selsta
but you have to run cmake first
-
jjakob
I don't know. This is all somehow automated in portage's cmake.eclass
-
jjakob
-
selsta
I'm not a gentoo user so I can't help there.
-
selsta
but yes you can delete them from the build dir too
-
jjakob
that ebuild already worked, I'm updating it to 0.17.3.1 and also switching from git to source archives
-
jjakob
something in the meanwhile has changed
-
jjakob
the default target in Makefile has that cmake command?
-
selsta
which cmake command?
-
jjakob
cmake -D DEV_MODE=$(or ${DEV_MODE},OFF) -DMANUAL_SUBMODULES=${MANUAL_SUBMODULES} -D BUILD_64=ON -D CMAKE_BUILD_TYPE=Release ..
-
selsta
yes
-
jjakob
you can see the cmake that portage runs in that 0x0 upload line 52
-
jjakob
MANUAL_SUBMODULES=ON is that ok?
-
selsta
yes, that just means it doesn't check the submodules
-
jjakob
CMAKE_BUILD_TYPE=RelWithDebInfo
-
selsta
try to set it to Release
-
selsta
but don't think it will matter
-
jjakob
look at line 192, maybe? but I don't think so
-
jjakob
also it doesn't set DEV_MODE as a cmake arg
-
selsta
DEV MODE means it automatically updates the submodule, also something you don't need
-
jjakob
but I think it defaults to off
-
selsta
yes
-
selsta
I don't see how CMP0077 is related
-
xmr-pr
elibroftw opened pull request #3852: Make fiat price APIs more flexible
-
xmr-pr
-
jjakob
selsta: I tried setting it to Release, no change
-
selsta
when was the last time it worked correctly?
-
jjakob
I don't know, maybe never, with that old ebuild I linked here, I had a manual "dobin" which only installed monero-wallet-gui, so there could have been all the other binaries also, but there was no conflict
-
selsta
like I said, can you try to just build monero-gui? I posted the command before
-
selsta
mkdir build
-
selsta
cd build
-
selsta
cmake ..
-
selsta
cd ..
-
selsta
make -C build monero-wallet-gui
-
selsta
that should only build one binary