-
SNeedlewoods
-
SNeedlewoodsA while ago I reported overlapping elements in the gui (screenshots above)
-
SNeedlewoodsnow I changed two lines of code and checked for every language that is currently available, that the issue is resolved.
-
SNeedlewoodsBut because there are a lot of untranslated strings, some future changes (if the translated string is longer than the source string) will probably cause new problems. I don't know if there is a dynamic solution with qml, which someone with more skills is able to implement!?
-
SNeedlewoodschanges I made:
-
SNeedlewoodswizard/WizardRestoreWallet1.qml -> line 115 -> "spacing: 30" to "spacing: 200"
-
SNeedlewoodswizard/WizardDaemonSettings.qml -> line 107 -> added "spacing: 200"
-
SNeedlewoodsI plan to look for similar issues on other windows, but this already took a me while...
-
SNeedlewoodsShould I (learn how to do and then) do a PR with these changes, or wait until I checked for more and then merge all at once?
-
moneromooooLearning how to do one is not wasted work. If you post a PR now, and it doesn't get merged soon, you can always add more to the PR later.
-
moneromooooTo add to the same commit: git add src/file.c ; git commit --amend
-
moneromooooThen, to update the PR: git push -f github branchname (ie, just add -f to the original push command line)
-
moneromooooReplace "github" with the name you gave that remote, and "branchname" with the actual brach name.
-
SNeedlewoodsthanks, that's really helpful, I'm gonna save these commands