-
m-relay
<jpk68:matrix.org> Qt6 migration PR seems to be looking for reviews now (I'm sure people will have seen this anyways)
-
m-relay
<jpk68:matrix.org> It doesn't seem to compile for me... also, the use of `mmap` in the helper script could be a bit problematic
-
m-relay
<ofrnxmr:xmr.mx> .. i doubt its going to get a proper review in its current form
-
m-relay
<ofrnxmr:xmr.mx> Its like 100 messy commits and, just on the ci, there are a bunch of random changes, and capped off with a merge commit
-
m-relay
<ofrnxmr:xmr.mx> Idk if this is majority AI development, or just messy.. (i havent looked in depth), but i dont like it
-
tobtoht
yea this isn't going to get reviewed without passing CI
-
tobtoht
getting builds working for all targets is most of the work for the migration
-
tobtoht
it doesn't help that GUI build system is in a pretty abysmal state
-
tobtoht
at this point migrating to Guix might make sense, since most of it can be copied from Feather
-
tobtoht
might be possible to piggy back off Guix/depends scripts in the monero submodule (once the release branch has it) and just maintain a GUI specific manifest and extra depends package definitions in the GUI tree, rather than copying over everything
-
plowsof
a Monero gui re-skin for feather is the only way (re-adding the freezing and delays like for like will be the hardest part)
-
plowsof
otherwise the end user will notice something changed :P
-
m-relay
<jpk68:matrix.org> Yeah, probably the latter
-
m-relay
<jpk68:matrix.org> Has this been merged into master yet? Sorry for being out of the loop :P
-
m-relay
<ofrnxmr:xmr.mx> Ya. Master uses guix
-
m-relay
<jpk68:matrix.org> Any idea when this will be merged into a release? I'm just catching up with the Gitian/Guix stuff now :)
-
m-relay
<ofrnxmr:xmr.mx> when we create a new major version
-
m-relay
<ofrnxmr:xmr.mx> There are some people who want to branch from master to create v0.19 asap (myself included), but it might not happen before fcmp hardfork
-
m-relay
<jpk68:matrix.org> So the first 0.19 release will be the same one that includes the FCMP++ logic?
-
m-relay
<jpk68:matrix.org> Or that's more around the time the hardfork is supposed to activate?
-
m-relay
<ofrnxmr:xmr.mx> Possibly
-
m-relay
<ofrnxmr:xmr.mx> depends if we branch "now" or if we wait for the hard fork
-
m-relay
<jpk68:matrix.org> Thanks, yes, I meant if we didn't :)