<jpk68:matrix.org> selsta: How do you suggest I implement a sort of status label in the GUI for the I2P router's up/down status?

<jpk68:matrix.org> It seems the best way is to make a C++ function invokable from Qt that uses QTcpSocket to ping the SAM bridge

<jpk68:matrix.org> I'm not completely sure though, and it might be a pain if we don't use Qt networking stuff already

<jpk68:matrix.org> This is what it looks like right now

<jpk68:matrix.org> mrelay.p2pool.observer/m/matrix.org/BIHwiStUlwuCjEcFmjnmnMNT.png (clipboard.png)

yes, we don't use Qt networking so I'd prefer not adding that dependencies

the epee http client might work?

Also I'm not really sure how the integration looks like, what exactly happens once you select I2P?

<ralphcc:zano.org> Hi. Does anyone know how to resolve an error when attempting to Solo Mine on the Linux GUI?

<ralphcc:zano.org> The log seems to indicate it cannot “find” the daemon despite running a fully synced local node. I have screenshots and the full log in case it helps shed some light.

<ofrnxmr:xmr.mx> sure, send screenshots

<ralphcc:zano.org> mrelay.p2pool.observer/m/zano.org/bNcEBUCXNTiJCEjoHtrdWrEc.png (Local Node Daemon.png)

<ralphcc:zano.org> mrelay.p2pool.observer/m/zano.org/oJucKHvlraieOnhskqCWFytY.png (Mining Error.png)

<ralphcc:zano.org> mrelay.p2pool.observer/m/zano.org/iDhyYVNdhtHlCOxejBUvpyEG.png (GUI Log.png)

.merge+ 4623

Added

<jpk68:matrix.org> selsta: It just restarts the daemon with the SAM flag

<ofrnxmr:xmr.mx> fwiw, i think the sam flag should probable go into the gui config file

<jpk68:matrix.org> Maybe, but also, it only works in its current state with a local full node

<jpk68:matrix.org> SAM is integrated only into the daemon (not wallet2, etc.)

<ofrnxmr:xmr.mx> yes, but other flags are in gui config

<ofrnxmr:xmr.mx> like pruneBlockchain=true

<jpk68:matrix.org> Makes sense, I didn't know that :)

<ofrnxmr:xmr.mx> blockchainDataDir etc

<jpk68:matrix.org> selsta: SAM uses raw TCP instead of HTTP. Would Boost work better for that then?

<ofrnxmr:xmr.mx> yeah, i only learned about it when looking into it for another user

<jpk68:matrix.org> FWIW the header I'm using currently is <QTcpSocket>

ok, but if it restarts the daemon with sam flag i don't know if it makes sense to add sam logic into the GUI, the daemon should say if it works, no need to manually do raw TCP

<jpk68:matrix.org> No, it's for giving up/down status of the I2P router

i know but why is that info not given by daemon

<jpk68:matrix.org> How would it be given from the daemon and displayed in a text label (see above screenshot)? My understanding is that would require a new RPC endpoint or something

<jpk68:matrix.org> The current commit I have for it on my fork works functionally perfectly fine (using Qt sockets)

I feel like there is a layer mismatch here. The daemon is the one communicating with SAM, so it's the daemon that should say if it can access to router or not. Adding custom TCP code to the GUI is not the right solution, especially since other projects would have to copy this.

And this isn't taking into account that I'm currently working on Qt6 upgrade where we would slim down unused packages.

<jpk68:matrix.org> For context, this is the code in question

<jpk68:matrix.org> codeberg.org/jpk68/monero-gui/pulls…bc7f27fdf27a15f90b345abbf30f8757cd0

<jpk68:matrix.org> It does not communicate over SAM, it literally just sees whether the socket is open

<jpk68:matrix.org> If you're just using the daemon by itself, you can already see through the error messages if the SAM bridge is not open. However, the daemon logs are somewhat opaque in the GUI (by design) and it would be nice to have a friendly, graphical way to see router status. As is mentioned in the CCS :)

but isn't that also misleading? it just checks a port, it does not even tell if it is a SAM router running?

adding a huge Qt depedency (network) for a port check seems like a waste

I would prefer if the daemon itself would give a status message to the gui somehow, I can't tell you the best design for it yet

dependency

<jpk68:matrix.org> It checks the address + port combo provided by the user. I agree with you in that we shouldn't add more dependencies > <selsta> but isn't that also misleading? it just checks a port, it does not even tell if it is a SAM router running?

<jpk68:matrix.org> Since we already use Boost.Asio that might be a bit better (?)

we don't use any boost code in monero-gui currently but it's a dependency from monero itself

also not ideal hmm

<jpk68:matrix.org> I would prefer not to use the POSIX API, lol

<jpk68:matrix.org> Looks like the epee thing worked

.merge+ 4625

Added

.merges

4623 4625

done

.merge+ 4626

Added

luigi1111: please also merge ^ and tag v0.18.5.1 gui

<plowsof:matrix.org> 🚀

.merges

4626