-
sech1hyc tevador/RandomX #273 - it looks like that we didn't save FP rounding mode in Windows binaries. I added CI tests and discovered it.
-
hycI dunno how to review the yaml stuff but the other two look ok to me
-
sech1you can check syntax at yamllint.com
-
sech1It's just a sequence of commands for Github actions
-
hycanyway, isn't fpu state per-thread already? failing to save/restore it isn't going to affect most users because they're only running a miner anyway
-
sech1it's per thread
-
sech1all incoming Monero blocks are also verified, so RandomX hash is calculated somewhere (not sure which thread)
-
hycyeah but monerod doesn't use floating point for anything else
-
hycor nothing consensus related anyway
-
sech1yes
-
sech1but someone who uses RandomX lib can get unexpected results
-
hycright. just seems unlikely they're doing anything besides mining.
-
sech1This PR also runs tests on s390x architecture (big endian), among other things. Good to know it's not broken :)
-
hycnice... it's so annoying that so much software is written with implicit little-endian dependency these days. like authors aren't even aware
-
sech1I tried it on p2pool and it's broken everywhere on s390x :D