-
br-m<jeffro256> If this is planned to be a stable feature, can we have a C endpoint exposed for it, please? > <sech1> Don't even need to create a new vm, see "test_switch" in src/tests.cpp
-
DataHoardersomething along the lines of RANDOMX_EXPORT void randomx_vm_set_flags(randomx_vm *machine, randomx_flags flags);?
-
DataHoarderas it has set_cache and set_dataset already
-
DataHoarderand otherwise it's init as RANDOMX_EXPORT randomx_vm *randomx_create_vm(randomx_flags flags, randomx_cache *cache, randomx_dataset *dataset);
-
sech1No, `randomx_vm_set_flags` won't work on the already created vm
-
sech1Only v2 flag was implemented to be dynamic
-
sech1Why C API for this? setFlagV2/clearFlagV2 are available in randomx_vm class, it should be enough for monerod
-
sech1Adding an API for a one-time event seems an overkill
-
DataHoarderyeah, which is why just calling randomx_create_vm effectively just does this tbh
-
DataHoarderit's 2 MiB+ a bit of state if you want to keep two at the same time
-
DataHoarderIf they want to use the C++ stuff then they have access to more