-
ErCiccione
PR process is the same, but tracked on the kanban board. Thanks for the blog post :)
-
ErCiccione
Does it worth to have the "encryption" moneropedia entry when it's basically parts of the wikipedia entry?
getmonero.org/resources/moneropedia/encryption.html
-
ErCiccione
i would be inclined to remove it considered that it will take effort to make it translatable and that people will have to translate it.
-
carrington[m]
Doesn't make sense to me for that to be on moneropedia. It is not Monero-specific
-
ErCiccione
-
ErCiccione
we have other non monero-specific entries, but make sense to keep them. I'll give a quick look to see if we should remove something else
-
QuickBASIC
ErCiccione Windows borked line endings on my local repo. Just syncing it back down to my other machine so I can commit the changes properly, but should be updated with suggested changes in next 10-15mins or so.
-
QuickBASIC
ErCiccione Thanks for reviewing the PR. it's updated with you and sech1's suggested changes.
-
selsta
would it make sense to delay to blog post until we have a new release out that supports the zmq changes?
-
selsta
or better to release it now?
-
ErCiccione
fine to wait for me if it makes more sense.
-
QuickBASIC
ErCiccione... I just noticed that the '@' links aren't working on my local copy or in the netlify thing. Does some other translation happen after it's posted to add the Moneropedia links?
-
ErCiccione
All links are not working? They should. Translations are not related btw, the links should show up anyway
-
QuickBASIC
selsta the release version comes with a precompiled monerod with the changes. Perhaps we should add a disclaimer about it?
-
ErCiccione
ah wait, maybe we don't have those in blog posts
-
ErCiccione
what disclaimer would you add?
-
QuickBASIC
-
QuickBASIC
I wish they worked in blog posts. I think that would be neat.
-
ErCiccione
just checked, yeah we don't use them there. you can add `{% t global.lang_tag %}` under the front matter and they will work
-
ErCiccione
thinking that probably makes sense to add it to a header or something to make them work everywhere
-
QuickBASIC
ErCiccione "what disclaimer would you add?" Line 47: - [P2Pool Download](
github.com/SChernykh/p2pool/releases) *Note: running P2Pool currently requires changes that are not currently in the official release of Monero. You can review these ongoing changes at this [link](
github.com/SChernykh/monero/tree/p2pool-api-v0.17).
-
QuickBASIC
The missing changes are only some ZMQ RPC stuff. The wallet stuff is already in last point release.
-
ErCiccione
I wouldn't put so much info in the blog post. it's enough to link to the readme or the the docs where the installations steps are explained imo
-
QuickBASIC
ErCiccione Agree. I was just trying to address selsta's concern about waiting until it works with Official Monero release.
-
ErCiccione
either way is fine for me.
-
QuickBASIC
I think we should leave it out. If people are worried they'll know how to find the changes and read the source.
-
ErCiccione
to be honest i'm not a huge fan of posting the donation address in the post, i would prefer to link to the "donations" section of the github repository, but it's not a big deal
-
QuickBASIC
But I think we should publish the blog post soonish. Some pools (XvB) are already shutting down in favor of p2pool and it would be nice to announce binaries so less technically inclined folks can join in.
-
QuickBASIC
That's easy enough to change.
-
QuickBASIC
ErCiccione Leave section in and change line 54: If you'd like to support further development of Monero P2Pool, SChernykh has a donation address on his [GitHub page](
github.com/SChernykh/p2pool#donations).
-
QuickBASIC
I want to put "labor of love" verbiage in but the tone is wrong lol. Dude wrote the whole thing on a 3 week vacation haha.
-
ErCiccione
QuickBASIC: sounds good to me
-
QuickBASIC
I'm loving the plugins for VSCode that treat spelling mistakes as compiler warnings and gives markdown formatting warnings.
-
selsta
QuickBASIC: I'm not going to block the blog post, if others think it's fine to release with bundled monerod it's also fine with me
-
QuickBASIC
selsta Thank you. I didn't mean to imply that you were blocking blog post. Just trying to see if we could assuage any concerns.
-
QuickBASIC
Is there a way to skip loading all the translations for changes that don't touch them i.e. the blog posts don't have any translation elements that I know of. I'm using `bundle exec jekyll serve --limit_posts 3` and 90% of the loading time is building the site for each translation.
-
QuickBASIC
ErCiccione^
-
selsta
QuickBASIC: you can change the config file
-
selsta
-
QuickBASIC[m]
selsta ah thank you.
-
QuickBASIC[m]
^QuickBASIC I forgot I changed my matrix name lol.
-
QuickBASIC
Weird it showed a different name in Matrix.