-
ErCiccioneQuickBASIC: For the links to work we just need to add a snippet in the blog post. I'll add it to the template on the readme so people can just copy that. Older blog posts don't have them because we never used links there. We started with the last blog post. As i said, my comment is not a stopper and we can always add them later.
-
ErCiccioneFYI this is what needs to be added for links to work: monero-project/monero-site #1838
-
ErCiccione<ErCiccione> "just checked, yeah we don't..." <- btw QuickBASIC i did tell you how to make links work ^. But apparently you didn't add that and instead removed the @link from the blog post?
-
ErCiccioneplease if somebody suggest a a change in a review, implement it or comment about it. Already happened a couple of times in your PR that a change was suggested, you marked the comment as resolved and agreed to make the change, but then you didn't implement the change or implemented something different. You acked the change for the links on github but then didn't implement the snippet to make them work, as requested, you instead removed the links
-
ErCiccionewithout saying anything. That's not nice.
-
ErCiccioneWe have a suggestion for a "transaction weight" moneropedia entry. Please comment here: monero-project/monero-site #1461#issuecomment-931294988. If we like that one we will probably have to recover that PR because i'm not sure the guy is still around
-
ErCiccioneactually probably a good idea to post that on the MRL page.
-
ErCicciones/page/room
-
ErCiccioneQuickBASIC: what vscode plugins do you use for spell checking and markdown formatting btw? I tried some long time ago but i found them more annoying than useful :)
-
ErCiccioneJust pushed monero-project/monero-site #1856, which updates the translations and more importantly, adds a new one: greek.
-
ErCiccioneLooks like the bot got confused and thinks i'm a first time contributor. Please unlock the workflows at the bottom. Ping binaryFate
-
ErCiccionethanks
-
binaryFatedone
-
QuickBAS-<@ErCiccione> QuickBASIC: For the links to work we just need to add a snippet in the blog post. <--- Ack I'm fixing now. I'm sorry for misunderstanding. I totally missed the part about the snippet in IRC on Sep 19th around 1830 UTC. (I see it now in my scrollback). I didn't intentionally ack and not do the fix in the review. I'm not sure how I
-
QuickBAS-missed that.
-
QuickBAS-Urgh... my ZNC is broken again.
-
QuickBAS-ErCiccione, testing locally before I squash and update the PR.
-
QuickBASICErCiccione mea culpa, mea maxima culpa... I blame lack of coffee. I definitely didn't mean to revert after the ack without noting the change. I missed your message in IRC that said how to fix it and also misunderstood the bit in the PR review (I suggest instead of linking to an unrelated PR with how it was fixed there that you put the suggested fix
-
QuickBASICdirectly in the PR review if it's only one line like that though). I've updated the PR with the suggested changes.
-
QuickBASICErCiccione: what vscode plugins do you use for spell checking and markdown formatting btw <--- not sure how to link, but markdownlint by David Anson (gives "compiler" warnings for markdown no nos) and Code Spell Checker by Street Side Software (lets you save dictionaries per user, per workspace, or globally which I need because I don't want my
-
QuickBASICmonero-site dictionary when I'm working on something for work or one of my other projects)
-
QuickBASICI'll also do up a Moneropedia page for P2Pool this weekend sometime.
-
ErCiccioneNo worries not a big deal, i realized you probably missed the comment 🙂 Thanks for the pointers!