-
ErCiccionetempor<plowsof11> "it was a tiny 1~ line conflict..." <- You don't need to close a pr and open another one in case of a merge conflict, but anyway, as i mentioned with the user guides, please don't merge 2 very large prs, especially if they were both already reviewed and approved, because now they need to be reviewed again. It would have been easier and more convenient to fix the 2/3 pr (opening a new one is ok too). Not a big deal, now
-
ErCiccionetemporwe can re-review the 2 prs that became one, so we can merge and deploy after (we cannot already deploy because the first part was merged, but references the other 2, which are not, and would result in links 404ing )
-
xmr-prerciccione opened pull request #2115: footer: i18n for onion link text
-
xmr-pr
-
plowsof11i was happily fixing the conflicts when i decided to force push - noticed 0 commits on the PR and seen github had automatically closed the issue as completed, the rest is history, my apologies, live and learn
-
ErCiccionetemporplowsof: the pr looks good to me except for this line: monero-project/monero-site #2074/files#diff-34a9ca1e2aeab0143e287b53ad120ee9cb3b06d12bb08ffa32b901b36b0b5735R12
-
ErCiccionetempori guess P2Pool was a concept was first developed is a typo
-
plowsof11good spot, thanks, will fix
-
ErCiccionetemporNote that jekyll-multiple-languages-plugin, which is a fundamental dependency in our getmonero's setup, is in maintainance mode and hasn't seen any update in almost a year. With this PR i'm already forcing an earlier version of the plugin (1.7.0) because otherwise things break.
-
ErCiccionetemporThe situation has only become worse from one year ago and i'm starting to see moving to another generator as inevitable.
-
ErCiccionetempor
-
xmr-prerciccione opened pull request #2116: gems: update dependencies
-
xmr-pr
-
plowsof11revewed/approved #2116 - i have no idea about other generators or their pros/cons compared to what is being used now. ErCiccione (temporary) ive also made the suggested fix to the p2pool typo, as an extra commit