-
ErCiccioneluigi1111 please merge when you have a chance
-
hardenedsteel[m]What I'm doing wrong? All checks keep failing for my pull request - monero-project/monero-site #2044
-
plowsof11complaining about an old blog post "Conversion error: Jekyll::Converters::Markdown encountered an error while converting '_posts/2022-08-11-monero-GUI-0.18.1.0-released.md':" hm
-
plowsof11just sanity checked master builds fine. suggested the fix (moneropedia indented)
-
plowsof11im wondering why newsletters are hardcoded and not generated from the yml files like the matrix hangouts page are (easier to add/remove in the future) - something to consider monero-project/monero-site #2158#issuecomment-1516913937
-
plowsof11out of scope for now i think , would be ideal later
-
plowsof11descriptions in en.yml / links in _data/newsletters.yml 🤷
-
ErCiccione<plowsof11> "im wondering why newsletters are..." <- what newsletters?
-
ErCiccionei don't see _data/newsletters, but some things were left were they were for the records
-
ErCiccioneah it's about the pr. nevermind
-
hardenedsteel[m]<plowsof11> "im wondering why newsletters are..." <- newsletter links are in yml file if that's what you mean.
-
hardenedsteel[m]<plowsof11> "im wondering why newsletters are..." <- if we put the links in .yml file we would have to change each .yml file when the links are changed.
-
ErCiccioneThe two pages work in a different way. That's why makes sense to have a dedicated .yml file that we can loop through. Here i wouldn't hardcode links.
-
ErCiccione
-
hardenedsteel[m]What hyphen means in .yml files?
-
plowsof11i dont know hardenedsteel but after searching its something to do with lists idratherbewriting.com/documentation…yaml_tutorial#example-3-simple-list