<r​brunner7:monero.social> Meeting in a bit more than 1 hour

<r​brunner7:monero.social> Meeting time. Hello! monero-project/meta #1232

<s​needlewoods_xmr:matrix.org> hey

<j​berman:monero.social> *waves8

<j​berman:monero.social> *waves* *

<r​brunner7:monero.social> Alright, let's start with the reports from last week

<s​needlewoods_xmr:matrix.org> mainly worked on multisig, will need to spend some time testing when everything is ready

<s​needlewoods_xmr:matrix.org> `grep "\<m_wallet\>" src/simplewallet/simplewallet.cpp -c` now gives 326 results on my branch, 668 on master

<s​needlewoods_xmr:matrix.org> Also noticed there is a problem with the methods that take `char *password` as argument (from my [remove cached password PR](monero-project/monero #9915/commits/214bbf59092337987830dbfe66c574c7fe708566)). AFAICT after debugging, it is no issue if the pointer comes from a `string` (as it is the case in the GUI), but `wipeable_string` is not zero-terminated, s<clipped

<s​needlewoods_xmr:matrix.org> o if you just pass `wipeable_str.data()` it will read the password + random amount of random bytes until next zero-byte.

<s​needlewoods_xmr:matrix.org> To solve this I added function overloads with `size_t pw_length` ([commit](monero-project/monero a5fc39d)).

<s​needlewoods_xmr:matrix.org> Haven't changed #9915 yet, but I'd say that we should not allow the potentially dangerous functions like `setPassword(const char *old_password, const char *new_password)` without `size_t pw_length`. So instead of overloads I would just replace the functions, do you agree?

<r​brunner7:monero.social> Sounds good

<r​brunner7:monero.social> You mean your *own* new methods that take a password in the form of `char *password`?

<s​needlewoods_xmr:matrix.org> yes, not merged into monero-project yet

<r​brunner7:monero.social> Then yes, I would make them safe

<r​brunner7:monero.social> But where would the caller get the length from?

<j​berman:monero.social> me: contest review/handling, PR wrangling, nothing significant to share since last week

<s​needlewoods_xmr:matrix.org> `wipeable_string.size()`

<r​brunner7:monero.social> I see

<r​brunner7:monero.social> jberman: Say again, when is the new, extended contest deadline?

<j​berman:monero.social> helioselene deadline extended to July 10th, 17:00 UTC

<j​berman:monero.social> github.com/j-berman/fcmp-plus-plus-…selene-submission-deadline-extended

<r​brunner7:monero.social> Hopefully the updated rules do not allow any more loopholes or still offer room for misunderstandings ...

<s​needlewoods_xmr:matrix.org> sorry brb

<r​brunner7:monero.social> Who would have thought that the contest would get into such rough waters :)

<r​brunner7:monero.social> There is a second submitter for Helioselene beside dimalinux, right? You did not hear much from them?

<j​berman:monero.social> We're in contact via DM, they are aware of the latest

<r​brunner7:monero.social> Ok, so just less public drama :)

<j​berman:monero.social> pw_length makes sense to me here (unfortunately)

<j​berman:monero.social> Yep 👌

<r​brunner7:monero.social> Alright, do we have something to discuss beyond these reports?

<r​brunner7:monero.social> Does not look like it. Thanks everybody for attending, read you again next week!

<j​berman:monero.social> Doesn't need an answer right now, but was curious if you may have any thoughts on deprecating Boost serialization for MMS messages here: monero-project/monero #9940

<r​brunner7:monero.social> Don't see any problem with that. MMS does not work properly anymore anyway, and with tobtoht hopefully sooner or later bringing some successor to the table I don't think Boost support matters in any way here.

<s​needlewoods_xmr:matrix.org> >MMS does not work properly anymore anyway

<s​needlewoods_xmr:matrix.org> that's good to know, can skip investigating how that works then

<s​needlewoods_xmr:matrix.org> only first line should be quote

<r​brunner7:monero.social> You mean because of any relevance for your extended / completed Wallet API? Yeah, somehow I don't see that supporting it there would make sense.

<r​brunner7:monero.social> I just don't see clearly now whether not supporting it in the Wallet API would lead to a requirement to fully remove anything MMS related from the CLI wallet ...

<s​needlewoods_xmr:matrix.org> I was talking about my current "replace wallet2 from CLI", there I added `TODO`s to investigate mms monero-project/monero a6cbf24

<s​needlewoods_xmr:matrix.org> I'm actually not sure how far mms is/was ever integrated into the Wallet API, what's something I'd need to look into

<s​needlewoods_xmr:matrix.org> s/what's something/that's something

<r​brunner7:monero.social> No, the MMS never was in the Wallet API. But if you want, on the one hand, a CLI wallet that is free of `wallet2` references, thanks to your much extended Wallet API, but on the other hand don't want to support the MMS there, the logical consequence seems to be to rip out everything MMS

<s​needlewoods_xmr:matrix.org> sounds harsh, but if it doesn't work anymore ... I need to study that code, seems most of mms stuff is just in simplewallet, searching for mms in wallet2 only gives a dozen results

<r​brunner7:monero.social> I think a quick chat for you with tobtoht regarding this would be a good idea. I don't have recent info where they stand with their MMS alternative. I suspect that it's not imminent, so removing all the MMS code in `simplewallet` for the time being would maybe be painful, at least for me, but only logical.