-
m-relay<rbrunner7:monero.social> SNeedlewoods: I had a look at the "describe transfer" issue that you brought up in Monday's meeting, and I have a proposal how to implement that, let's see what you and maybe others here think:
-
m-relay<rbrunner7:monero.social> Add to the Wallet API a *struct* that closely mirrors `COMMAND_RPC_DESCRIBE_TRANSFER::response_t`, of course including equivalents for the sub-structs there like e.g. `transfer_description`
-
m-relay<rbrunner7:monero.social> And the Wallet API gets of course a call that returns that *struct* for a given tx set.
-
m-relay<rbrunner7:monero.social> The job of the RPC server becomes much simpler than today, because it's only question of moving everything over, more or less one-to-one.
-
m-relay<sneedlewoods_xmr:matrix.org> sounds good to me, thank you, working on something else right now so others have time to speak their opinions before I start implementing it
-
m-relay<rbrunner7:monero.social> Ok. Final remark: With this approach, the quite complicated and awfully specific code to fill that struct moves from `wallet_rpc_server::on_describe_transfer` to the new Wallet API method, maybe a better place for that.
-
m-relay<sneedlewoods_xmr:matrix.org> maybe this will also be useful for the wallet-cli, though so far I think I got all the info it needs from the current Wallet API without the new `TxDescriction` struct
-
m-relay<sneedlewoods_xmr:matrix.org> maybe this will also be useful for the wallet-cli, though so far I think I got all the info it needs from the current Wallet API without the new `TxDescription` struct