-
vtnerdspirobel: 'doubt btw that any of this is a bottleneck" => there is at least a 11% improvement to lws when switching to binary from json
-
vtnerdI made a mistake when running the perf tests -> I ran expand_transaction_1 when it could be skipped
-
vtnerdmind you this was a test with msgpack+epee tx compact (which is the fastest possible)
-
vtnerdand this was the total scan time, not the unpack time diff
-
vtnerd'monero adoption is this obscure epee stuff binary endpoints for both parameters' => yes ZMQ has JSON fields now that are exactly what you want. we can probably add this to some of the http endpoints, but its a bit funky because the two systems use different output systems
-
vtnerdthe problem with the ZMQ style is that the JSON output requires unpacking the tx from its internal format, and then writing out each component piece-by-piece
-
vtnerdthis slows down `monerod` responses by a decent amount, but I forget the overhead cost
-
vtnerdremoving expand_transactions_1 from the pathway would help, so the diff maybe somewhat small (but JSON is definitely slower)
3 hours ago