-
br-m
<jpk68:matrix.org> rbrunner7: Just leaving this here in case you're interested; I'm not sure how accurate of a retelling this is ;)
-
br-m
-
br-m
<rbrunner7> Thanks, will have a look later today
-
plowsof
an asmap (for outbound connections only atm) is added in
monero-project/monero #11474 , its currently 'bring your own --asmap file'. copied and licensed appropriately from bitcoin core. since feb they have moved to embedding the the .dat in their binary. i thought this would be a problem but we do the exact same thing with
-
plowsof
checkpoints.dat so its not much 'new' code to add. at release the .dat and hash file is bumped if an update exists @
github.com/bitcoin-core/asmap-data/releases
-
plowsof
was wondering if there where any opinions reg embedding the .dat file in our tree? the steps on top of 11474 look like
github.com/plowsof/monero/compare/asmap...test-asmap (which i again hope is licensed appropriately)
-
br-m
<jpk68:matrix.org> I would be in favour of something like this
-
selsta
I'd be okay with updating the .dat file during release.
-
br-m
<rbrunner7> Forgive me to be critical, but did somebody already check whether using this ASMAP stuff has actual, tangible benefits compared with the current approach? I don't remember whether @rucknium:monero.social tested something, or only had educated guesses. Peer selection is non-trivial, and in some cases the final result "How many of my peers are probably spy nodes" is hard to predict.
-
selsta
plowsof found new suspected spy nodes that bypass our current approach
-
plowsof
-
br-m
<rucknium> As of now, I am not opposed to this as an opt-in flag. IMHO, much more analysis would have to be done to set it as default.
-
plowsof
bitcoin is still opt-in currently, after all these years
-
br-m
<rucknium> To set it as default, you would want to have an analysis that shows, with reasonable confidence, that the cure would not be worse than the disease, as I did for the /24 subnet deduplication.
-
br-m
<rbrunner7> Well, ok, but Bitcoin is hardly a role model of adopting technological improvements ...
-
plowsof
:P this is true
-
br-m
<rucknium> An adversary could just spread across many ASNs, in response to a default rollout of this, potentially making the issue worse.
-
br-m
<rbrunner7> (regarding not yet default there)
-
br-m
<rucknium> There are many honest nodes concentrated in the ASNs of VPS vendors. An adversary could exploit the ASN avoidance logic to accumulate more outbound connections than the honest nodes.
-
br-m
<rbrunner7> Yes, in a bad case we do effort, change code, and let people update for nothing more than a placebo. Worst case it makes things worse.
-
br-m
<rucknium> ASNs are harder to analyze than subnets because ASNs do not have a defined size. I used the defined size of subnets in my game theory analysis.
-
br-m
<rbrunner7> Hmm. Maybe it would be nice to have this in the "bag of tools", so if the adversaries switch tactics we have another tool deployed already that people could use on short notice.
-
br-m
<rbrunner7> Maybe also has some effect as a determent?
-
plowsof
so there is an identifiable fleet of about 1.3k nodes who share the same fingerprint. the majority of which are in DigitalOcean
-
br-m
<rucknium> Analysis is here. See section 4 "Protocol-adversary interaction as a game" in particular:
github.com/Rucknium/misc-research/b…onero-peer-subnet-deduplication.pdf
-
plowsof
the asmap for outbound connections is not "the solution" it is part of the bag of tools
-
br-m
<jpk68:matrix.org> At least it would ostensibly make the attack much more expensive for them > <@rucknium> An adversary could just spread across many ASNs, in response to a default rollout of this, potentially making the issue worse.
-
br-m
<rucknium> @jpk68:matrix.org: Have you proved that?
-
br-m
<jpk68:matrix.org> No, I'm just spitballing :)
-
br-m
<jpk68:matrix.org> But it seems this entity is currently able to run spy nodes en masse through LionLink, which I can't imagine is too expensive compared to having to use a bunch of different providers
-
br-m
<rucknium> If its is made the default, you would also stress nodes in low-population ASNs by creating many inbound connections to them.
-
plowsof
it is opt-in with my proposed patch --asmap embedded or path
-
br-m
<rucknium> Yes. I've said already that I'm ok with it as opt-in, while we wait for better analysis of how the adversary could respond to this.
-
plowsof
every defence can be circumvented - the end goa is pushing chainalysis to host honest nodes that participate in the network
-
br-m
<jpk68:matrix.org> So this would be opt-in, with the embedded data?
-
plowsof
indistinguishable from the reference software
-
br-m
<rucknium> Not all defenses are equally easy to circumvent.
-
br-m
<rbrunner7> Meeting in 1 hour - bring you own pet spynode :)
-
selsta
jpk68: this new entity is not confirmed to be linked to LionLink
-
br-m
<jpk68:matrix.org> Ah, good to know
-
br-m
<rbrunner7> Meeting time. Hello!
monero-project/meta #1468
-
br-m
<sneedlewoods_xmr:matrix.org> Hello
-
br-m
<jpk68:matrix.org> Hello
-
br-m
<vtnerd> Hi
-
br-m
<rbrunner7> Maybe more people will join a little later, but let us start already with the reports from last week
-
selsta
hi
-
br-m
<jberman> waves
-
br-m
<jeffro256> Howdy
-
br-m
<sneedlewoods_xmr:matrix.org> will push an update to #9464 in a minute with some details in a comment
-
plowsof
👋
-
br-m
<rbrunner7> Alright, people arrived :)
-
br-m
<rbrunner7> Today is the day for next stressnet?
-
br-m
<rbrunner7> @jberman:monero.social certainly knows details
-
br-m
<jeffro256> yea!
-
br-m
<jberman> FCMP++ fork is activated on beta stressnet v3, a little over 200 blocks until the second fork activates that stops allowing legacy txs entirely
-
br-m
<sneedlewoods_xmr:matrix.org> @sneedlewoods_xmr:matrix.org:
monero-project/monero #9464#issuecomment-6000228481
-
br-m
<sneedlewoods_xmr:matrix.org> (will check the comment after the meeting, may contains errors or bad formatting)
-
selsta
we also (finally) tagged v0.18.5.3, release notes can be seen here:
monero-project/monero-site #2710
-
selsta
release should be out tomorrow
-
selsta
this was the last release of v0.18 (unless there is a major regression) and the next release will be from v0.19 branch
-
selsta
no more c++14/c++17 split
-
selsta
v0.19*
-
plowsof
👏
-
br-m
<rbrunner7> Quite a healthy list of contributors!
-
br-m
<rbrunner7> Quite a number of things look to me like things that AIs may find in code that nobody looked at for a quite a while. So we reduce technical debt, and also reduce the attack surface
-
br-m
<rbrunner7> For people who are maybe unaware, stressnet has its own dedicated matrix channel:
matrix.to/#/#monero-stressnet:monero.social
-
br-m
<rbrunner7> I joined Monero a few months after RingCT went live, so I just missed much of the fun there. Won't happen again with FCMP++ :)
-
br-m
<thomasbuilds:matrix.org> regarding the linenoise PR by jpk68, external/linenoise is upstream antirez/linenoise@a473823d plus about 515 changed lines in a single commit that doesn't record the base hash. shouldn't it commit a473823d untouched first and the changes on top, like for easylogging++ ?
-
br-m
<jpk68:matrix.org> I agree that this would be more ideal, though perhaps a better question would be whether it's worth it at this stage
-
br-m
<rbrunner7> What is "linenois"?
-
br-m
<rbrunner7> Er, linenoise of course
-
br-m
-
br-m
<jpk68:matrix.org> We are replacing the dependency on GNU Readline with a vendored and permissively licensed alternative
-
br-m
<rbrunner7> Ah, ok, that one
-
br-m
<jpk68:matrix.org> As a side-effect, this lets us remove something to the effect of 90K lines of code
-
br-m
<jpk68:matrix.org> *in dependencies
-
br-m
<rbrunner7> What?
-
br-m
<rbrunner7> Nice.
-
br-m
<jpk68:matrix.org> I'm dumb, nevermind, it's ~34,000 lines
-
br-m
<vtnerd> I don't quite get this arbitrary loc argument, is linenoise battle tested like redline? Has someone reviewed all of linenoise code to make it worthwhile?
-
br-m
<jpk68:matrix.org> > used in Redis, MongoDB, Android and many other projects.
-
br-m
<vtnerd> Well there's a start, but sounds like no one reviewed the code
-
br-m
<thomasbuilds:matrix.org> yes it's been heavily reviewed tbh
-
br-m
<thomasbuilds:matrix.org> well me and Ap4sh did
-
br-m
<jpk68:matrix.org> @vtnerd: Would you mind elaborating on what you mean by that? You mean the changes I made to the vendored code?
-
br-m
<vtnerd> I mean if we're going with the smaller lib (perhaps not as small as I thought), has someone associated with Monero reviewed this code injection into our codebase
-
br-m
<vtnerd> Like actually read linenoise source
-
br-m
<thomasbuilds:matrix.org> Committing a473823d untouched first would let everyone see what changed vs upstream with git diff in monero's own history. Right now that means fetching antirez/linenoise, working out which commit it is and relying on his repo > <@jpk68:matrix.org> I agree that this would be more ideal, though perhaps a better question would be whether it's worth it at this stage
-
br-m
<rbrunner7> Hmm, the work done to fix all problems as detailed in the PR don't look exactly like an easy drop-in replacement at first sight?
-
br-m
<syntheticbird> @thomasbuilds:matrix.org, Ap4sh and @jpk68:matrix.org sounds like the new generation of monero maintainers
-
br-m
<syntheticbird> im feeling so old
-
br-m
<jpk68:matrix.org> @vtnerd: I assume tobtoht has done something like that, considering he suggested this change
-
br-m
<thomasbuilds:matrix.org> @syntheticbird: wdym lol
-
br-m
<syntheticbird> @thomasbuilds:matrix.org: don't be naive or i'll consider you as an ORCHESTRA asset. ARE YOU CIA THOMAS ? JUST KEEP BUILDING AND TAKE CREDITS WHEN IT COMES TO YOU ALRIGHT
-
br-m
<thomasbuilds:matrix.org> btw tobtoht supports the PR, this isn't a non wanted PR so far
-
br-m
<jpk68:matrix.org> Jeffro was also in support of the change, IIRC
-
tobtoht
We can't use readline because it is GPL, which is incompatible with BSD-3.
-
br-m
<vtnerd> @jpk68:matrix.org: I think the answer is no, but I guess it's not terrible as it's not a niche as I thought
-
br-m
<jpk68:matrix.org> I could be misremembering something
-
br-m
<syntheticbird> my bad we're in meeting, sorry to yell like that
-
br-m
<rbrunner7> "requested that I work on it" Maybe better say tobtoht proposed that you work on it
-
br-m
<jpk68:matrix.org> Orchestra?
-
br-m
<vtnerd> Ah, that is sadly a good reason @tobtoht:monero.social:
-
br-m
<thomasbuilds:matrix.org> @syntheticbird: I still don't get it lol
-
br-m
<thomasbuilds:matrix.org> like u say the PR is under reviewed still?
-
br-m
<vtnerd> Is that directed at me?
-
br-m
<jpk68:matrix.org> @rbrunner7: I asked tobtoht for work to do because I was done everything else, and he said that would be a good thing to work on. Make of that what you will ;)
-
br-m
<syntheticbird> @thomasbuilds:matrix.org: Im just saying you three have been contributing a lot in the recent months and that is great to see, even more to see you are collaborating between each others and not isolated PR farms.
-
br-m
<rbrunner7> So, do I read the room correctly that nobody is really enthusiastic about this change, but it seems to have a reason with the license problem, and nobody intends to veto it as of now?
-
br-m
<jpk68:matrix.org> I'm certainly enthusiastic about getting rid of more bloated GNU stuff :D
-
br-m
<rbrunner7> Ok, that
-
br-m
<thomasbuilds:matrix.org> @syntheticbird: ok yeah I get it basically I shouldn't assume it's "heavily reviewed" u mean
-
selsta
it appears one advantage is that it works under any TERM setting, currently our release binaries fail if someone uses a more exotic TERM setting
-
tobtoht
As a side effect we also get rid of ncurses.
-
br-m
<rbrunner7> What's to say about ncurses? It's big and only used for readline?
-
tobtoht
Yes and yes.
-
br-m
<rbrunner7> I see.
-
tobtoht
Also I can't figure out how to update it in depends.
-
br-m
<rbrunner7> It's cursed, clear as mud why you don't succeed.
-
br-m
<rbrunner7> Looks like we have reached something like "loose consensus" to indeed go ahead with this.
-
br-m
<jpk68:matrix.org> It would be good to hear opinions on this, as well ^ > <@thomasbuilds:matrix.org> regarding the linenoise PR by jpk68, external/linenoise is upstream antirez/linenoise@a473823d plus about 515 changed lines in a single commit that doesn't record the base hash. shouldn't it commit a473823d untouched first and the changes on top, like for easylogging++ ?
-
br-m
<jpk68:matrix.org> That is, the commit situation
-
tobtoht
You could split it into two commits?
-
br-m
<jpk68:matrix.org> That would be possible, yes, I just wanted to know if it's considered necessary
-
br-m
<jpk68:matrix.org> If everyone is fine with how it is now, I suppose it can just stay as it is
-
tobtoht
I don't particularly care much because I don't think we'll grab patches from upstream.
-
br-m
<thomasbuilds:matrix.org> why do you exclude this?
-
br-m
<rbrunner7> About another subject: A while before this meeting there was a discussion here in this room about a new tool useful in our ongoing fight against "spy nodes" - if interested check the backlog and this PR:
monero-project/monero #11474
-
br-m
<rbrunner7> Ok, something else still left to discuss today?
-
br-m
<sneedlewoods_xmr:matrix.org> @sneedlewoods_xmr:matrix.org: If anyone can take a look at and provide feedback for F3 or F4 for the first report in the linked comment, that would be appreciated
-
br-m
<sneedlewoods_xmr:matrix.org> not needed now though
-
br-m
<rbrunner7> Will try to have a look
-
br-m
<sneedlewoods_xmr:matrix.org> Thanks, already sent you a DM about another matter
-
br-m
<rbrunner7> I think I can close the meeting proper. Interesting stuff today! Thanks everybody for attending, read you again next week.
-
br-m
<sneedlewoods_xmr:matrix.org> Thanks everyone, cu
-
br-m
<jpk68:matrix.org> This was certainly one of the meetings of all time
-
br-m
<thomasbuilds:matrix.org> @thomasbuilds:matrix.org: anways main reason for me is for clean history of what happened
-
br-m
<jpk68:matrix.org> It seems no one is opposed, so I guess I can just do it
-
br-m
<jpk68:matrix.org> Will take six to eight business weeks to figure out how to fix the Git history /s
-
br-m
<thomasbuilds:matrix.org> thanks it's a small thing to do with no downsides
-
br-m
<thomasbuilds:matrix.org> afaik