-
br-m
<thomasbuilds:matrix.org> in case someone wants to address this issue:
-
br-m
<thomasbuilds:matrix.org> accented passphrases from Cake restore to a different wallet in Monero.
-
br-m
<thomasbuilds:matrix.org> would need a PR on Cake
-
br-m
<thomasbuilds:matrix.org> > crypt() skips NFKD so Cake-encrypted seeds with accented passphrases restore to another wallet in Monero
-
br-m
<jpk68:matrix.org> Cake seems to take forever to respond to PRs
-
br-m
<jpk68:matrix.org> At this point, it might be worth contacting them privately to ask them to take a look at it
-
br-m
<thomasbuilds:matrix.org> yeah they ignored my previous PR totally, didn't even run ci for it so I could potentially improve it
-
br-m
<thomasbuilds:matrix.org> it wasn't a bug fix and I disclosed full AI usage because I never used dart back then, but still running ci for it was the minimum
-
br-m
<jpk68:matrix.org> There's also this known bug in their Dart Polyseed library which isn't getting merged
-
br-m
-
br-m
<rbrunner7> Well, I would be very surprised if they changed behavior here in any way. They probably would not risk to cause problems for their users.
-
br-m
<rbrunner7> I guess if it has to do with Unicode normal forms some simple accented characters like é and ö are still ok, it needs something more "exotic" before there is trouble?
-
br-m
<jpk68:matrix.org> The one I linked to is a legit bug where seeds with restore dates after ~2040 will be rejected
-
br-m
<jpk68:matrix.org> Obviously not an issue right now, but why wouldn't you fix it? It's also not in accordance to the canonical impl
-
br-m
<ofrnxmr> @mrcyjanek0:matrix.org
-
br-m
<ofrnxmr> Maybe talk to the dev
-
br-m
<jpk68:matrix.org> Forgot he was here :P
-
br-m
<ofrnxmr> Its a small repo, posdible he just didnt see (or forgot about) the prs
-
br-m
<jpk68:matrix.org> Thomas has had a PR for the main Cake repo sitting for a few months
-
br-m
<jpk68:matrix.org> No response yet
-
br-m
<ofrnxmr> probably busy with zano, zcash, and mweb exploits :P
-
br-m
<sgp_> Speaking of polyseed, does anyone else have an opinion on this?
tevador/polyseed #25#issuecomment-6170942720
-
br-m
<thomasbuilds:matrix.org> @rbrunner7: é and ö are exactly the problem case lol
-
br-m
<rbrunner7> Oh, then it's bad.
-
br-m
<rbrunner7> And we don't have that problem already with the ages-old wallet passwords themselves? Only with Polyseed passphrases, because somebody had the genius idea to process that somehow first?
-
br-m
<rbrunner7> I mean wallet password compatibility between CLI wallet and Cake Wallet if the password has an accented or umlauted character in it
-
br-m
<thomasbuilds:matrix.org> > * polyseed_dart crypt() derives the mask from utf8.encode(password) - polyseed C (Monero) NFKD-normalizes the password first.
-
br-m
<thomasbuilds:matrix.org> > * With a passphrase, Cake's backup phrase is the encrypted seed, so Monero decrypts it with the NFKD bytes; if they differ → valid but different seed (no MAC) → empty wallet, no error.
-
br-m
<thomasbuilds:matrix.org> > * Affected: anything NFKD changes: precomposed accents (é → e + U+0301, ö, ñ, й), Hangul, kana with dakuten, fullwidth. Unaffected: ASCII (up to 575 bytes), CJK unified ideographs.
-
br-m
<thomasbuilds:matrix.org> > * A Monero-side fallback needs a non-normalizing crypt, which polyseed's API doesn't have.
-
br-m
<rbrunner7> Well, as there is no functional spec, I guess it's easy to overlook that normalization in the original Polyseed implementation in C, and then not doing that in a Dart port -> problems
-
br-m
<rbrunner7> What is this Dart function doing? utf8.encode(password) Doesn't Dart already use UTF-8 throughout for strings, why would it be necessary to "encode" the passphrase?
-
br-m
<rbrunner7> I guess if nothing else helps, restoring using the private key directly would be a last fallback
-
br-m
<jpk68:matrix.org> Dart doesn't necessarily use UTF-8 for strings
-
br-m
<jpk68:matrix.org> IIRC, they're UTF-16 / WTF-16
-
br-m
<rbrunner7> That surprises me now, given that Dart is a pretty young language ...
-
br-m
<jpk68:matrix.org> Well, since 2011
-
br-m
<jpk68:matrix.org> Older than Rust 1.0
-
br-m
<rbrunner7> Hmmm
-
br-m
<rbrunner7> Yeah, the internal character representation of C# is also not UTF-8, if I remember correctly - you don't often go down to that level.
-
br-m
<rbrunner7> Ok, enough Monero for today ...
-
br-m
<slowbeardigger:matrix.org> theres no such thing as enough monero for today
-
br-m
<slowbeardigger:matrix.org> havent seen the sun in days