-
lru
selsta: git clone
github.com/monero-project/monero.git && cd monero && git submodule init && git submodule sync && git submodule update && git checkout v0.17.2.0 && git submodule update # this fails, only --recursive on the update or the clone would fix it
-
selsta
lru: you have to do ?git submodule sync`
-
selsta
sorry, typo
-
lru
I did, see above :-)
-
selsta
you have to do `git submodule sync`after you checkout a branch / tag.
-
selsta
not before
-
lru
ok, let me try
-
lru
yep, order matters, thanks
-
selsta
`git submodule sync` and `git submodule update --init --force --recursive` usually solve all submodule issues
-
lru
I see the .gitmodules file changed between master and v0.17.2.0, which makes sync make sense now
-
selsta
yep, we changed a submodule to upstream
-
Lyza
<selsta> sometimes the window doesn't close; other times, if I leave it a few seconds, it "closes" but continues to run in the background
-
Lyza
or if I click the 'x' button twice. I'm not sure how this user would have had an instance running unknowningly without something similar happening, but perhaps
-
mj-xmr[m]
Lyza: It COULD be related to this, since you're talking about closing the app:
-
mj-xmr[m]
-
mj-xmr[m]
This and the linked PRs.
-
mj-xmr[m]
I don't know how much into C++ you are, but destructors are being called when an application exits.
-
mj-xmr[m]
And Undefined Behavior earns its name.
-
-
mj-xmr[m]
<NikolaIgnatovNed> "stopwatch" <- Nice try.
-
selsta
mj-xmr[m]: it's a GUI issue
-
Lyza
"<mj-xmr[m]> I don't know how much into C++ you are" just enough to be dangerous :D
-
Lyza
but yeah it's a GUI issue tho
-
alex[m]123456721
-
alex[m]123456721
^ proposal on deprecating integrated addresses due to their bottlenecking of batching withdrawals and other reasons, comments would be appreciated.
-
moneromoooo
Triptych embedded data could be used to store up to 3 of those per ring.
-
UkoeHB
Isn't it only per tx?
-
carrington[m]
+1 for anything which makes the network more homogenous
-
selsta
IMO the major reason would be UX, the concept of integrated address is difficult to explain to new users
-
selsta
especially when they send to an integrated address and the base address appears somewhere in the wallet and they think they sent to the wrong address
-
sethsimmons
<selsta> "especially when they send to..." <- The UX for this is *awful* as a Ledger user.
-
sethsimmons
The Ledger displays the non-integrated address, so it never matches.
-
sethsimmons
I would love to see IAs deprecated/removed in favor of subaddresses once and for all.
-
carrington[m]
As said in the github proposal, it probably makes sense to embed a "subaddress only" plan in with whatever the eventual "big ring upgrade" ends up beinh
-
carrington[m]
As that will require big upgrades across the ecosystem regardless
-
BusyBoredom[m]
I just finished making a payment processor for my website that uses integrated addresses, because I read that integrated addresses were the more performant option when tracking many payments as once.
-
BusyBoredom[m]
It was also easier to implement, because I didn't need to synchronize any counters between threads to keep track of which subaddresses are in use at any point in time.
-
BusyBoredom[m]
Do the downsides of integrated addresses outweigh these advantages?
-
alex[m]123456721
carrington: Seth your comments on the issue would be appreciated, otherwise it'll get lost in the noise.
-
alex[m]123456721
* carrington: Seth your comments on the github issue would be appreciated, otherwise it'll get lost in the noise.
-
sethsimmons
Yes, sorry, will comment there!
-
alex[m]123456721
> <@busyboredom:monero.social> I just finished making a payment processor for my website that uses integrated addresses, because I read that integrated addresses were the more performant option when tracking many payments as once.... (full message at
libera.ems.host/_matrix/media/r0/do…6b6898aad446bc338d36216e64be02f22e6)
-
BusyBoredom[m]
Fair enough, I'm happy to switch my project to subaddresses if that really is the recommended route now :)
-
BusyBoredom[m]
Or if it ends up being the recommended route
-
moneromoooo
It is the recommended route, and has been since it appeared on mainnet.
-
BusyBoredom[m]
Sounds good, subaddresses it is then. Side note then since it seems its info might be outdated, monerodocs is where I got my info when deciding whether to use integrated addresses or subaddresses:
monerodocs.org/public-address/integrated-address
-
lru
is this normal: Exception: boost::wrapexcept<boost::bad_weak_ptr>
-
lru
found in the logs